Skip to contentSkip to conversation

iio: adc: stm32-dfsdm: drop __func__ while using Dynamic debug

PATCH In review Mugilraj Dhavachelvan 3 participants 3 messages Apr 1, 2021 – Apr 2, 2021

Subsystems (2)
IIO Arm STM32
lore
Share & tools
lore

Mugilraj Dhavachelvan

author
#0 lore raw

PATCH 1/1 iio: adc: stm32-dfsdm: drop __func__ while using Dynamic debug

dropped __func__ while using dev_dbg() and pr_debug()

Signed-off-by Mugilraj Dhavachelvan <[email protected]>
---
 drivers/iio/adc/stm32-dfsdm-adc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/iio/adc/stm32-dfsdm-adc.c +5 -5
index 76a60d93fe23..95ec5f3c3126 100644
@@ -198,7 +198,7 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
 	unsigned int p = fl->ford;	/* filter order (ford) */
 	struct stm32_dfsdm_filter_osr *flo = &fl->flo[fast];
 
-	pr_debug("%s: Requested oversampling: %d\n",  __func__, oversamp);
+	pr_debug("Requested oversampling: %d\n", oversamp);
 	/*
 	 * This function tries to compute filter oversampling and integrator
 	 * oversampling, base on oversampling ratio requested by user.

@@ -294,8 +294,8 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
 				}
 				flo->max = (s32)max;
 
-				pr_debug("%s: fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
-					 __func__, fast, flo->fosr, flo->iosr,
+				pr_debug("fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
+					 fast, flo->fosr, flo->iosr,
 					 flo->res, bits, flo->rshift,
 					 flo->lshift);
 			}

@@ -858,7 +858,7 @@ static void stm32_dfsdm_dma_buffer_done(void *data)
 	 * support in IIO.
 	 */
 
-	dev_dbg(&indio_dev->dev, "%s: pos = %d, available = %d\n", __func__,
+	dev_dbg(&indio_dev->dev, "pos = %d, available = %d\n",
 		adc->bufi, available);
 	old_pos = adc->bufi;
 

@@ -912,7 +912,7 @@ static int stm32_dfsdm_adc_dma_start(struct iio_dev *indio_dev)
 	if (!adc->dma_chan)
 		return -EINVAL;
 
-	dev_dbg(&indio_dev->dev, "%s size=%d watermark=%d\n", __func__,
+	dev_dbg(&indio_dev->dev, "size=%d watermark=%d\n",
 		adc->buf_sz, adc->buf_sz / 2);
 
 	if (adc->nconv == 1 && !indio_dev->trig)
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Mugilraj Dhavachelvan

dropped __func__ while using dev_dbg() and pr_debug()

The commit message may be amended, from code perspective LGTM!

Reviewed-by Andy Shevchenko <[email protected]>
Quoted 50 lines
Signed-off-by Mugilraj Dhavachelvan <[email protected]>
---
 drivers/iio/adc/stm32-dfsdm-adc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/iio/adc/stm32-dfsdm-adc.c +5 -6
index 76a60d93fe23..95ec5f3c3126 100644
@@ -198,7 +198,7 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
        unsigned int p = fl->ford;      /* filter order (ford) */
        struct stm32_dfsdm_filter_osr *flo = &fl->flo[fast];
 
-       pr_debug("%s: Requested oversampling: %d\n",  __func__, oversamp);
+       pr_debug("Requested oversampling: %d\n", oversamp);
        /*
         * This function tries to compute filter oversampling and integrator
         * oversampling, base on oversampling ratio requested by user.

@@ -294,8 +294,8 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
                                }
                                flo->max = (s32)max;
 
-                               pr_debug("%s: fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
-                                        __func__, fast, flo->fosr, flo->iosr,
+                               pr_debug("fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
+                                        fast, flo->fosr, flo->iosr,
                                         flo->res, bits, flo->rshift,
                                         flo->lshift);
                        }

@@ -858,7 +858,7 @@ static void stm32_dfsdm_dma_buffer_done(void *data)
         * support in IIO.
         */
 
-       dev_dbg(&indio_dev->dev, "%s: pos = %d, available = %d\n", __func__,
+       dev_dbg(&indio_dev->dev, "pos = %d, available = %d\n",
                adc->bufi, available);
        old_pos = adc->bufi;
 

@@ -912,7 +912,7 @@ static int stm32_dfsdm_adc_dma_start(struct iio_dev *indio_dev)
        if (!adc->dma_chan)
                return -EINVAL;
 
-       dev_dbg(&indio_dev->dev, "%s size=%d watermark=%d\n", __func__,
+       dev_dbg(&indio_dev->dev, "size=%d watermark=%d\n",
                adc->buf_sz, adc->buf_sz / 2);
 
        if (adc->nconv == 1 && !indio_dev->trig)
--

2.25.1

Signature · 7 lines
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#2 lore raw
Quoted 7 lines · On Thu, 1 Apr 2021 21:05:58 +0300 Andy Shevchenko <[email protected]>…
Quoted 2 lines · Mugilraj Dhavachelvan

dropped __func__ while using dev_dbg() and pr_debug()

The commit message may be amended, from code perspective LGTM!

Reviewed-by Andy Shevchenko <[email protected]>

I added a note to the commit message to observe that the function name printing can be configured using dynamic debug.

Applied to the togreg branch of iio.git and pushed out as testing to let the autobuilder bots like 0-day check if they can find any problems that we've missed.

Thanks,

Jonathan

Quoted 53 lines
Quoted 51 lines
Signed-off-by Mugilraj Dhavachelvan <[email protected]>
---
 drivers/iio/adc/stm32-dfsdm-adc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/iio/adc/stm32-dfsdm-adc.c +5 -6
index 76a60d93fe23..95ec5f3c3126 100644
@@ -198,7 +198,7 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
        unsigned int p = fl->ford;      /* filter order (ford) */
        struct stm32_dfsdm_filter_osr *flo = &fl->flo[fast];
 
-       pr_debug("%s: Requested oversampling: %d\n",  __func__, oversamp);
+       pr_debug("Requested oversampling: %d\n", oversamp);
        /*
         * This function tries to compute filter oversampling and integrator
         * oversampling, base on oversampling ratio requested by user.

@@ -294,8 +294,8 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl,
                                }
                                flo->max = (s32)max;
 
-                               pr_debug("%s: fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
-                                        __func__, fast, flo->fosr, flo->iosr,
+                               pr_debug("fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n",
+                                        fast, flo->fosr, flo->iosr,
                                         flo->res, bits, flo->rshift,
                                         flo->lshift);
                        }

@@ -858,7 +858,7 @@ static void stm32_dfsdm_dma_buffer_done(void *data)
         * support in IIO.
         */
 
-       dev_dbg(&indio_dev->dev, "%s: pos = %d, available = %d\n", __func__,
+       dev_dbg(&indio_dev->dev, "pos = %d, available = %d\n",
                adc->bufi, available);
        old_pos = adc->bufi;
 

@@ -912,7 +912,7 @@ static int stm32_dfsdm_adc_dma_start(struct iio_dev *indio_dev)
        if (!adc->dma_chan)
                return -EINVAL;
 
-       dev_dbg(&indio_dev->dev, "%s size=%d watermark=%d\n", __func__,
+       dev_dbg(&indio_dev->dev, "size=%d watermark=%d\n",
                adc->buf_sz, adc->buf_sz / 2);
 
        if (adc->nconv == 1 && !indio_dev->trig)
--

2.25.1