Skip to contentSkip to conversation

media: Fix compilation error

PATCH In review Bixuan Cui 4 participants 5 messages Apr 2, 2021 – Apr 8, 2021

Subsystems (4)
lore
Share & tools
lore

Bixuan Cui

author
#0 lore raw

PATCH 1/1 media: Fix compilation error

Fix the error:

drivers/staging/media/tegra-video/vi.c:1180:4:
error: implicit declaration of function 'host1x_syncpt_free' [-Werror,-Wimplicit-function-declaration]

Fixes 3028a00c55bf ('gpu: host1x: Cleanup and refcounting for syncpoints')
---
 drivers/staging/media/tegra-video/vi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/tegra-video/vi.c +1 -1
index 7e0cb5529b49..df5ca3596470 100644
@@ -1177,7 +1177,7 @@ static int tegra_channel_host1x_syncpt_init(struct tegra_vi_channel *chan)
 		mw_sp = host1x_syncpt_request(&vi->client, flags);
 		if (!mw_sp) {
 			dev_err(vi->dev, "failed to request memory ack syncpoint\n");
-			host1x_syncpt_free(fs_sp);
+			host1x_syncpt_put(fs_sp);
 			ret = -ENOMEM;
 			goto free_syncpts;
 		}
Signature · 1 line
2.17.1
#1 lore raw
Quoted 4 lines · Bixuan Cui

Fix the error:

drivers/staging/media/tegra-video/vi.c:1180:4:
error: implicit declaration of function 'host1x_syncpt_free' [-Werror,-Wimplicit-function-declaration]

Against what tree is this being built? The mainline kernel doesn't have host1x_syncpt_put, only host1x_syncpt_free.

Also, the subject line is very vague, something like this is much more descriptive:

[PATCH] media: tegra-video: replace host1x_syncpt_free by host1x_syncpt_put

Regards,

Hans

Quoted 22 lines
Fixes 3028a00c55bf ('gpu: host1x: Cleanup and refcounting for syncpoints')
---
 drivers/staging/media/tegra-video/vi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/tegra-video/vi.c +1 -1
index 7e0cb5529b49..df5ca3596470 100644
@@ -1177,7 +1177,7 @@ static int tegra_channel_host1x_syncpt_init(struct tegra_vi_channel *chan)
 		mw_sp = host1x_syncpt_request(&vi->client, flags);
 		if (!mw_sp) {
 			dev_err(vi->dev, "failed to request memory ack syncpoint\n");
-			host1x_syncpt_free(fs_sp);
+			host1x_syncpt_put(fs_sp);
 			ret = -ENOMEM;
 			goto free_syncpts;
 		}
#2 lore raw
Quoted 8 lines · Hans Verkuil
Quoted 4 lines · Bixuan Cui

Fix the error:

drivers/staging/media/tegra-video/vi.c:1180:4:
error: implicit declaration of function 'host1x_syncpt_free' [-Werror,-Wimplicit-function-declaration]

Against what tree is this being built? The mainline kernel doesn't have host1x_syncpt_put, only host1x_syncpt_free.

This change was done only very recently, it's in linux-next and submitted for 5.13. I missed this one host1x_syncpt_free call in vi.c, but Thierry has already applied an equivalent patch on his end so the issue should be resolved.

Thanks,
Mikko

Quoted 32 lines

Also, the subject line is very vague, something like this is much more descriptive:

[PATCH] media: tegra-video: replace host1x_syncpt_free by host1x_syncpt_put

Regards,

Hans

Quoted 22 lines
Fixes 3028a00c55bf ('gpu: host1x: Cleanup and refcounting for syncpoints')
---
  drivers/staging/media/tegra-video/vi.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/tegra-video/vi.c +1 -1
index 7e0cb5529b49..df5ca3596470 100644
@@ -1177,7 +1177,7 @@ static int tegra_channel_host1x_syncpt_init(struct tegra_vi_channel *chan)
  		mw_sp = host1x_syncpt_request(&vi->client, flags);
  		if (!mw_sp) {
  			dev_err(vi->dev, "failed to request memory ack syncpoint\n");
-			host1x_syncpt_free(fs_sp);
+			host1x_syncpt_put(fs_sp);
  			ret = -ENOMEM;
  			goto free_syncpts;
  		}
#3 lore raw
Quoted 7 lines · Mikko Perttunen
Quoted 6 lines · Hans Verkuil
Quoted 4 lines · Bixuan Cui

Fix the error:

drivers/staging/media/tegra-video/vi.c:1180:4:
error: implicit declaration of function 'host1x_syncpt_free' [-Werror,-Wimplicit-function-declaration]

Quoted 7 lines
Quoted 2 lines

Against what tree is this being built? The mainline kernel doesn't have host1x_syncpt_put, only host1x_syncpt_free.

This change was done only very recently, it's in linux-next and submitted for 5.13. I missed this one host1x_syncpt_free call in vi.c, but Thierry has already applied an equivalent patch on his end so the issue should be resolved.

Indeed, this should be fixed as of next-20210406. This is going in through the DRM tree in order to keep the change atomic and bisectible.

Thierry

author
#4 lore raw
In reply to Mikko Perttunen
Quoted 1 line · Mikko Perttunen

This change was done only very recently, it's in linux-next and submitted for 5.13. I missed this one host1x_syncpt_free call in vi.c, but Thierry has already applied an equivalent patch on his end so the issue should be resolved.

Yes,this build error has been fixed in the next-20210407.

Thanks,
Bixuan Cui