Skip to contentSkip to conversation

staging: media/meson: remove redundant dev_err call

PATCH In review Muhammad Usama Anjum 2 participants 2 messages Apr 7, 2021 – Apr 26, 2021

Subsystems (5)
Media (V4L/DVB) Staging Kernel janitors Arm/Amlogic Meson SoC support +1 more subsystems
lore
Share & tools
lore

Muhammad Usama Anjum

author
#0 lore raw

PATCH 1/1 staging: media/meson: remove redundant dev_err call

devm_ioremap_resource() prints error message in itself. Remove the dev_err call to avoid redundant error message.

Signed-off-by Muhammad Usama Anjum <[email protected]>
---
 drivers/staging/media/meson/vdec/vdec.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/staging/media/meson/vdec/vdec.c +2 -6
index 5d4db7a5b4b5..e51d69c4729d 100644
@@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev)
 
 	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos");
 	core->dos_base = devm_ioremap_resource(dev, r);
-	if (IS_ERR(core->dos_base)) {
-		dev_err(dev, "Couldn't remap DOS memory\n");
+	if (IS_ERR(core->dos_base))
 		return PTR_ERR(core->dos_base);
-	}
 
 	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser");
 	core->esparser_base = devm_ioremap_resource(dev, r);
-	if (IS_ERR(core->esparser_base)) {
-		dev_err(dev, "Couldn't remap ESPARSER memory\n");
+	if (IS_ERR(core->esparser_base))
 		return PTR_ERR(core->esparser_base);
-	}
 
 	core->regmap_ao =
 		syscon_regmap_lookup_by_phandle(dev->of_node,
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 23 lines · Muhammad Usama Anjum

devm_ioremap_resource() prints error message in itself. Remove the dev_err call to avoid redundant error message.

Signed-off-by Muhammad Usama Anjum <[email protected]>
---
 drivers/staging/media/meson/vdec/vdec.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/staging/media/meson/vdec/vdec.c +1 -3
index 5d4db7a5b4b5..e51d69c4729d 100644
@@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev)
 
 	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos");
 	core->dos_base = devm_ioremap_resource(dev, r);
-	if (IS_ERR(core->dos_base)) {
-		dev_err(dev, "Couldn't remap DOS memory\n");
+	if (IS_ERR(core->dos_base))
 		return PTR_ERR(core->dos_base);
-	}

drivers/staging/media/meson/vdec/vdec.c static int vdec_probe(struct platform_device *pdev) · line 1020

Quoted 10 lines
drivers/staging/media/meson/vdec/vdec.c +1 -3
 	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser");
 	core->esparser_base = devm_ioremap_resource(dev, r);
-	if (IS_ERR(core->esparser_base)) {
-		dev_err(dev, "Couldn't remap ESPARSER memory\n");
+	if (IS_ERR(core->esparser_base))
 		return PTR_ERR(core->esparser_base);
-	}
 
 	core->regmap_ao =
 		syscon_regmap_lookup_by_phandle(dev->of_node,
Acked-by Neil Armstrong <[email protected]>