Skip to contentSkip to conversation

Fix coverity issues reported in DPDK-26381

PATCH Applied Wei Huang 6 participants 13 messages Apr 8, 2021 – May 17, 2021

lore
Share & tools
lore

Wei Huang

author
#0 lore raw

v2 cover Fix coverity issues reported in DPDK-26381

Below coverity issues are fixed in this patch set. 367480, 367482

Main changes from v1:
- change two patches to one patch because they have the same root cause

Wei Huang (1):
raw/ifpga/base: check size before assigning

 drivers/raw/ifpga/base/opae_intel_max10.c | 2 +-
 drivers/raw/ifpga/base/opae_intel_max10.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.29.2
author
#1 lore raw

PATCH v2 1/1 raw/ifpga/base: check size before assigning

In max10_staging_area_init(), variable "size" from fdt_get_reg() may be invalid, it should be checked before assigning to member variable "staging_area_size" of structure "intel_max10_device".

Coverity issue: 367480, 367482

Fixes 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")
Signed-off-by Wei Huang <[email protected]>

---
v2: check size before assigning to staging_area_size

---
 drivers/raw/ifpga/base/opae_intel_max10.c | 2 +-
 drivers/raw/ifpga/base/opae_intel_max10.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/raw/ifpga/base/opae_intel_max10.c +1 -1
index 443e248fb3..c223fafa03 100644
@@ -593,7 +593,7 @@ static int max10_staging_area_init(struct intel_max10_device *dev)
 			continue;
 
 		ret = fdt_get_reg(fdt_root, offset, 0, &start, &size);
-		if (!ret) {
+		if (!ret && (size <= MAX_STAGING_AREA_SIZE)) {
 			dev->staging_area_base = start;
 			dev->staging_area_size = size;
 		}
drivers/raw/ifpga/base/opae_intel_max10.h +1 -0
index 670683f017..e7142d6f0d 100644
@@ -182,6 +182,7 @@ struct opae_retimer_status {
 #define   SBUS_VERSION			GENMASK(31, 16)
 
 #define DFT_MAX_SIZE		0x7e0000
+#define MAX_STAGING_AREA_SIZE	0x3800000
 
 int max10_reg_read(struct intel_max10_device *dev,
 	unsigned int reg, unsigned int *val);
Signature · 1 line
2.29.2
#2 lore raw

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 34 lines · Wei Huang

In max10_staging_area_init(), variable "size" from fdt_get_reg() may be invalid, it should be checked before assigning to member variable "staging_area_size" of structure "intel_max10_device".

Coverity issue: 367480, 367482

Fixes 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")
Signed-off-by Wei Huang <[email protected]>

---
v2: check size before assigning to staging_area_size

---
  drivers/raw/ifpga/base/opae_intel_max10.c | 2 +-
  drivers/raw/ifpga/base/opae_intel_max10.h | 1 +
  2 files changed, 2 insertions(+), 1 deletion(-)
drivers/raw/ifpga/base/opae_intel_max10.c +1 -1
index 443e248fb3..c223fafa03 100644
@@ -593,7 +593,7 @@ static int max10_staging_area_init(struct intel_max10_device *dev)
  			continue;
 
  		ret = fdt_get_reg(fdt_root, offset, 0, &start, &size);
-		if (!ret) {
+		if (!ret && (size <= MAX_STAGING_AREA_SIZE)) {
  			dev->staging_area_base = start;
  			dev->staging_area_size = size;
  		}
drivers/raw/ifpga/base/opae_intel_max10.h +0 -0
index 670683f017..e7142d6f0d 100644

drivers/raw/ifpga/base/opae_intel_max10.h struct opae_retimer_status { · line 188

Quoted 7 lines
drivers/raw/ifpga/base/opae_intel_max10.h +1 -0
@@ -182,6 +182,7 @@ struct opae_retimer_status {
  #define   SBUS_VERSION			GENMASK(31, 16)
 
  #define DFT_MAX_SIZE		0x7e0000
+#define MAX_STAGING_AREA_SIZE	0x3800000
 
  int max10_reg_read(struct intel_max10_device *dev,
  	unsigned int reg, unsigned int *val);

Hi Aaron, David,

The data flow is complex for this coverity issues [1], at least I can't confirm that change fixes the issue.

Are you aware of any way to confirm this coverity issue before merging it?

[1]
https://scan4.coverity.com/reports.htm#v26325/p10075/fileInstanceId=100181086&defectInstanceId=14238477&mergedDefectId=367480

#3 lore raw

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 42 lines · Ferruh Yigit
Quoted 32 lines · Wei Huang

In max10_staging_area_init(), variable "size" from fdt_get_reg() may be invalid, it should be checked before assigning to member variable "staging_area_size" of structure "intel_max10_device".

Coverity issue: 367480, 367482

Fixes 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")
Signed-off-by Wei Huang <[email protected]>

---
v2: check size before assigning to staging_area_size

---
  drivers/raw/ifpga/base/opae_intel_max10.c | 2 +-
  drivers/raw/ifpga/base/opae_intel_max10.h | 1 +
  2 files changed, 2 insertions(+), 1 deletion(-)
drivers/raw/ifpga/base/opae_intel_max10.c +1 -1
index 443e248fb3..c223fafa03 100644
@@ -593,7 +593,7 @@ static int max10_staging_area_init(struct intel_max10_device *dev)
  			continue;
    		ret = fdt_get_reg(fdt_root, offset, 0, &start, &size);
-		if (!ret) {
+		if (!ret && (size <= MAX_STAGING_AREA_SIZE)) {
  			dev->staging_area_base = start;
  			dev->staging_area_size = size;
  		}
drivers/raw/ifpga/base/opae_intel_max10.h +0 -0
index 670683f017..e7142d6f0d 100644

drivers/raw/ifpga/base/opae_intel_max10.h struct opae_retimer_status { · line 187

Quoted 6 lines
drivers/raw/ifpga/base/opae_intel_max10.h +1 -0
@@ -182,6 +182,7 @@ struct opae_retimer_status {
  #define   SBUS_VERSION			GENMASK(31, 16)
    #define DFT_MAX_SIZE		0x7e0000
+#define MAX_STAGING_AREA_SIZE	0x3800000
    int max10_reg_read(struct intel_max10_device *dev,
  	unsigned int reg, unsigned int *val);

Hi Aaron, David,

Quoted 4 lines

The data flow is complex for this coverity issues [1], at least I can't confirm that change fixes the issue.

Are you aware of any way to confirm this coverity issue before merging it?

Not generically. :-/

We need someone that understands the data flow and the coverity splat to know that the fix is correct. Coverity even ratelimits how many outstanding submissions we can post, iirc, so we don't get to push patch sets (unless we pay? I don't recall if there's an option for that).

Quoted 2 lines

[1]
https://scan4.coverity.com/reports.htm#v26325/p10075/fileInstanceId=100181086&defectInstanceId=14238477&mergedDefectId=367480

#4 lore raw

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 64 lines

-----Original Message-----
From: Aaron Conole <[email protected]>
Sent: 2021年4月9日 22:56
To: Yigit, Ferruh <[email protected]>
Cc: David Marchand <[email protected]>; [email protected]; Zhang, Tianfei <[email protected]>; Huang, Wei <[email protected]>; Zhang, Qi Z <[email protected]>; Xu, Rosen <[email protected]>; [email protected]; Mcnamara, John <[email protected]>
Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 17 lines · Ferruh Yigit
Quoted 16 lines · Wei Huang

In max10_staging_area_init(), variable "size" from fdt_get_reg() may be invalid, it should be checked before assigning to member variable "staging_area_size" of structure "intel_max10_device".

Coverity issue: 367480, 367482

Fixes 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device

driver")

Signed-off-by Wei Huang <[email protected]>

---
v2: check size before assigning to staging_area_size

---
  drivers/raw/ifpga/base/opae_intel_max10.c | 2 +-
  drivers/raw/ifpga/base/opae_intel_max10.h | 1 +
  2 files changed, 2 insertions(+), 1 deletion(-)
Quoted 6 lines

drivers/raw/ifpga/base/opae_intel_max10.c static int max10_staging_area_init(struct

Quoted 6 lines
drivers/raw/ifpga/base/opae_intel_max10.c +0 -0
index 443e248fb3..c223fafa03 100644
@@ -593,7 +593,7 @@ static int max10_staging_area_init(struct

intel_max10_device *dev)

Quoted 25 lines
Quoted 13 lines
drivers/raw/ifpga/base/opae_intel_max10.c +1 -1
  			continue;
    		ret = fdt_get_reg(fdt_root, offset, 0, &start, &size);
-		if (!ret) {
+		if (!ret && (size <= MAX_STAGING_AREA_SIZE)) {
  			dev->staging_area_base = start;
  			dev->staging_area_size = size;
  		}
drivers/raw/ifpga/base/opae_intel_max10.h +0 -0
index 670683f017..e7142d6f0d 100644

drivers/raw/ifpga/base/opae_intel_max10.h struct opae_retimer_status { · line 187

Quoted 6 lines
drivers/raw/ifpga/base/opae_intel_max10.h +1 -0
@@ -182,6 +182,7 @@ struct opae_retimer_status {
  #define   SBUS_VERSION			GENMASK(31, 16)
    #define DFT_MAX_SIZE		0x7e0000
+#define MAX_STAGING_AREA_SIZE	0x3800000
    int max10_reg_read(struct intel_max10_device *dev,
  	unsigned int reg, unsigned int *val);

Hi Aaron, David,

The data flow is complex for this coverity issues [1], at least I can't confirm that change fixes the issue.

Quoted 8 lines
Quoted 1 line

Are you aware of any way to confirm this coverity issue before merging it?

Not generically. :-/

We need someone that understands the data flow and the coverity splat to know that the fix is correct. Coverity even ratelimits how many outstanding submissions we can post, iirc, so we don't get to push patch sets (unless we pay? I don't recall if there's an option for that).

This fix is looks good for me. The fdt_get_reg() function just read out the content of some items from DTS file, We call the libfdt library API to do this.
The Coverity just assume some attacker broken the DTS file or invoke the function with arbitrary values, it is not safety, So this patch add some checking after the function return.

Quoted 4 lines
Quoted 4 lines

[1]
https://scan4.coverity.com/reports.htm#v26325/p10075/fileInstanceId=10
0181086&defectInstanceId=14238477&mergedDefectId=367480

#5 lore raw

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 73 lines · Tianfei
Quoted 64 lines

-----Original Message-----
From: Aaron Conole <[email protected]>
Sent: 2021年4月9日 22:56
To: Yigit, Ferruh <[email protected]>
Cc: David Marchand <[email protected]>; [email protected]; Zhang, Tianfei <[email protected]>; Huang, Wei <[email protected]>; Zhang, Qi Z <[email protected]>; Xu, Rosen <[email protected]>; [email protected]; Mcnamara, John <[email protected]>
Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 17 lines · Ferruh Yigit
Quoted 16 lines · Wei Huang

In max10_staging_area_init(), variable "size" from fdt_get_reg() may be invalid, it should be checked before assigning to member variable "staging_area_size" of structure "intel_max10_device".

Coverity issue: 367480, 367482

Fixes 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device

driver")

Signed-off-by Wei Huang <[email protected]>

---
v2: check size before assigning to staging_area_size

---
   drivers/raw/ifpga/base/opae_intel_max10.c | 2 +-
   drivers/raw/ifpga/base/opae_intel_max10.h | 1 +
   2 files changed, 2 insertions(+), 1 deletion(-)
Quoted 6 lines

drivers/raw/ifpga/base/opae_intel_max10.c static int max10_staging_area_init(struct

Quoted 6 lines
drivers/raw/ifpga/base/opae_intel_max10.c +0 -0
index 443e248fb3..c223fafa03 100644
@@ -593,7 +593,7 @@ static int max10_staging_area_init(struct

intel_max10_device *dev)

Quoted 25 lines
Quoted 13 lines
drivers/raw/ifpga/base/opae_intel_max10.c +1 -1
   continue;
     ret = fdt_get_reg(fdt_root, offset, 0, &start, &size);
-if (!ret) {
+if (!ret && (size <= MAX_STAGING_AREA_SIZE)) {
   dev->staging_area_base = start;
   dev->staging_area_size = size;
   }
drivers/raw/ifpga/base/opae_intel_max10.h +0 -0
index 670683f017..e7142d6f0d 100644

drivers/raw/ifpga/base/opae_intel_max10.h struct opae_retimer_status { · line 187

Quoted 6 lines
drivers/raw/ifpga/base/opae_intel_max10.h +1 -0
@@ -182,6 +182,7 @@ struct opae_retimer_status {
   #define   SBUS_VERSIONGENMASK(31, 16)
     #define DFT_MAX_SIZE0x7e0000
+#define MAX_STAGING_AREA_SIZE0x3800000
     int max10_reg_read(struct intel_max10_device *dev,
   unsigned int reg, unsigned int *val);

Hi Aaron, David,

The data flow is complex for this coverity issues [1], at least I can't confirm that change fixes the issue.

Quoted 8 lines
Quoted 1 line

Are you aware of any way to confirm this coverity issue before merging it?

Not generically. :-/

We need someone that understands the data flow and the coverity splat to know that the fix is correct. Coverity even ratelimits how many outstanding submissions we can post, iirc, so we don't get to push patch sets (unless we pay? I don't recall if there's an option for that).

Quoted 5 lines

This fix is looks good for me. The fdt_get_reg() function just read out the content of some items from DTS file, We call the libfdt library API to do this.
The Coverity just assume some attacker broken the DTS file or invoke the function with arbitrary values, it is not safety, So this patch add some checking after the function return.

Hi Tianfei,

From the CI capacity perspective, it would be better to have a way to verify Coverity fixes before merging them.
For most of the Coverity fixes we can tell that patch is fixing issue by review, but for the non trivial cases like this, a way to verify patch, even it is manual etc.., would be nice, otherwise it turns out to try and see Coverity fixes. And as far as I remember we had in the past that a Coverity fix result two more new Coverity issues :)

Quoted 5 lines
Quoted 4 lines
Quoted 4 lines

[1]
https://scan4.coverity.com/reports.htm#v26325/p10075/fileInstanceId=10
0181086&defectInstanceId=14238477&mergedDefectId=367480

author
#6 lore raw

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Hi Ferruh,

We have no way to run Coverity scan manually, if you or someone else know how to do it, please let us know.

Thanks,
Wei

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, April 14, 2021 15:42
To: Zhang, Tianfei <[email protected]>; Aaron Conole <[email protected]>
Cc: David Marchand <[email protected]>; [email protected]; Huang, Wei <[email protected]>; Zhang, Qi Z <[email protected]>; Xu, Rosen <[email protected]>; [email protected]; Mcnamara, John <[email protected]>
Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 74 lines · Tianfei
Quoted 65 lines

-----Original Message-----
From: Aaron Conole <[email protected]>
Sent: 2021年4月9日 22:56
To: Yigit, Ferruh <[email protected]>
Cc: David Marchand <[email protected]>; [email protected]; Zhang, Tianfei <[email protected]>; Huang, Wei <[email protected]>; Zhang, Qi Z <[email protected]>; Xu, Rosen <[email protected]>; [email protected]; Mcnamara, John <[email protected]>
Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 17 lines · Ferruh Yigit
Quoted 16 lines · Wei Huang

In max10_staging_area_init(), variable "size" from fdt_get_reg() may be invalid, it should be checked before assigning to member variable "staging_area_size" of structure "intel_max10_device".

Coverity issue: 367480, 367482

Fixes 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device

driver")

Signed-off-by Wei Huang <[email protected]>

---
v2: check size before assigning to staging_area_size

---
   drivers/raw/ifpga/base/opae_intel_max10.c | 2 +-
   drivers/raw/ifpga/base/opae_intel_max10.h | 1 +
   2 files changed, 2 insertions(+), 1 deletion(-)
Quoted 6 lines

drivers/raw/ifpga/base/opae_intel_max10.c static int max10_staging_area_init(struct

Quoted 6 lines
drivers/raw/ifpga/base/opae_intel_max10.c +0 -0
index 443e248fb3..c223fafa03 100644
@@ -593,7 +593,7 @@ static int max10_staging_area_init(struct

intel_max10_device *dev)

Quoted 25 lines
Quoted 13 lines
drivers/raw/ifpga/base/opae_intel_max10.c +1 -0
   continue;
     ret = fdt_get_reg(fdt_root, offset, 0, &start, &size); -if 
 (!ret) {
+if (!ret && (size <= MAX_STAGING_AREA_SIZE)) {
   dev->staging_area_base = start;
   dev->staging_area_size = size;
   }
drivers/raw/ifpga/base/opae_intel_max10.h +0 -0
index 670683f017..e7142d6f0d 100644

drivers/raw/ifpga/base/opae_intel_max10.h struct opae_retimer_status { · line 187

Quoted 6 lines
drivers/raw/ifpga/base/opae_intel_max10.h +1 -0
@@ -182,6 +182,7 @@ struct opae_retimer_status {
   #define   SBUS_VERSIONGENMASK(31, 16)
     #define DFT_MAX_SIZE0x7e0000
+#define MAX_STAGING_AREA_SIZE0x3800000
     int max10_reg_read(struct intel_max10_device *dev,
   unsigned int reg, unsigned int *val);

Hi Aaron, David,

The data flow is complex for this coverity issues [1], at least I can't confirm that change fixes the issue.

Quoted 8 lines
Quoted 1 line

Are you aware of any way to confirm this coverity issue before merging it?

Not generically. :-/

We need someone that understands the data flow and the coverity splat to know that the fix is correct. Coverity even ratelimits how many outstanding submissions we can post, iirc, so we don't get to push patch sets (unless we pay? I don't recall if there's an option for that).

Quoted 5 lines

This fix is looks good for me. The fdt_get_reg() function just read
out the content of some items from DTS file, We call the libfdt library API to do this.
The Coverity just assume some attacker broken the DTS file or invoke
the function with arbitrary values, it is not safety, So this patch add some checking after the function return.

Hi Tianfei,

From the CI capacity perspective, it would be better to have a way to verify Coverity fixes before merging them.
For most of the Coverity fixes we can tell that patch is fixing issue by review, but for the non trivial cases like this, a way to verify patch, even it is manual etc.., would be nice, otherwise it turns out to try and see Coverity fixes. And as far as I remember we had in the past that a Coverity fix result two more new Coverity issues :)

Quoted 6 lines
Quoted 5 lines
Quoted 5 lines

[1]
https://scan4.coverity.com/reports.htm#v26325/p10075/fileInstanceId=
10 0181086&defectInstanceId=14238477&mergedDefectId=367480

#7 lore raw

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

In reply to Zhang, Tianfei
Quoted 73 lines · Tianfei
Quoted 64 lines

-----Original Message-----
From: Aaron Conole <[email protected]>
Sent: 2021年4月9日 22:56
To: Yigit, Ferruh <[email protected]>
Cc: David Marchand <[email protected]>; [email protected]; Zhang, Tianfei <[email protected]>; Huang, Wei <[email protected]>; Zhang, Qi Z <[email protected]>; Xu, Rosen <[email protected]>; [email protected]; Mcnamara, John <[email protected]>
Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 17 lines · Ferruh Yigit
Quoted 16 lines · Wei Huang

In max10_staging_area_init(), variable "size" from fdt_get_reg() may be invalid, it should be checked before assigning to member variable "staging_area_size" of structure "intel_max10_device".

Coverity issue: 367480, 367482

Fixes 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device

driver")

Signed-off-by Wei Huang <[email protected]>

---
v2: check size before assigning to staging_area_size

---
  drivers/raw/ifpga/base/opae_intel_max10.c | 2 +-
  drivers/raw/ifpga/base/opae_intel_max10.h | 1 +
  2 files changed, 2 insertions(+), 1 deletion(-)
Quoted 6 lines

drivers/raw/ifpga/base/opae_intel_max10.c static int max10_staging_area_init(struct

Quoted 6 lines
drivers/raw/ifpga/base/opae_intel_max10.c +0 -0
index 443e248fb3..c223fafa03 100644
@@ -593,7 +593,7 @@ static int max10_staging_area_init(struct

intel_max10_device *dev)

Quoted 25 lines
Quoted 13 lines
drivers/raw/ifpga/base/opae_intel_max10.c +1 -1
  continue;
    ret = fdt_get_reg(fdt_root, offset, 0, &start, &size);
-if (!ret) {
+if (!ret && (size <= MAX_STAGING_AREA_SIZE)) {
  dev->staging_area_base = start;
  dev->staging_area_size = size;
  }
drivers/raw/ifpga/base/opae_intel_max10.h +0 -0
index 670683f017..e7142d6f0d 100644

drivers/raw/ifpga/base/opae_intel_max10.h struct opae_retimer_status { · line 187

Quoted 6 lines
drivers/raw/ifpga/base/opae_intel_max10.h +1 -0
@@ -182,6 +182,7 @@ struct opae_retimer_status {
  #define   SBUS_VERSIONGENMASK(31, 16)
    #define DFT_MAX_SIZE0x7e0000
+#define MAX_STAGING_AREA_SIZE0x3800000
    int max10_reg_read(struct intel_max10_device *dev,
  unsigned int reg, unsigned int *val);

Hi Aaron, David,

The data flow is complex for this coverity issues [1], at least I can't confirm that change fixes the issue.

Quoted 8 lines
Quoted 1 line

Are you aware of any way to confirm this coverity issue before merging it?

Not generically. :-/

We need someone that understands the data flow and the coverity splat to know that the fix is correct. Coverity even ratelimits how many outstanding submissions we can post, iirc, so we don't get to push patch sets (unless we pay? I don't recall if there's an option for that).

Quoted 5 lines

This fix is looks good for me. The fdt_get_reg() function just read out the content of some items from DTS file, We call the libfdt library API to do this.
The Coverity just assume some attacker broken the DTS file or invoke the function with arbitrary values, it is not safety, So this patch add some checking after the function return.

Hi Tianfei, Wei, Rosen,

The defect is reported in Coverity, as concerned, can you please look at it?

Quoted 5 lines
Quoted 4 lines
Quoted 4 lines

[1]
https://scan4.coverity.com/reports.htm#v26325/p10075/fileInstanceId=10
0181086&defectInstanceId=14238477&mergedDefectId=367480

Applied
#8 lore raw

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

In reply to Wei Huang
Quoted 15 lines

-----Original Message-----
From: Huang, Wei <[email protected]>
Sent: Thursday, April 8, 2021 4:52 PM
To: [email protected]; Xu, Rosen <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; Zhang, Tianfei <[email protected]>; Yigit, Ferruh <[email protected]>; Huang, Wei <[email protected]>
Subject: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

In max10_staging_area_init(), variable "size" from fdt_get_reg() may be invalid, it should be checked before assigning to member variable "staging_area_size" of structure "intel_max10_device".

Quoted 5 lines

Coverity issue: 367480, 367482

Fixes 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")
Signed-off-by Wei Huang <[email protected]>

---

Applied to dpdk-next-net-intel.

Thanks
Qi

#9 lore raw

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 15 lines · Qi Z
Quoted 15 lines

-----Original Message-----
From: Huang, Wei <[email protected]>
Sent: Thursday, April 8, 2021 4:52 PM
To: [email protected]; Xu, Rosen <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; Zhang, Tianfei <[email protected]>; Yigit, Ferruh <[email protected]>; Huang, Wei <[email protected]>
Subject: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

In max10_staging_area_init(), variable "size" from fdt_get_reg() may be invalid, it should be checked before assigning to member variable "staging_area_size" of structure "intel_max10_device".

Quoted 8 lines
Quoted 5 lines

Coverity issue: 367480, 367482

Fixes 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")
Signed-off-by Wei Huang <[email protected]>

---

Applied to dpdk-next-net-intel.

This patch is missing the maintainer ack.

Rosen, Tianfei, can you please review the patch?

Acked-by
#10 lore raw

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 34 lines

-----Original Message-----
From: Yigit, Ferruh <[email protected]>
Sent: 2021年4月20日 6:36
To: Zhang, Qi Z <[email protected]>; Huang, Wei <[email protected]>; [email protected]; Xu, Rosen <[email protected]>
Cc: [email protected]; Zhang, Tianfei <[email protected]>
Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 11 lines · Qi Z
Quoted 11 lines

-----Original Message-----
From: Huang, Wei <[email protected]>
Sent: Thursday, April 8, 2021 4:52 PM
To: [email protected]; Xu, Rosen <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; Zhang, Tianfei <[email protected]>; Yigit, Ferruh <[email protected]>; Huang, Wei <[email protected]>
Subject: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 2 lines
Quoted 2 lines

In max10_staging_area_init(), variable "size" from fdt_get_reg() may be invalid, it should be checked before assigning to member variable

"staging_area_size"

Quoted 9 lines
Quoted 8 lines

of structure "intel_max10_device".

Coverity issue: 367480, 367482

Fixes 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device

driver")

Signed-off-by Wei Huang <[email protected]>

---

Quoted 6 lines
Quoted 2 lines

Applied to dpdk-next-net-intel.

This patch is missing the maintainer ack.

Rosen, Tianfei, can you please review the patch?

It looks good for me.

Acked-by Tianfei zhang <[email protected]>
#11 lore raw

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 37 lines · Tianfei
Quoted 37 lines

-----Original Message-----
From: Yigit, Ferruh <[email protected]>
Sent: 2021年4月20日 6:36
To: Zhang, Qi Z <[email protected]>; Huang, Wei <[email protected]>; [email protected]; Xu, Rosen <[email protected]>
Cc: [email protected]; Zhang, Tianfei <[email protected]>
Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 11 lines · Qi Z
Quoted 11 lines

-----Original Message-----
From: Huang, Wei <[email protected]>
Sent: Thursday, April 8, 2021 4:52 PM
To: [email protected]; Xu, Rosen <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; Zhang, Tianfei <[email protected]>; Yigit, Ferruh <[email protected]>; Huang, Wei <[email protected]>
Subject: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 2 lines
Quoted 2 lines

In max10_staging_area_init(), variable "size" from fdt_get_reg() may be invalid, it should be checked before assigning to member variable

"staging_area_size"

Quoted 11 lines
Quoted 8 lines

of structure "intel_max10_device".

Coverity issue: 367480, 367482

Fixes 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device

driver")

Signed-off-by Wei Huang <[email protected]>

---

Applied to dpdk-next-net-intel.

Quoted 8 lines
Quoted 3 lines

This patch is missing the maintainer ack.

Rosen, Tianfei, can you please review the patch?

It looks good for me.

Acked-by Tianfei zhang <[email protected]>

Thanks, added in next-net.

#12 lore raw

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Thanks all.

-----Original Message-----
From: Yigit, Ferruh <[email protected]>
Sent: Tuesday, April 20, 2021 9:01 AM
To: Zhang, Tianfei <[email protected]>; Zhang, Qi Z <[email protected]>; Huang, Wei <[email protected]>; [email protected]; Xu, Rosen <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 40 lines · Tianfei
Quoted 40 lines

-----Original Message-----
From: Yigit, Ferruh <[email protected]>
Sent: 2021年4月20日 6:36
To: Zhang, Qi Z <[email protected]>; Huang, Wei <[email protected]>; [email protected]; Xu, Rosen <[email protected]>
Cc: [email protected]; Zhang, Tianfei <[email protected]>
Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 12 lines · Qi Z
Quoted 12 lines

-----Original Message-----
From: Huang, Wei <[email protected]>
Sent: Thursday, April 8, 2021 4:52 PM
To: [email protected]; Xu, Rosen <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; Zhang, Tianfei <[email protected]>; Yigit, Ferruh <[email protected]>; Huang, Wei <[email protected]>
Subject: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Quoted 3 lines
Quoted 3 lines

In max10_staging_area_init(), variable "size" from fdt_get_reg() may be invalid, it should be checked before assigning to member variable

"staging_area_size"

Quoted 11 lines
Quoted 8 lines

of structure "intel_max10_device".

Coverity issue: 367480, 367482

Fixes 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device

driver")

Signed-off-by Wei Huang <[email protected]>

---

Applied to dpdk-next-net-intel.

Quoted 8 lines
Quoted 3 lines

This patch is missing the maintainer ack.

Rosen, Tianfei, can you please review the patch?

It looks good for me.

Acked-by Tianfei zhang <[email protected]>

Thanks, added in next-net.