Skip to contentSkip to conversation

net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

PATCH Superseded Dexuan Cui 6 participants 9 messages Apr 8, 2021

Subsystems (4)

v2 of 8 Superseded Latest is v8 →

lore
Share & tools
lore

Dexuan Cui

author maintainer
#0 lore raw

PATCH v2 1/1 net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

Add a VF driver for Microsoft Azure Network Adapter (MANA) that will be available in the future.

---
 MAINTAINERS                                   |    4 +-
 drivers/net/ethernet/Kconfig                  |    1 +
 drivers/net/ethernet/Makefile                 |    1 +
 drivers/net/ethernet/microsoft/Kconfig        |   30 +
 drivers/net/ethernet/microsoft/Makefile       |    5 +
 drivers/net/ethernet/microsoft/mana/Makefile  |    6 +
 drivers/net/ethernet/microsoft/mana/gdma.h    |  728 +++++++
 .../net/ethernet/microsoft/mana/gdma_main.c   | 1515 ++++++++++++++
 .../net/ethernet/microsoft/mana/hw_channel.c  |  859 ++++++++
 .../net/ethernet/microsoft/mana/hw_channel.h  |  186 ++
 drivers/net/ethernet/microsoft/mana/mana.h    |  531 +++++
 drivers/net/ethernet/microsoft/mana/mana_en.c | 1833 +++++++++++++++++
 .../ethernet/microsoft/mana/mana_ethtool.c    |  278 +++
 .../net/ethernet/microsoft/mana/shm_channel.c |  292 +++
 .../net/ethernet/microsoft/mana/shm_channel.h |   21 +
 15 files changed, 6289 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/ethernet/microsoft/Kconfig
 create mode 100644 drivers/net/ethernet/microsoft/Makefile
 create mode 100644 drivers/net/ethernet/microsoft/mana/Makefile
 create mode 100644 drivers/net/ethernet/microsoft/mana/gdma.h
 create mode 100644 drivers/net/ethernet/microsoft/mana/gdma_main.c
 create mode 100644 drivers/net/ethernet/microsoft/mana/hw_channel.c
 create mode 100644 drivers/net/ethernet/microsoft/mana/hw_channel.h
 create mode 100644 drivers/net/ethernet/microsoft/mana/mana.h
 create mode 100644 drivers/net/ethernet/microsoft/mana/mana_en.c
 create mode 100644 drivers/net/ethernet/microsoft/mana/mana_ethtool.c
 create mode 100644 drivers/net/ethernet/microsoft/mana/shm_channel.c
 create mode 100644 drivers/net/ethernet/microsoft/mana/shm_channel.h

Changes in v2:

Removed the module_param(num_queues,...). [Andrew Lunn]
Changed pr_err() to netdev_err() and dev_err(). [Andrew Lunn]
Used reverse X-mas tree style in all the functions. [Andrew Lunn]

Changed "= { 0 };" to "= {};" for struct variables. [Leon Romanovsky]

Addressed 3 build failures on i386, arc and powerpc by making the the driver dependent on X86_64 in Kconfig: so far, the driver is only validated on X86_64 (in the future, we may enable the driver for ARM64).

Also made some cosmetic changes.

Rebased the patch to the latest net-next.

BTW, the support of XDP and BQL haven't been implemented. They are on our TO-DO list.

MAINTAINERS +3 -1
index 217c7470bfa9..6ab1f9ac8c54 100644
@@ -8261,11 +8261,12 @@ S:	Maintained
 T:	git git://linuxtv.org/media_tree.git
 F:	drivers/media/i2c/hi556.c
 
-Hyper-V CORE AND DRIVERS
+Hyper-V/Azure CORE AND DRIVERS
 M:	"K. Y. Srinivasan" <[email protected]>
 M:	Haiyang Zhang <[email protected]>
 M:	Stephen Hemminger <[email protected]>
 M:	Wei Liu <[email protected]>
+M:	Dexuan Cui <[email protected]>
 L:	[email protected]
 S:	Supported
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git
@@ -8282,6 +8283,7 @@ F:	drivers/hid/hid-hyperv.c
 F:	drivers/hv/
 F:	drivers/input/serio/hyperv-keyboard.c
 F:	drivers/iommu/hyperv-iommu.c
+F:	drivers/net/ethernet/microsoft/
 F:	drivers/net/hyperv/
 F:	drivers/pci/controller/pci-hyperv-intf.c
 F:	drivers/pci/controller/pci-hyperv.c
drivers/net/ethernet/Kconfig +1 -0
index 4b85f2b74872..d46460c5b44d 100644
@@ -82,6 +82,7 @@ source "drivers/net/ethernet/huawei/Kconfig"
 source "drivers/net/ethernet/i825xx/Kconfig"
 source "drivers/net/ethernet/ibm/Kconfig"
 source "drivers/net/ethernet/intel/Kconfig"
+source "drivers/net/ethernet/microsoft/Kconfig"
 source "drivers/net/ethernet/xscale/Kconfig"
 
 config JME
drivers/net/ethernet/Makefile +1 -0
index 9394493e8187..cb3f9084a21b 100644
@@ -45,6 +45,7 @@ obj-$(CONFIG_NET_VENDOR_HUAWEI) += huawei/
 obj-$(CONFIG_NET_VENDOR_IBM) += ibm/
 obj-$(CONFIG_NET_VENDOR_INTEL) += intel/
 obj-$(CONFIG_NET_VENDOR_I825XX) += i825xx/
+obj-$(CONFIG_NET_VENDOR_MICROSOFT) += microsoft/
 obj-$(CONFIG_NET_VENDOR_XSCALE) += xscale/
 obj-$(CONFIG_JME) += jme.o
 obj-$(CONFIG_KORINA) += korina.o
drivers/net/ethernet/microsoft/Kconfig new file +30 -0
new file mode 100644
index 000000000000..12ef6b581566
@@ -0,0 +1,30 @@
+#
+# Microsoft Azure network device configuration
+#
+
+config NET_VENDOR_MICROSOFT
+	bool "Microsoft Azure Network Device"
+	default y
+	help
+	  If you have a network (Ethernet) device belonging to this class, say Y.
+
+	  Note that the answer to this question doesn't directly affect the
+	  kernel: saying N will just cause the configurator to skip the
+	  question about Microsoft Azure network device. If you say Y, you
+	  will be asked for your specific device in the following question.
+
+if NET_VENDOR_MICROSOFT
+
+config MICROSOFT_MANA
+	tristate "Microsoft Azure Network Adapter (MANA) support"
+	default m
+	depends on PCI_MSI && X86_64
+	select PCI_HYPERV
+	help
+	  This driver supports Microsoft Azure Network Adapter (MANA).
+	  So far, the driver is only validated on X86_64.
+
+	  To compile this driver as a module, choose M here.
+	  The module will be called mana.
+
+endif #NET_VENDOR_MICROSOFT
drivers/net/ethernet/microsoft/Makefile new file +5 -0
new file mode 100644
index 000000000000..d2ddc218135f
@@ -0,0 +1,5 @@
+#
+# Makefile for the Microsoft Azure network device driver.
+#
+
+obj-$(CONFIG_MICROSOFT_MANA) += mana/
drivers/net/ethernet/microsoft/mana/Makefile new file +6 -0
new file mode 100644
index 000000000000..0edd5bb685f3
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
+#
+# Makefile for the Microsoft Azure Network Adapter driver
+
+obj-$(CONFIG_MICROSOFT_MANA) += mana.o
+mana-objs := gdma_main.o shm_channel.o hw_channel.o mana_en.o mana_ethtool.o
drivers/net/ethernet/microsoft/mana/gdma.h new file +728 -0

728 lines not on this page · raw message

drivers/net/ethernet/microsoft/mana/gdma_main.c new file +1515 -0

1,515 lines not on this page · raw message

drivers/net/ethernet/microsoft/mana/hw_channel.c new file +859 -0

682 lines not on this page · raw message

drivers/net/ethernet/microsoft/mana/hw_channel.h new file +186 -0

186 lines not on this page · raw message

drivers/net/ethernet/microsoft/mana/mana.h new file +531 -0

531 lines not on this page · raw message

drivers/net/ethernet/microsoft/mana/mana_en.c new file +1833 -0

1,833 lines not on this page · raw message

drivers/net/ethernet/microsoft/mana/mana_ethtool.c new file +278 -0

278 lines not on this page · raw message

drivers/net/ethernet/microsoft/mana/shm_channel.c new file +292 -0

292 lines not on this page · raw message

drivers/net/ethernet/microsoft/mana/shm_channel.h new file +21 -0
new file mode 100644
index 000000000000..aa55837239d7

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.20.1

Part of the diff is not shown here. View the raw message.

#1 lore raw
I love your patch! Yet something to improve:

Hi Dexuan,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Dexuan-Cui/net-mana-Add-a-driver-for-Microsoft-Azure-Network-Adapter-MANA/20210408-171836
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3cd52c1e32fe7dfee09815ced702db9ee9f84ec9
config: x86_64-randconfig-a014-20210408 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 56ea2e2fdd691136d5e6631fa0e447173694b82c)

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/14f90d1ae32a997faf622ab0612fc69eb13edc82
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dexuan-Cui/net-mana-Add-a-driver-for-Microsoft-Azure-Network-Adapter-MANA/20210408-171836 git checkout 14f90d1ae32a997faf622ab0612fc69eb13edc82
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate

All error/warnings (new ones prefixed by >>):

>> drivers/pci/controller/pci-hyperv.c:1220:2: error: implicit declaration of function 'hv_set_msi_entry_from_desc' [-Werror,-Wimplicit-function-declaration]
           hv_set_msi_entry_from_desc(&params->int_entry.msi_entry, msi_desc);
           ^
>> drivers/pci/controller/pci-hyperv.c:1252:13: error: implicit declaration of function 'cpumask_to_vpset' [-Werror,-Wimplicit-function-declaration]
                   nr_bank = cpumask_to_vpset(&params->int_target.vp_set, tmp);
                             ^
   drivers/pci/controller/pci-hyperv.c:1252:13: note: did you mean 'cpumask_subset'?
   include/linux/cpumask.h:538:19: note: 'cpumask_subset' declared here
   static inline int cpumask_subset(const struct cpumask *src1p,
                     ^
>> drivers/pci/controller/pci-hyperv.c:1269:14: error: implicit declaration of function 'hv_cpu_number_to_vp_number' [-Werror,-Wimplicit-function-declaration]
                                   (1ULL << hv_cpu_number_to_vp_number(cpu));
                                            ^
   drivers/pci/controller/pci-hyperv.c:1356:3: error: implicit declaration of function 'hv_cpu_number_to_vp_number' [-Werror,-Wimplicit-function-declaration]
                   hv_cpu_number_to_vp_number(cpu);
                   ^
   4 errors generated.
--
>> drivers/net/ethernet/microsoft/mana/gdma_main.c:363:12: warning: variable 'gc' is uninitialized when used here [-Wuninitialized]
                           dev_err(gc->dev, "EQ %d: overflow detected\n", eq->id);
                                   ^~
   include/linux/dev_printk.h:112:11: note: expanded from macro 'dev_err'
           _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
                    ^~~
   drivers/net/ethernet/microsoft/mana/gdma_main.c:340:25: note: initialize the variable 'gc' to silence this warning
           struct gdma_context *gc;
                                  ^
                                   = NULL
>> drivers/net/ethernet/microsoft/mana/gdma_main.c:1405:6: warning: variable 'gc' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
           if (err)
               ^~~
   drivers/net/ethernet/microsoft/mana/gdma_main.c:1469:10: note: uninitialized use occurs here
           dev_err(gc->dev, "gdma probe failed: err = %d\n", err);
                   ^~
   include/linux/dev_printk.h:112:11: note: expanded from macro 'dev_err'
           _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
                    ^~~
   drivers/net/ethernet/microsoft/mana/gdma_main.c:1405:2: note: remove the 'if' if its condition is always false
           if (err)
           ^~~~~~~~
   drivers/net/ethernet/microsoft/mana/gdma_main.c:1401:6: warning: variable 'gc' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
           if (err)
               ^~~
   drivers/net/ethernet/microsoft/mana/gdma_main.c:1469:10: note: uninitialized use occurs here
           dev_err(gc->dev, "gdma probe failed: err = %d\n", err);
                   ^~
   include/linux/dev_printk.h:112:11: note: expanded from macro 'dev_err'
           _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
                    ^~~
   drivers/net/ethernet/microsoft/mana/gdma_main.c:1401:2: note: remove the 'if' if its condition is always false
           if (err)
           ^~~~~~~~
   drivers/net/ethernet/microsoft/mana/gdma_main.c:1389:25: note: initialize the variable 'gc' to silence this warning
           struct gdma_context *gc;
                                  ^
                                   = NULL
   3 warnings generated.
--
>> drivers/net/ethernet/microsoft/mana/hw_channel.c:60:6: warning: variable 'ctx' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
           if (!test_bit(resp_msg->response.hwc_msg_id,
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/microsoft/mana/hw_channel.c:77:2: note: uninitialized use occurs here
           ctx->error = err;
           ^~~
   drivers/net/ethernet/microsoft/mana/hw_channel.c:60:2: note: remove the 'if' if its condition is always false
           if (!test_bit(resp_msg->response.hwc_msg_id,
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/microsoft/mana/hw_channel.c:57:28: note: initialize the variable 'ctx' to silence this warning
           struct hwc_caller_ctx *ctx;
                                     ^
                                      = NULL
   1 warning generated.
--
>> drivers/net/ethernet/microsoft/mana/mana_en.c:622:25: warning: address of array 'ac->hashkey' will always evaluate to 'true' [-Wpointer-bool-conversion]
           if (update_key && !ac->hashkey)
                             ~~~~~^~~~~~~
>> drivers/net/ethernet/microsoft/mana/mana_en.c:625:25: warning: address of array 'ac->rxobj_table' will always evaluate to 'true' [-Wpointer-bool-conversion]
           if (update_tab && !ac->rxobj_table)
                             ~~~~~^~~~~~~~~~~

2 warnings generated.

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for PCI_HYPERV
Depends on PCI && X86_64 && HYPERV && PCI_MSI && PCI_MSI_IRQ_DOMAIN && SYSFS Selected by
- MICROSOFT_MANA && NETDEVICES && ETHERNET && NET_VENDOR_MICROSOFT && PCI_MSI && X86_64

vim +/hv_set_msi_entry_from_desc +1220 drivers/pci/controller/pci-hyperv.c

4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1183  
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1184  /**
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1185   * hv_irq_unmask() - "Unmask" the IRQ by setting its current
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1186   * affinity.
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1187   * @data:	Describes the IRQ
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1188   *
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1189   * Build new a destination for the MSI and make a hypercall to
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1190   * update the Interrupt Redirection Table. "Device Logical ID"
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1191   * is built out of this PCI bus's instance GUID and the function
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1192   * number of the device.
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1193   */
542ccf4551fa01 drivers/pci/host/pci-hyperv.c       Tobias Klauser   2016-10-31  1194  static void hv_irq_unmask(struct irq_data *data)
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1195  {
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1196  	struct msi_desc *msi_desc = irq_data_get_msi_desc(data);
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1197  	struct irq_cfg *cfg = irqd_cfg(data);
61bfd920abbf2c drivers/pci/controller/pci-hyperv.c Boqun Feng       2020-02-10  1198  	struct hv_retarget_device_interrupt *params;
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1199  	struct hv_pcibus_device *hbus;
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1200  	struct cpumask *dest;
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1201  	cpumask_var_t tmp;
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1202  	struct pci_bus *pbus;
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1203  	struct pci_dev *pdev;
0de8ce3ee8e38c drivers/pci/host/pci-hyperv.c       Long Li          2016-11-08  1204  	unsigned long flags;
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1205  	u32 var_size = 0;
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1206  	int cpu, nr_bank;
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1207  	u64 res;
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1208  
79aa801e899417 drivers/pci/host/pci-hyperv.c       Dexuan Cui       2017-11-01  1209  	dest = irq_data_get_effective_affinity_mask(data);
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1210  	pdev = msi_desc_to_pci_dev(msi_desc);
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1211  	pbus = pdev->bus;
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1212  	hbus = container_of(pbus->sysdata, struct hv_pcibus_device, sysdata);
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1213  
0de8ce3ee8e38c drivers/pci/host/pci-hyperv.c       Long Li          2016-11-08  1214  	spin_lock_irqsave(&hbus->retarget_msi_interrupt_lock, flags);
0de8ce3ee8e38c drivers/pci/host/pci-hyperv.c       Long Li          2016-11-08  1215  
0de8ce3ee8e38c drivers/pci/host/pci-hyperv.c       Long Li          2016-11-08  1216  	params = &hbus->retarget_msi_interrupt_params;
0de8ce3ee8e38c drivers/pci/host/pci-hyperv.c       Long Li          2016-11-08  1217  	memset(params, 0, sizeof(*params));
0de8ce3ee8e38c drivers/pci/host/pci-hyperv.c       Long Li          2016-11-08  1218  	params->partition_id = HV_PARTITION_ID_SELF;
b59fb7b60d47b2 drivers/pci/controller/pci-hyperv.c Wei Liu          2021-02-03  1219  	params->int_entry.source = HV_INTERRUPT_SOURCE_MSI;
1cf106d93245f4 drivers/pci/controller/pci-hyperv.c Boqun Feng       2020-02-10 @1220  	hv_set_msi_entry_from_desc(&params->int_entry.msi_entry, msi_desc);
0de8ce3ee8e38c drivers/pci/host/pci-hyperv.c       Long Li          2016-11-08  1221  	params->device_id = (hbus->hdev->dev_instance.b[5] << 24) |
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1222  			   (hbus->hdev->dev_instance.b[4] << 16) |
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1223  			   (hbus->hdev->dev_instance.b[7] << 8) |
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1224  			   (hbus->hdev->dev_instance.b[6] & 0xf8) |
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1225  			   PCI_FUNC(pdev->devfn);
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1226  	params->int_target.vector = cfg->vector;
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1227  
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1228  	/*
721612994f53ed drivers/pci/controller/pci-hyperv.c Thomas Gleixner  2020-10-24  1229  	 * Honoring apic->delivery_mode set to APIC_DELIVERY_MODE_FIXED by
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1230  	 * setting the HV_DEVICE_INTERRUPT_TARGET_MULTICAST flag results in a
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1231  	 * spurious interrupt storm. Not doing so does not seem to have a
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1232  	 * negative effect (yet?).
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1233  	 */
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1234  
14ef39fddd2367 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2019-11-24  1235  	if (hbus->protocol_version >= PCI_PROTOCOL_VERSION_1_2) {
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1236  		/*
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1237  		 * PCI_PROTOCOL_VERSION_1_2 supports the VP_SET version of the
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1238  		 * HVCALL_RETARGET_INTERRUPT hypercall, which also coincides
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1239  		 * with >64 VP support.
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1240  		 * ms_hyperv.hints & HV_X64_EX_PROCESSOR_MASKS_RECOMMENDED
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1241  		 * is not sufficient for this hypercall.
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1242  		 */
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1243  		params->int_target.flags |=
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1244  			HV_DEVICE_INTERRUPT_TARGET_PROCESSOR_SET;
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1245  
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1246  		if (!alloc_cpumask_var(&tmp, GFP_ATOMIC)) {
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1247  			res = 1;
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1248  			goto exit_unlock;
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1249  		}
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1250  
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1251  		cpumask_and(tmp, dest, cpu_online_mask);
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01 @1252  		nr_bank = cpumask_to_vpset(&params->int_target.vp_set, tmp);
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1253  		free_cpumask_var(tmp);
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1254  
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1255  		if (nr_bank <= 0) {
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1256  			res = 1;
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1257  			goto exit_unlock;
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1258  		}
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1259  
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1260  		/*
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1261  		 * var-sized hypercall, var-size starts after vp_mask (thus
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1262  		 * vp_set.format does not count, but vp_set.valid_bank_mask
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1263  		 * does).
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1264  		 */
c8ccf7599ddac5 drivers/pci/controller/pci-hyperv.c Maya Nakamura    2019-03-01  1265  		var_size = 1 + nr_bank;
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1266  	} else {
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1267  		for_each_cpu_and(cpu, dest, cpu_online_mask) {
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1268  			params->int_target.vp_mask |=
7415aea6072bab drivers/pci/host/pci-hyperv.c       Vitaly Kuznetsov 2017-08-02 @1269  				(1ULL << hv_cpu_number_to_vp_number(cpu));
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1270  		}
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1271  	}
0de8ce3ee8e38c drivers/pci/host/pci-hyperv.c       Long Li          2016-11-08  1272  
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1273  	res = hv_do_hypercall(HVCALL_RETARGET_INTERRUPT | (var_size << 17),
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1274  			      params, NULL);
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1275  
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1276  exit_unlock:
0de8ce3ee8e38c drivers/pci/host/pci-hyperv.c       Long Li          2016-11-08  1277  	spin_unlock_irqrestore(&hbus->retarget_msi_interrupt_lock, flags);
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1278  
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1279  	/*
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1280  	 * During hibernation, when a CPU is offlined, the kernel tries
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1281  	 * to move the interrupt to the remaining CPUs that haven't
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1282  	 * been offlined yet. In this case, the below hv_do_hypercall()
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1283  	 * always fails since the vmbus channel has been closed:
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1284  	 * refer to cpu_disable_common() -> fixup_irqs() ->
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1285  	 * irq_migrate_all_off_this_cpu() -> migrate_one_irq().
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1286  	 *
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1287  	 * Suppress the error message for hibernation because the failure
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1288  	 * during hibernation does not matter (at this time all the devices
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1289  	 * have been frozen). Note: the correct affinity info is still updated
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1290  	 * into the irqdata data structure in migrate_one_irq() ->
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1291  	 * irq_do_set_affinity() -> hv_set_affinity(), so later when the VM
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1292  	 * resumes, hv_pci_restore_msi_state() is able to correctly restore
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1293  	 * the interrupt with the correct affinity.
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1294  	 */
915cff7f38c5e4 drivers/pci/controller/pci-hyperv.c Dexuan Cui       2020-10-02  1295  	if (res && hbus->state != hv_pcibus_removing)
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1296  		dev_err(&hbus->hdev->device,
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1297  			"%s() failed: %#llx", __func__, res);
7dcf90e9e03243 drivers/pci/host/pci-hyperv.c       Jork Loeser      2017-05-24  1298  
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1299  	pci_msi_unmask_irq(data);
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1300  }
4daace0d8ce851 drivers/pci/host/pci-hyperv.c       Jake Oshins      2016-02-16  1301  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#2 lore raw
In reply to Dexuan Cui

drivers/net/ethernet/microsoft/Kconfig line 6

Quoted 12 lines · Dexuan Cui
drivers/net/ethernet/microsoft/Kconfig new file +6 -0
new file mode 100644
index 000000000000..12ef6b581566
@@ -0,0 +1,30 @@
+#
+# Microsoft Azure network device configuration
+#
+
+config NET_VENDOR_MICROSOFT
+	bool "Microsoft Azure Network Device"

Seems to me that should be generalized, more like:

bool "Microsoft Network Devices"

drivers/net/ethernet/microsoft/Kconfig line 13

Quoted 7 lines
drivers/net/ethernet/microsoft/Kconfig new file +7 -0
+	default y
+	help
+	  If you have a network (Ethernet) device belonging to this class, say Y.
+
+	  Note that the answer to this question doesn't directly affect the
+	  kernel: saying N will just cause the configurator to skip the
+	  question about Microsoft Azure network device. If you say Y, you

about Microsoft networking devices.

drivers/net/ethernet/microsoft/Kconfig line 20

Quoted 7 lines
drivers/net/ethernet/microsoft/Kconfig new file +7 -0
+	  will be asked for your specific device in the following question.
+
+if NET_VENDOR_MICROSOFT
+
+config MICROSOFT_MANA
+	tristate "Microsoft Azure Network Adapter (MANA) support"
+	default m

Please drop the default m. We don't randomly add drivers to be built.

Or leave this as is and change NET_VENDOR_MICROSOFT to be default n.

drivers/net/ethernet/microsoft/Kconfig line 25

Quoted 5 lines
drivers/net/ethernet/microsoft/Kconfig new file +5 -0
+	depends on PCI_MSI && X86_64
+	select PCI_HYPERV
+	help
+	  This driver supports Microsoft Azure Network Adapter (MANA).
+	  So far, the driver is only validated on X86_64.

validated how?

drivers/net/ethernet/microsoft/Kconfig line 30

Quoted 5 lines
drivers/net/ethernet/microsoft/Kconfig new file +5 -0
+
+	  To compile this driver as a module, choose M here.
+	  The module will be called mana.
+
+endif #NET_VENDOR_MICROSOFT

thanks.

Signature · 1 line
~Randy
maintainer
#3 lore raw
Quoted 32 lines

-----Original Message-----
From: Randy Dunlap <[email protected]>
Sent: Thursday, April 8, 2021 12:23 PM
To: Dexuan Cui <[email protected]>; [email protected]; [email protected]; KY Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Stephen Hemminger <[email protected]>; [email protected]; Wei Liu <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; [email protected]
Subject: Re: [PATCH v2 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

Review

Quoted 1 line · Dexuan Cui
(quoted diff) +0 -0

b/drivers/net/ethernet/microsoft/Kconfig

drivers/net/ethernet/microsoft/Kconfig line 6

Quoted 11 lines

new file mode 100644
index 000000000000..12ef6b581566

drivers/net/ethernet/microsoft/Kconfig new file +6 -0
@@ -0,0 +1,30 @@
+#
+# Microsoft Azure network device configuration
+#
+
+config NET_VENDOR_MICROSOFT
+	bool "Microsoft Azure Network Device"

Seems to me that should be generalized, more like:

Quoted 1 line

bool "Microsoft Network Devices"

This device is planned for Azure cloud at this time. We will update the wording if things change.

Quoted 11 lines

drivers/net/ethernet/microsoft/Kconfig line 13

Quoted 9 lines
drivers/net/ethernet/microsoft/Kconfig new file +7 -0
+	default y
+	help
+	  If you have a network (Ethernet) device belonging to this class, say Y.
+
+	  Note that the answer to this question doesn't directly affect the
+	  kernel: saying N will just cause the configurator to skip the
+	  question about Microsoft Azure network device. If you say Y, you

about Microsoft networking devices.

(ditto)

Quoted 10 lines

drivers/net/ethernet/microsoft/Kconfig line 20

Quoted 8 lines
drivers/net/ethernet/microsoft/Kconfig new file +7 -0
+	  will be asked for your specific device in the following question.
+
+if NET_VENDOR_MICROSOFT
+
+config MICROSOFT_MANA
+	tristate "Microsoft Azure Network Adapter (MANA) support"
+	default m

Please drop the default m. We don't randomly add drivers to be built.

We will.

Quoted 11 lines

Or leave this as is and change NET_VENDOR_MICROSOFT to be default n.

drivers/net/ethernet/microsoft/Kconfig line 25

Quoted 5 lines
drivers/net/ethernet/microsoft/Kconfig new file +5 -0
+	depends on PCI_MSI && X86_64
+	select PCI_HYPERV
+	help
+	  This driver supports Microsoft Azure Network Adapter (MANA).
+	  So far, the driver is only validated on X86_64.

validated how?

On our pre-released HW.

Thanks,
- Haiyang

#4 lore raw
Quoted 16 lines
Quoted 16 lines

Review

Quoted 1 line
(quoted diff) +0 -0

b/drivers/net/ethernet/microsoft/Kconfig

drivers/net/ethernet/microsoft/Kconfig line 6

Quoted 11 lines

new file mode 100644
index 000000000000..12ef6b581566

drivers/net/ethernet/microsoft/Kconfig new file +6 -0
@@ -0,0 +1,30 @@
+#
+# Microsoft Azure network device configuration
+#
+
+config NET_VENDOR_MICROSOFT
+	bool "Microsoft Azure Network Device"

Seems to me that should be generalized, more like:

Quoted 3 lines
Quoted 1 line

bool "Microsoft Network Devices"

This device is planned for Azure cloud at this time. We will update the wording if things change.

This section is about the Vendor. Broadcom, Marvell, natsemi, toshiba, etc. Microsoft is the Vendor here and all Microsoft Ethernet drivers belong here. It does not matter what platform they are for.

Andrew

maintainer
#5 lore raw
Quoted 32 lines

-----Original Message-----
From: Andrew Lunn <[email protected]>
Sent: Thursday, April 8, 2021 12:45 PM
To: Haiyang Zhang <[email protected]>
Cc: Randy Dunlap <[email protected]>; Dexuan Cui <[email protected]>; [email protected]; [email protected]; KY Srinivasan <[email protected]>; Stephen Hemminger <[email protected]>; [email protected]; Wei Liu <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]
Subject: Re: [PATCH v2 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

Quoted 16 lines
Quoted 16 lines

Review

Quoted 1 line
(quoted diff) +0 -0

b/drivers/net/ethernet/microsoft/Kconfig

drivers/net/ethernet/microsoft/Kconfig line 6

Quoted 11 lines

new file mode 100644
index 000000000000..12ef6b581566

drivers/net/ethernet/microsoft/Kconfig new file +6 -0
@@ -0,0 +1,30 @@
+#
+# Microsoft Azure network device configuration
+#
+
+config NET_VENDOR_MICROSOFT
+	bool "Microsoft Azure Network Device"

Seems to me that should be generalized, more like:

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

bool "Microsoft Network Devices"

This device is planned for Azure cloud at this time. We will update the wording if things change.

This section is about the Vendor. Broadcom, Marvell, natsemi, toshiba, etc. Microsoft is the Vendor here and all Microsoft Ethernet drivers belong here. It does not matter what platform they are for.

Thanks. We will update the wording.

- Haiyang

#6 lore raw
In reply to Randy Dunlap
Quoted 16 lines · On Thu, 8 Apr 2021 09:22:57 -0700 Randy Dunlap <[email protected]> wrote:

drivers/net/ethernet/microsoft/Kconfig line 6

Quoted 12 lines · Dexuan Cui
drivers/net/ethernet/microsoft/Kconfig new file +6 -0
new file mode 100644
index 000000000000..12ef6b581566
@@ -0,0 +1,30 @@
+#
+# Microsoft Azure network device configuration
+#
+
+config NET_VENDOR_MICROSOFT
+	bool "Microsoft Azure Network Device"  

Seems to me that should be generalized, more like:

Quoted 1 line

bool "Microsoft Network Devices"

Yes, that is what it should be at this level.

Quoted 3 lines

drivers/net/ethernet/microsoft/Kconfig line 7

Quoted 3 lines
drivers/net/ethernet/microsoft/Kconfig new file +1 -0
+	default y

This follows the existing policy for network vendor level

Quoted 9 lines

drivers/net/ethernet/microsoft/Kconfig line 13

Quoted 6 lines
drivers/net/ethernet/microsoft/Kconfig new file +6 -0
+	help
+	  If you have a network (Ethernet) device belonging to this class, say Y.
+
+	  Note that the answer to this question doesn't directly affect the
+	  kernel: saying N will just cause the configurator to skip the
+	  question about Microsoft Azure network device. If you say Y, you  

about Microsoft networking devices.

Quoted 9 lines

drivers/net/ethernet/microsoft/Kconfig line 20

Quoted 7 lines
drivers/net/ethernet/microsoft/Kconfig new file +7 -0
+	  will be asked for your specific device in the following question.
+
+if NET_VENDOR_MICROSOFT
+
+config MICROSOFT_MANA
+	tristate "Microsoft Azure Network Adapter (MANA) support"
+	default m  

Please drop the default m. We don't randomly add drivers to be built.

Yes, it should be no (or no default which is the default for default)

Quoted 10 lines

Or leave this as is and change NET_VENDOR_MICROSOFT to be default n.

drivers/net/ethernet/microsoft/Kconfig line 25

Quoted 5 lines
drivers/net/ethernet/microsoft/Kconfig new file +5 -0
+	depends on PCI_MSI && X86_64
+	select PCI_HYPERV
+	help
+	  This driver supports Microsoft Azure Network Adapter (MANA).
+	  So far, the driver is only validated on X86_64.  

validated how?

Maybe change validated to supported?

maintainer
#7 lore raw
Quoted 77 lines

-----Original Message-----
From: Stephen Hemminger <[email protected]>
Sent: Thursday, April 8, 2021 12:52 PM
To: Randy Dunlap <[email protected]>
Cc: Dexuan Cui <[email protected]>; [email protected]; [email protected]; KY Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Stephen Hemminger <[email protected]>; [email protected]; Wei Liu <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v2 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

Quoted 16 lines · On Thu, 8 Apr 2021 09:22:57 -0700 Randy Dunlap <[email protected]> wrote:

drivers/net/ethernet/microsoft/Kconfig line 5

Quoted 12 lines · Dexuan Cui
drivers/net/ethernet/microsoft/Kconfig new file +5 -0
new file mode 100644
index 000000000000..12ef6b581566
@@ -0,0 +1,30 @@
+#
+# Microsoft Azure network device configuration #
+
+config NET_VENDOR_MICROSOFT
+	bool "Microsoft Azure Network Device"

Seems to me that should be generalized, more like:

Quoted 1 line

bool "Microsoft Network Devices"

Yes, that is what it should be at this level.

Quoted 3 lines

drivers/net/ethernet/microsoft/Kconfig line 7

Quoted 3 lines
drivers/net/ethernet/microsoft/Kconfig new file +1 -0
+	default y

This follows the existing policy for network vendor level

Quoted 9 lines

drivers/net/ethernet/microsoft/Kconfig line 13

Quoted 6 lines
drivers/net/ethernet/microsoft/Kconfig new file +6 -0
+	help
+	  If you have a network (Ethernet) device belonging to this class, say Y.
+
+	  Note that the answer to this question doesn't directly affect the
+	  kernel: saying N will just cause the configurator to skip the
+	  question about Microsoft Azure network device. If you say Y, you

about Microsoft networking devices.

Quoted 9 lines

drivers/net/ethernet/microsoft/Kconfig line 20

Quoted 7 lines
drivers/net/ethernet/microsoft/Kconfig new file +7 -0
+	  will be asked for your specific device in the following question.
+
+if NET_VENDOR_MICROSOFT
+
+config MICROSOFT_MANA
+	tristate "Microsoft Azure Network Adapter (MANA) support"
+	default m

Please drop the default m. We don't randomly add drivers to be built.

Yes, it should be no (or no default which is the default for default)

Quoted 10 lines

Or leave this as is and change NET_VENDOR_MICROSOFT to be default n.

drivers/net/ethernet/microsoft/Kconfig line 25

Quoted 5 lines
drivers/net/ethernet/microsoft/Kconfig new file +5 -0
+	depends on PCI_MSI && X86_64
+	select PCI_HYPERV
+	help
+	  This driver supports Microsoft Azure Network Adapter (MANA).
+	  So far, the driver is only validated on X86_64.

validated how?

Quoted 1 line

Maybe change validated to supported?

Sounds better. We will change it to "supported".
Also other suggested changes.

Thanks,
- Haiyang

author maintainer
#8 lore raw
In reply to Stephen Hemminger
Quoted 2 lines

From: Stephen Hemminger <[email protected]>
Sent: Thursday, April 8, 2021 9:52 AM

Thanks all for your input! We'll make the below changes as suggested:

Microsoft Azure Network Device ==> Microsoft Network Devices Drop the default m
validated ==> supported

We'll also fix some warnings reported by "kernel test robot".

Will post v3 later today.

Thanks,
Dexuan

drivers/net/ethernet/microsoft/Kconfig +4 -5
index 12ef6b581566..e1ac0a5d808d 100644
@@ -3,26 +3,25 @@
 #
 
 config NET_VENDOR_MICROSOFT
-	bool "Microsoft Azure Network Device"
+	bool "Microsoft Network Devices"
 	default y
 	help
 	  If you have a network (Ethernet) device belonging to this class, say Y.
 
 	  Note that the answer to this question doesn't directly affect the
 	  kernel: saying N will just cause the configurator to skip the
-	  question about Microsoft Azure network device. If you say Y, you
-	  will be asked for your specific device in the following question.
+	  question about Microsoft network devices. If you say Y, you will be
+	  asked for your specific device in the following question.
 
 if NET_VENDOR_MICROSOFT
 
 config MICROSOFT_MANA
 	tristate "Microsoft Azure Network Adapter (MANA) support"
-	default m
 	depends on PCI_MSI && X86_64
 	select PCI_HYPERV
 	help
 	  This driver supports Microsoft Azure Network Adapter (MANA).
-	  So far, the driver is only validated on X86_64.
+	  So far, the driver is only supported on X86_64.
 
 	  To compile this driver as a module, choose M here.
 	  The module will be called mana.