scsi: ufs-qcom: Remove redundant dev_err call in ufs_qcom_init()
Subsystems (3)
PATCH 1/1 scsi: ufs-qcom: Remove redundant dev_err call in ufs_qcom_init()
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message.
--- drivers/scsi/ufs/ufs-qcom.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/scsi/ufs/ufs-qcom.c +1 -6
@@ -1071,13 +1071,8 @@ static int ufs_qcom_init(struct ufs_hba *hba)if (res) { host->dev_ref_clk_ctrl_mmio =devm_ioremap_resource (dev, res); -if (IS_ERR (host->dev_ref_clk_ctrl_mmio)) { -dev_warn (dev, -"%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n" , - __func__, -PTR_ERR (host->dev_ref_clk_ctrl_mmio)); +if (IS_ERR (host->dev_ref_clk_ctrl_mmio)) host->dev_ref_clk_ctrl_mmio =NULL ; - } host->dev_ref_clk_en_mask =BIT (5 ); } }
Quoted 8 lines · Ye Bin
There is a error message within
devm_ioremap_resourcealready, so remove the
dev_errcall to avoid redundanterror message.
Reported-by Hulk Robot <[email protected]>Signed-off-by Ye Bin <[email protected]>
Thanks,
Mani
Quoted 24 lines
--- drivers/scsi/ufs/ufs-qcom.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)drivers/scsi/ufs/ufs-qcom.c +1
-6@@ -1071,13 +1071,8 @@ static int ufs_qcom_init(struct ufs_hba *hba)if (res) { host->dev_ref_clk_ctrl_mmio =devm_ioremap_resource (dev, res); -if (IS_ERR (host->dev_ref_clk_ctrl_mmio)) { -dev_warn (dev, -"%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n" , - __func__, -PTR_ERR (host->dev_ref_clk_ctrl_mmio)); +if (IS_ERR (host->dev_ref_clk_ctrl_mmio)) host->dev_ref_clk_ctrl_mmio =NULL ; - } host->dev_ref_clk_en_mask =BIT (5 ); } }
Martin K. Petersen
AppliedQuoted 3 lines · Ye Bin
There is a error message within
devm_ioremap_resourcealready, so remove thedev_errcall to avoid redundant error message.
Applied to 5.13/scsi-queue, thanks!
[1/1] scsi: ufs-qcom: Remove redundant dev_err call in ufs_qcom_init()
https://git.kernel.org/mkp/scsi/c/790f9a48abd0
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
This patch was applied to qcom/linux.git (refs/heads/for-next):
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
Quoted 8 lines · On Fri, 9 Apr 2021 15:55:22 +0800 you wrote:
There is a error message within
devm_ioremap_resourcealready, so remove thedev_errcall to avoid redundant error message.Reported-by Hulk Robot <[email protected]>Signed-off-by Ye Bin <[email protected]>[...]
Here is the summary with links:
- [-next] scsi: ufs-qcom: Remove redundant dev_err call in ufs_qcom_init()
https://git.kernel.org/qcom/c/790f9a48abd0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html