Skip to contentSkip to conversation

char: xilinx_hwicap: use DEFINE_MUTEX() for mutex lock

PATCH In review Ye Bin 2 participants 2 messages Apr 9, 2021 – Apr 10, 2021

Subsystems (3)
lore
Share & tools
lore

Ye Bin

author
#0 lore raw

PATCH 1/1 char: xilinx_hwicap: use DEFINE_MUTEX() for mutex lock

mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init().

---
 drivers/char/xilinx_hwicap/xilinx_hwicap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/char/xilinx_hwicap/xilinx_hwicap.c +1 -2
index 067396bedf22..4d586233dfa4 100644
@@ -111,7 +111,7 @@
 /* An array, which is set to true when the device is registered. */
 static DEFINE_MUTEX(hwicap_mutex);
 static bool probed_devices[HWICAP_DEVICES];
-static struct mutex icap_sem;
+static DEFINE_MUTEX(icap_sem);
 
 static struct class *icap_class;
 
@@ -857,7 +857,6 @@ static int __init hwicap_module_init(void)
 	int retval;
 
 	icap_class = class_create(THIS_MODULE, "xilinx_config");
-	mutex_init(&icap_sem);
 
 	devt = MKDEV(XHWICAP_MAJOR, XHWICAP_MINOR);
 	retval = register_chrdev_region(devt,
#1 lore raw
Quoted 24 lines · Ye Bin

mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init().

---
 drivers/char/xilinx_hwicap/xilinx_hwicap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/char/xilinx_hwicap/xilinx_hwicap.c +1 -1
index 067396bedf22..4d586233dfa4 100644
@@ -111,7 +111,7 @@
 /* An array, which is set to true when the device is registered. */
 static DEFINE_MUTEX(hwicap_mutex);
 static bool probed_devices[HWICAP_DEVICES];
-static struct mutex icap_sem;
+static DEFINE_MUTEX(icap_sem);
 
 static struct class *icap_class;
 

drivers/char/xilinx_hwicap/xilinx_hwicap.c static int __init hwicap_module_init(void) · line 862

Quoted 7 lines
drivers/char/xilinx_hwicap/xilinx_hwicap.c +0 -1
@@ -857,7 +857,6 @@ static int __init hwicap_module_init(void)
 	int retval;
 
 	icap_class = class_create(THIS_MODULE, "xilinx_config");
-	mutex_init(&icap_sem);
 
 	devt = MKDEV(XHWICAP_MAJOR, XHWICAP_MINOR);
 	retval = register_chrdev_region(devt,

What actually does this help out with? Why is it wrong to explicitly call mutex_init() instead of a magic macro?

What good are these changes causing?

thanks,

greg k-h