staging: rtl8712: fix wrong function output
Subsystems (2)
PATCH v2 1/1 staging: rtl8712: fix wrong function output
Return NULL from r8712_find_network() if no matched wlan_network was found. Code with a bug:
while (plist != phead) {
pnetwork = container_of(plist, struct wlan_network, list);
plist = plist->next;
if (!memcmp(addr, pnetwork->network.MacAddress, ETH_ALEN))
break;
}spin_unlock_irqrestore(&scanned_queue->lock, irqL); return pnetwork;
In this code last processed pnetwork returned if list end was reached and no pnetwork matched test condition.
Signed-off-by Sergei Krainov <[email protected]>
---
Changes from v1: Updated description
drivers/staging/rtl8712/rtl871x_mlme.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/staging/rtl8712/rtl871x_mlme.c +2 -0
@@ -146,6 +146,8 @@ static struct wlan_network *r8712_find_network(struct __queue *scanned_queue,if (!memcmp (addr, pnetwork->network.MacAddress,ETH_ALEN ))break ; } +if (plist == phead) + pnetwork =NULL ;spin_unlock_irqrestore (&scanned_queue->lock, irqL);return pnetwork; }
Signature · 1 line
2.25.1