ata: Replace inclusion of kernel.h by bits.h in the header
PATCH v2 1/1 ata: Replace inclusion of kernel.h by bits.h in the header
ata.h uses BIT() macro, hence bits.h must be included. Otherwise there is no need to have kernel.h included, I do not see any direct users of it in ata.h. Hence replace inclusion of kernel.h.
---
v2: replaced kernel.h by bits.h (lkp), tested allmod/yesconfig on x86_64 (Jens)
include/linux/ata.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/ata.h +1 -1
@@ -13,7 +13,7 @@#ifndef __LINUX_ATA_H__#define __LINUX_ATA_H__ -#include <linux/kernel.h> +#include <linux/bits.h> #include <linux/string.h> #include <linux/types.h> #include <asm/byteorder.h>
Signature · 1 line
2.30.2
Quoted 3 lines · Andy Shevchenko
ata.husesBIT()macro, hencebits.hmust be included. Otherwise there is no need to havekernel.hincluded, I do not see any direct users of it inata.h. Hence replace inclusion ofkernel.h.
Jens, can we now apply this one?
Quoted 22 lines
Signed-off-by Andy Shevchenko <[email protected]>---
v2: replacedkernel.hbybits.h(lkp), tested allmod/yesconfig onx86_64(Jens)include/linux/ata.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/ata.h +1
-1@@ -13,7 +13,7 @@#ifndef __LINUX_ATA_H__#define __LINUX_ATA_H__ -#include <linux/kernel.h> +#include <linux/bits.h> #include <linux/string.h> #include <linux/types.h> #include <asm/byteorder.h> Signature · 1 line
2.30.2
Signature · 2 lines
With Best Regards, Andy Shevchenko
Jens Axboe
AppliedQuoted 3 lines · Andy Shevchenko
ata.husesBIT()macro, hencebits.hmust be included. Otherwise there is no need to havekernel.hincluded, I do not see any direct users of it inata.h. Hence replace inclusion ofkernel.h.
Applied, thanks.
Signature · 1 line
Jens Axboe