Skip to contentSkip to conversation

ovl: add debug print to ovl_do_getxattr()

PATCH Applied Amir Goldstein 2 participants 2 messages Apr 10, 2021 – Apr 12, 2021 Overlay filesystem

lore
Share & tools
lore

Amir Goldstein

author maintainer
#0 lore raw

PATCH 1/1 ovl: add debug print to ovl_do_getxattr()

It was the only ovl_do helper missing it.

---
 fs/overlayfs/overlayfs.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
fs/overlayfs/overlayfs.h +6 -1
index 2322f854533c..d1e08d804207 100644
@@ -186,7 +186,12 @@ static inline ssize_t ovl_do_getxattr(struct ovl_fs *ofs, struct dentry *dentry,
 				      size_t size)
 {
 	const char *name = ovl_xattr(ofs, ox);
-	return vfs_getxattr(&init_user_ns, dentry, name, value, size);
+	int err = vfs_getxattr(&init_user_ns, dentry, name, value, size);
+	int len = (value && err > 0) ? err : 0;
+
+	pr_debug("getxattr(%pd2, \"%s\", \"%*pE\", %zu, 0) = %i\n",
+		 dentry, name, min(len, 48), value, size, err);
+	return err;
 }
 
 static inline int ovl_do_setxattr(struct ovl_fs *ofs, struct dentry *dentry,
Signature · 1 line
2.30.0