Skip to contentSkip to conversation

iio: adc: ad7768-1: Keep fwnode reference count balanced

PATCH In review Andy Shevchenko 1 participant 2 messages Apr 12, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: adc: ad7768-1: Keep fwnode reference count balanced

The commit 75ed0be7200d ("iio: adc: ad7768-1: Add channel labels.") missed the point that loop counter should be put after use. Otherwise the reference count of it will become unbalanced.

Fixes 75ed0be7200d ("iio: adc: ad7768-1: Add channel labels.")
Cc Cristian Pop <[email protected]>
---
 drivers/iio/adc/ad7768-1.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/adc/ad7768-1.c +1 -0
index c945f1349623..c488bd4bfeba 100644
@@ -565,6 +565,7 @@ static int ad7768_set_channel_label(struct iio_dev *indio_dev,
 
 		st->labels[crt_ch] = label;
 	}
+	fwnode_handle_put(fwnode);
 
 	return 0;
 }
Signature · 1 line
2.31.1
#1 lore raw
Quoted 3 lines · Andy Shevchenko

The commit 75ed0be7200d ("iio: adc: ad7768-1: Add channel labels.") missed the point that loop counter should be put after use. Otherwise the reference count of it will become unbalanced.

Scratch this, I might be not slept enough.

Signature · 2 lines
With Best Regards,
Andy Shevchenko