staging: media: atomisp: Minor code style changes
Subsystems (4)
PATCH 1/1 staging: media: atomisp: Minor code style changes
Fixed line continuation and parenthesis alignment issues.
--- drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c +4 -4
@@ -49,8 +49,8 @@ static int ov2722_read_reg(struct i2c_client *client,return -ENODEV ; } -if (data_length !=OV2722_8BIT && data_length !=OV2722_16BIT - && data_length !=OV2722_32BIT ) { +if (data_length !=OV2722_8BIT && data_length !=OV2722_16BIT && + data_length !=OV2722_32BIT ) {dev_err (&client->dev,"%s error, invalid data length\n" , __func__);return -EINVAL ;
@@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client, }static int __ov2722_write_reg_is_consecutive (struct i2c_client *client, -struct ov2722_write_ctrl *ctrl, -const struct ov2722_reg *next) +struct ov2722_write_ctrl *ctrl, +const struct ov2722_reg *next) {if (ctrl->index ==0 )return 1 ;
Signature · 1 line
2.31.1
Please repost with a '[PATCHv3]' in the subject.
This version should have been '[PATCHv2]', but you forgot the v2 part :-)
It's important, since now I had no indication that the previous patch was superseded and I tried to apply both, thus discovering that the older one should have been skipped.
Regards,
Hans
Quoted 34 lines · Martiros Shakhzadyan
Fixed line continuation and parenthesis alignment issues.
Signed-off-by Martiros Shakhzadyan <[email protected]>--- drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/media/atomisp/i2c/atomisp-ov2722.c +4
-4@@ -49,8 +49,8 @@ static int ov2722_read_reg(struct i2c_client *client,return -ENODEV ; } -if (data_length !=OV2722_8BIT && data_length !=OV2722_16BIT - && data_length !=OV2722_32BIT ) { +if (data_length !=OV2722_8BIT && data_length !=OV2722_16BIT && + data_length !=OV2722_32BIT ) {dev_err (&client->dev,"%s error, invalid data length\n" , __func__);return -EINVAL ;@@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client, }static int __ov2722_write_reg_is_consecutive (struct i2c_client *client, -struct ov2722_write_ctrl *ctrl, -const struct ov2722_reg *next) +struct ov2722_write_ctrl *ctrl, +const struct ov2722_reg *next) {if (ctrl->index ==0 )return 1 ;
Quoted 11 lines · Hans Verkuil
Please repost with a '[PATCHv3]' in the subject.
This version should have been '[PATCHv2]', but you forgot the v2 part :-)
It's important, since now I had no indication that the previous patch was superseded and I tried to apply both, thus discovering that the older one should have been skipped.
Regards,
Hans
Got it! Will do that now - thanks for your patience :)
Quoted 36 lines · Martiros Shakhzadyan
Quoted 34 lines
Fixed line continuation and parenthesis alignment issues.
Signed-off-by Martiros Shakhzadyan <[email protected]>--- drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/media/atomisp/i2c/atomisp-ov2722.c +4
-4@@ -49,8 +49,8 @@ static int ov2722_read_reg(struct i2c_client *client,return -ENODEV ; } -if (data_length !=OV2722_8BIT && data_length !=OV2722_16BIT - && data_length !=OV2722_32BIT ) { +if (data_length !=OV2722_8BIT && data_length !=OV2722_16BIT && + data_length !=OV2722_32BIT ) {dev_err (&client->dev,"%s error, invalid data length\n" , __func__);return -EINVAL ;@@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client, }static int __ov2722_write_reg_is_consecutive (struct i2c_client *client, -struct ov2722_write_ctrl *ctrl, -const struct ov2722_reg *next) +struct ov2722_write_ctrl *ctrl, +const struct ov2722_reg *next) {if (ctrl->index ==0 )return 1 ;