Skip to contentSkip to conversation

kmod: do not symlink config.guess/config.sub during autoreconf

PATCH New [email protected] 1 participant 1 message Apr 13, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kmod: do not symlink config.guess/config.sub during autoreconf

From: Gavin Li <[email protected]>

I was encountering the following race condition on poky:

- automake-native does do_install.
- automake-native does do_populate_sysroot. This hardlinks config.guess and config.sub into ${D}.
- kmod-native does do_configure. This runs autoreconf, which runs automake --add-missing (symlinks config.guess/config.sub from recipe-sysroot-native to build dir), then runs gnu-configize (copies _its own_ config.guess/config.sub _on top_ of the already existing ones). Since the destinations already had symlinks, the copy would overwrite config.guess/config.sub in recipe-sysroot-native, which would in turn overwrite the same in ${D} due to being hardlinked.
- automake-native does do_package. The outhash is thus calculated on the clobbered config.guess/config.sub files.

With hash equivalency enabled, the different outhash produced a different unihash, which kept me from reusing sstate between my laptop and my build server. This race condition would happen only on the build server (BB_NUMBER_THREADS = 32) but never on my laptop (BB_NUMBER_THREADS = 6).

I didn't see the --install and --symlink flags being used by any other recipe, so I removed them, and that fixed the issue.

---
 meta/recipes-kernel/kmod/kmod.inc | 1 -
 1 file changed, 1 deletion(-)
meta/recipes-kernel/kmod/kmod.inc +0 -1
index ccda9f2b73..ba5ec7f650 100644
@@ -26,7 +26,6 @@ SRC_URI = "git://git.kernel.org/pub/scm/utils/kernel/kmod/kmod.git \
 
 S = "${WORKDIR}/git"
 
-EXTRA_AUTORECONF += "--install --symlink"
 EXTRA_OECONF +=" --enable-tools --with-zlib"
 
 PACKAGECONFIG[debug] = "--enable-debug,--disable-debug"
Signature · 1 line
2.31.1