dyndbg: fix parsing file query without a line-range suffix
Subsystems (2)
PATCH 1/1 dyndbg: fix parsing file query without a line-range suffix
From: Shuo Chen <[email protected]>
Query like 'file tcp_input.c line 1234 +p' was broken by
commit aaebe329bff0 ("dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'") because a file name without a ':' now makes the loop in ddebug_parse_query() exits early before parsing the 'line 1234' part. As a result, all pr_debug() in tcp_input.c will be enabled, instead of only the one on line 1234. Changing 'break' to 'continue' fixes this.
--- lib/dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/dynamic_debug.c +1 -1
@@ -396,7 +396,7 @@ static int ddebug_parse_query(char *words[], int nwords,/* tail :$info is function or line-range */ fline =strchr (query->filename,':' );if (!fline) -break ; +continue ; *fline++ ='\0' ;if (isalpha (*fline) || *fline =='*' || *fline =='?' ) {/* take as function name */
Signature · 1 line
2.31.1.295.g9ea45b61b8-goog
Quoted 21 lines · Shuo Chen
From: Shuo Chen <[email protected]>
Query like 'file
tcp_input.cline 1234 +p' was broken by
commitaaebe329bff0("dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'") because a file name without a ':' now makes the loop inddebug_parse_query()exits early before parsing the 'line 1234' part. As a result, allpr_debug()intcp_input.cwill be enabled, instead of only the one on line 1234. Changing 'break' to 'continue' fixes this.Fixes aaebe329bff0 ("dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'")Signed-off-by Shuo Chen <[email protected]>--- lib/dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/dynamic_debug.c +0
-0
lib/dynamic_debug.c static int ddebug_parse_query(char *words[], int nwords, · line 402
Quoted 8 lines
lib/dynamic_debug.c +1
-1@@ -396,7 +396,7 @@ static int ddebug_parse_query(char *words[], int nwords,/* tail :$info is function or line-range */ fline =strchr (query->filename,':' );if (!fline) -break ; +continue ; *fline++ ='\0' ;if (isalpha (*fline) || *fline =='*' || *fline =='?' ) {/* take as function name */
SGTM, thanks !
Jason Baron
maintainerQuoted 35 lines · Eric Dumazet
Quoted 21 lines · Shuo Chen
From: Shuo Chen <[email protected]>
Query like 'file
tcp_input.cline 1234 +p' was broken by
commitaaebe329bff0("dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'") because a file name without a ':' now makes the loop inddebug_parse_query()exits early before parsing the 'line 1234' part. As a result, allpr_debug()intcp_input.cwill be enabled, instead of only the one on line 1234. Changing 'break' to 'continue' fixes this.Fixes aaebe329bff0 ("dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'")Signed-off-by Shuo Chen <[email protected]>--- lib/dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/dynamic_debug.c +0
-0lib/dynamic_debug.c static int ddebug_parse_query(char *words[], int nwords, · line 402
Quoted 8 lines
lib/dynamic_debug.c +1
-1@@ -396,7 +396,7 @@ static int ddebug_parse_query(char *words[], int nwords,/* tail :$info is function or line-range */ fline =strchr (query->filename,':' );if (!fline) -break ; +continue ; *fline++ ='\0' ;if (isalpha (*fline) || *fline =='*' || *fline =='?' ) {/* take as function name */ SGTM, thanks !
Quoted 2 lines
Reviewed-by Eric Dumazet <[email protected]>
Hi Greg,
I acked this previously and is an important fix.
Can you please pick it up if you haven't done so?
Thanks!
-Jason
Quoted 38 lines · Jason Baron
Quoted 35 lines · Eric Dumazet
Quoted 21 lines · Shuo Chen
From: Shuo Chen <[email protected]>
Query like 'file
tcp_input.cline 1234 +p' was broken by
commitaaebe329bff0("dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'") because a file name without a ':' now makes the loop inddebug_parse_query()exits early before parsing the 'line 1234' part. As a result, allpr_debug()intcp_input.cwill be enabled, instead of only the one on line 1234. Changing 'break' to 'continue' fixes this.Fixes aaebe329bff0 ("dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'")Signed-off-by Shuo Chen <[email protected]>--- lib/dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/dynamic_debug.c +0
-0lib/dynamic_debug.c static int ddebug_parse_query(char *words[], int nwords, · line 402
Quoted 8 lines
lib/dynamic_debug.c +1
-1@@ -396,7 +396,7 @@ static int ddebug_parse_query(char *words[], int nwords,/* tail :$info is function or line-range */ fline =strchr (query->filename,':' );if (!fline) -break ; +continue ; *fline++ ='\0' ;if (isalpha (*fline) || *fline =='*' || *fline =='?' ) {/* take as function name */ SGTM, thanks !
Quoted 7 lines
Quoted 2 lines
Reviewed-by Eric Dumazet <[email protected]>Hi Greg,
I acked this previously and is an important fix.
Can you please pick it up if you haven't done so?
Will do, sorry for the delay.
greg k-h