Skip to contentSkip to conversation

scripts/spdxcheck.py: Use Python 3

PATCH Applied Antony Pavlov 4 participants 5 messages Apr 16, 2021 – May 3, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scripts/spdxcheck.py: Use Python 3

Based on this linux kernel commit:

Quoted 8 lines

commit d0259c42abff51b586496a0594933e394efefbc5

Author: Bert Vermeulen <[email protected]>
Date:   Thu Jan 21 09:54:12 2021 +0100

spdxcheck.py: Use Python 3

Python 2.x has been officially EOL'ed for some time, and in any case the git module for it is hard to come by.

---
 scripts/checkpatch.pl | 4 ++--
 scripts/spdxcheck.py  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +2 -2
index b8bd4e1a59..36e3d768f3 100755
@@ -885,10 +885,10 @@ sub is_maintained_obsolete {
 sub is_SPDX_License_valid {
 	my ($license) = @_;
 
-	return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
+	return 1 if (!$tree || which("python3") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
 
 	my $root_path = abs_path($root);
-	my $status = `cd "$root_path"; echo "$license" | python scripts/spdxcheck.py -`;
+	my $status = `cd "$root_path"; echo "$license" | python3 scripts/spdxcheck.py -`;
 	return 0 if ($status ne "");
 	return 1;
 }
scripts/spdxcheck.py +1 -1
index 6374e078a5..0f81337394 100755
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: GPL-2.0
 # Copyright Thomas Gleixner <[email protected]>
 
Signature · 7 lines
2.31.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw

On Fri, 16 Apr 2021 12:14:04 +0300
Antony Pavlov <[email protected]> wrote:

ping

Quoted 47 lines

Based on this linux kernel commit:

Quoted 8 lines

commit d0259c42abff51b586496a0594933e394efefbc5

Author: Bert Vermeulen <[email protected]>
Date:   Thu Jan 21 09:54:12 2021 +0100

spdxcheck.py: Use Python 3

Python 2.x has been officially EOL'ed for some time, and in any case the git module for it is hard to come by.

---
 scripts/checkpatch.pl | 4 ++--
 scripts/spdxcheck.py  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +2 -2
index b8bd4e1a59..36e3d768f3 100755
@@ -885,10 +885,10 @@ sub is_maintained_obsolete {
 sub is_SPDX_License_valid {
 	my ($license) = @_;
 
-	return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
+	return 1 if (!$tree || which("python3") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
 
 	my $root_path = abs_path($root);
-	my $status = `cd "$root_path"; echo "$license" | python scripts/spdxcheck.py -`;
+	my $status = `cd "$root_path"; echo "$license" | python3 scripts/spdxcheck.py -`;
 	return 0 if ($status ne "");
 	return 1;
 }
scripts/spdxcheck.py +1 -1
index 6374e078a5..0f81337394 100755
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: GPL-2.0
 # Copyright Thomas Gleixner <[email protected]>
 
Signature · 1 line
2.31.0
Signature · 7 lines
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#2 lore raw

Hi Antony,

Am Mittwoch, dem 28.04.2021 um 07:39 +0300 schrieb Antony Pavlov:

Quoted 4 lines

On Fri, 16 Apr 2021 12:14:04 +0300
Antony Pavlov <[email protected]> wrote:

ping

Please be patient. Sascha is out sick, but should be back next week.

Regards,
Lucas

Quoted 53 lines
Quoted 53 lines

Based on this linux kernel commit:

Quoted 8 lines

commit d0259c42abff51b586496a0594933e394efefbc5

Author: Bert Vermeulen <[email protected]>
Date:   Thu Jan 21 09:54:12 2021 +0100

   spdxcheck.py: Use Python 3

   Python 2.x has been officially EOL'ed for some time, and in any case the git module for it is hard to come by.

---
 scripts/checkpatch.pl | 4 ++--
 scripts/spdxcheck.py | 2 +-

 2 files changed, 3 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +0 -0
index b8bd4e1a59..36e3d768f3 100755
@@ -885,10 +885,10 @@ sub is_maintained_obsolete {
  sub is_SPDX_License_valid {
  	my ($license) = @_;

scripts/checkpatch.pl +1 -1
-	return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
+	return 1 if (!$tree || which("python3") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));

  my $root_path = abs_path($root);

scripts/checkpatch.pl +1 -1
-	my $status = `cd "$root_path"; echo "$license" | python scripts/spdxcheck.py -`;
+	my $status = `cd "$root_path"; echo "$license" | python3 scripts/spdxcheck.py -`;

  return 0 if ($status ne "");
  return 1;
 }

scripts/spdxcheck.py +1 -1
index 6374e078a5..0f81337394 100755
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
  # SPDX-License-Identifier: GPL-2.0
  # Copyright Thomas Gleixner <[email protected]>

Quoted 5 lines
Quoted 3 lines
Signature · 1 line
2.31.0

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

Acked-by on v1 1/1
#3 lore raw
In reply to Antony Pavlov
Quoted 6 lines · Antony Pavlov

Based on this linux kernel commit:

Quoted 4 lines

commit d0259c42abff51b586496a0594933e394efefbc5

Author: Bert Vermeulen <[email protected]>
Date:   Thu Jan 21 09:54:12 2021 +0100
Quoted 6 lines
Quoted 4 lines

spdxcheck.py: Use Python 3

Python 2.x has been officially EOL'ed for some time, and in any case the git module for it is hard to come by.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

Applied
#4 lore raw
In reply to Antony Pavlov
Quoted 8 lines · Antony Pavlov

Based on this linux kernel commit:

Quoted 6 lines

commit d0259c42abff51b586496a0594933e394efefbc5

Author: Bert Vermeulen <[email protected]>
Date:   Thu Jan 21 09:54:12 2021 +0100

spdxcheck.py: Use Python 3

Quoted 8 lines
Quoted 2 lines

Python 2.x has been officially EOL'ed for some time, and in any case the git module for it is hard to come by.

---
 scripts/checkpatch.pl | 4 ++--
 scripts/spdxcheck.py  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox