sched: Warn on long periods of pending need_resched
PATCH v2 1/1 sched: Warn on long periods of pending need_resched
From: Paul Turner <[email protected]>
CPU scheduler marks need_resched flag to signal a schedule() on a particular CPU. But, schedule() may not happen immediately in cases where the current task is executing in the kernel mode (no preemption state) for extended periods of time.
This patch adds a warn_on if need_resched is pending for more than the time specified in sysctl resched_latency_warn_ms. If it goes off, it is likely that there is a missing cond_resched() somewhere. Monitoring is done via the tick and the accuracy is hence limited to jiffy scale. This also means that we won't trigger the warning if the tick is disabled.
This feature (LATENCY_WARN) is default disabled.
---
This squashes the fixup from https://lkml.org/lkml/2021/3/30/1309.
include/linux/sched/sysctl.h | 3 ++ kernel/sched/core.c | 70 +++++++++++++++++++++++++++++++++++- kernel/sched/debug.c | 13 +++++++ kernel/sched/features.h | 2 ++ kernel/sched/sched.h | 10 ++++++ 5 files changed, 97 insertions(+), 1 deletion(-)
include/linux/sched/sysctl.h +3 -0
@@ -48,6 +48,9 @@ extern unsigned int sysctl_numa_balancing_scan_size;#ifdef CONFIG_SCHED_DEBUG extern __read_mostly unsigned int sysctl_sched_migration_cost;extern __read_mostly unsigned int sysctl_sched_nr_migrate; + +extern int sysctl_resched_latency_warn_ms; +extern int sysctl_resched_latency_warn_once;#endif /*
kernel/sched/core.c +69 -1
104 lines not on this page · raw message
kernel/sched/debug.c +13 -0
@@ -309,6 +309,9 @@ static __init int sched_init_debug(void)debugfs_create_u32 ("min_granularity_ns" ,0644 , debugfs_sched, &sysctl_sched_min_granularity);debugfs_create_u32 ("wakeup_granularity_ns" ,0644 , debugfs_sched, &sysctl_sched_wakeup_granularity); +debugfs_create_u32 ("latency_warn_ms" ,0644 , debugfs_sched, &sysctl_resched_latency_warn_ms); +debugfs_create_u32 ("latency_warn_once" ,0644 , debugfs_sched, &sysctl_resched_latency_warn_once); +#ifdef CONFIG_SMP debugfs_create_file ("tunable_scaling" ,0644 , debugfs_sched,NULL , &sched_scaling_fops);debugfs_create_u32 ("migration_cost_ns" ,0644 , debugfs_sched, &sysctl_sched_migration_cost);
@@ -1032,3 +1035,13 @@ void proc_sched_set_task(struct task_struct *p)memset (&p->se.statistics,0 ,sizeof (p->se.statistics));#endif } + +void resched_latency_warn (int cpu,u64 latency) +{ + static DEFINE_RATELIMIT_STATE(latency_check_ratelimit, 60 * 60 * HZ, 1); + +WARN (__ratelimit (&latency_check_ratelimit), +"sched: CPU %d need_resched set for > %llu ns (%d ticks) " +"without schedule\n" , + cpu, latency,cpu_rq (cpu)->ticks_without_resched); +}
kernel/sched/features.h +2 -0
@@ -91,5 +91,7 @@ SCHED_FEAT(WA_BIAS, true) SCHED_FEAT(UTIL_EST, true) SCHED_FEAT(UTIL_EST_FASTUP, true) +SCHED_FEAT(LATENCY_WARN, false) + SCHED_FEAT(ALT_PERIOD, true)SCHED_FEAT (BASE_SLICE , true)
kernel/sched/sched.h +10 -0
@@ -58,6 +58,7 @@#include <linux/prefetch.h> #include <linux/profile.h> #include <linux/psi.h> +#include <linux/ratelimit.h> #include <linux/rcupdate_wait.h> #include <linux/security.h> #include <linux/stop_machine.h>
@@ -971,6 +972,11 @@ struct rq {atomic_t nr_iowait; +#ifdef CONFIG_SCHED_DEBUG +u64 last_seen_need_resched_ns; +int ticks_without_resched; +#endif +#ifdef CONFIG_MEMBARRIER int membarrier_state;#endif
@@ -2376,6 +2382,8 @@ extern void print_dl_stats(struct seq_file *m, int cpu);extern void print_cfs_rq (struct seq_file *m,int cpu,struct cfs_rq *cfs_rq);extern void print_rt_rq (struct seq_file *m,int cpu,struct rt_rq *rt_rq);extern void print_dl_rq (struct seq_file *m,int cpu,struct dl_rq *dl_rq); + +extern void resched_latency_warn (int cpu,u64 latency);#ifdef CONFIG_NUMA_BALANCING extern void show_numa_stats (struct task_struct *p,struct seq_file *m);
@@ -2383,6 +2391,8 @@ extern void print_numa_stats(struct seq_file *m, int node, unsigned long tsf, unsigned long tpf, unsigned long gsf, unsigned long gpf);#endif /* CONFIG_NUMA_BALANCING */ +#else +static inline void resched_latency_warn (int cpu,u64 latency) {}#endif /* CONFIG_SCHED_DEBUG */ extern void init_cfs_rq (struct cfs_rq *cfs_rq);
Signature · 1 line
2.31.1.368.gbe11c130af-goog
Peter Zijlstra
maintainerQuoted 13 lines · Josh Don
From: Paul Turner <[email protected]>
CPU scheduler marks
need_reschedflag to signal aschedule()on a particular CPU. But,schedule()may not happen immediately in cases where the current task is executing in the kernel mode (no preemption state) for extended periods of time.This patch adds a
warn_onifneed_reschedis pending for more than the time specified in sysctlresched_latency_warn_ms. If it goes off, it is likely that there is a missingcond_resched()somewhere. Monitoring is done via the tick and the accuracy is hence limited to jiffy scale. This also means that we won't trigger the warning if the tick is disabled.
Quoted 6 lines
This feature (
LATENCY_WARN) is default disabled.Signed-off-by Paul Turner <[email protected]>Signed-off-by Josh Don <[email protected]>Signed-off-by Peter Zijlstra (Intel) <[email protected]>
Thanks!
The following commit has been merged into the sched/core branch of tip:
The following commit has been merged into the sched/core branch of tip:
Commit-ID: c006fac556e401a62054d065da168099ea5a5b10 Gitweb: https://git.kernel.org/tip/c006fac556e401a62054d065da168099ea5a5b10 Author: Paul Turner <[email protected]> AuthorDate: Fri, 16 Apr 2021 14:29:36 -07:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Wed, 21 Apr 2021 13:55:41 +02:00
sched: Warn on long periods of pending need_resched
CPU scheduler marks need_resched flag to signal a schedule() on a particular CPU. But, schedule() may not happen immediately in cases where the current task is executing in the kernel mode (no preemption state) for extended periods of time.
This patch adds a warn_on if need_resched is pending for more than the time specified in sysctl resched_latency_warn_ms. If it goes off, it is likely that there is a missing cond_resched() somewhere. Monitoring is done via the tick and the accuracy is hence limited to jiffy scale. This also means that we won't trigger the warning if the tick is disabled.
This feature (LATENCY_WARN) is default disabled.
--- include/linux/sched/sysctl.h | 3 ++- kernel/sched/core.c | 70 ++++++++++++++++++++++++++++++++++- kernel/sched/debug.c | 13 +++++++- kernel/sched/features.h | 2 +- kernel/sched/sched.h | 10 +++++- 5 files changed, 97 insertions(+), 1 deletion(-)
include/linux/sched/sysctl.h +3 -0
@@ -48,6 +48,9 @@ extern unsigned int sysctl_numa_balancing_scan_size;#ifdef CONFIG_SCHED_DEBUG extern __read_mostly unsigned int sysctl_sched_migration_cost;extern __read_mostly unsigned int sysctl_sched_nr_migrate; + +extern int sysctl_resched_latency_warn_ms; +extern int sysctl_resched_latency_warn_once;#endif /*
kernel/sched/core.c +69 -1
104 lines not on this page · raw message
kernel/sched/debug.c +13 -0
@@ -309,6 +309,9 @@ static __init int sched_init_debug(void)debugfs_create_u32 ("min_granularity_ns" ,0644 , debugfs_sched, &sysctl_sched_min_granularity);debugfs_create_u32 ("wakeup_granularity_ns" ,0644 , debugfs_sched, &sysctl_sched_wakeup_granularity); +debugfs_create_u32 ("latency_warn_ms" ,0644 , debugfs_sched, &sysctl_resched_latency_warn_ms); +debugfs_create_u32 ("latency_warn_once" ,0644 , debugfs_sched, &sysctl_resched_latency_warn_once); +#ifdef CONFIG_SMP debugfs_create_file ("tunable_scaling" ,0644 , debugfs_sched,NULL , &sched_scaling_fops);debugfs_create_u32 ("migration_cost_ns" ,0644 , debugfs_sched, &sysctl_sched_migration_cost);
@@ -1027,3 +1030,13 @@ void proc_sched_set_task(struct task_struct *p)memset (&p->se.statistics,0 ,sizeof (p->se.statistics));#endif } + +void resched_latency_warn (int cpu,u64 latency) +{ + static DEFINE_RATELIMIT_STATE(latency_check_ratelimit, 60 * 60 * HZ, 1); + +WARN (__ratelimit (&latency_check_ratelimit), +"sched: CPU %d need_resched set for > %llu ns (%d ticks) " +"without schedule\n" , + cpu, latency,cpu_rq (cpu)->ticks_without_resched); +}
kernel/sched/features.h +2 -0
@@ -91,5 +91,7 @@ SCHED_FEAT(WA_BIAS, true) SCHED_FEAT(UTIL_EST, true) SCHED_FEAT(UTIL_EST_FASTUP, true) +SCHED_FEAT(LATENCY_WARN, false) + SCHED_FEAT(ALT_PERIOD, true)SCHED_FEAT (BASE_SLICE , true)
kernel/sched/sched.h +10 -0
@@ -58,6 +58,7 @@#include <linux/prefetch.h> #include <linux/profile.h> #include <linux/psi.h> +#include <linux/ratelimit.h> #include <linux/rcupdate_wait.h> #include <linux/security.h> #include <linux/stop_machine.h>
@@ -971,6 +972,11 @@ struct rq {atomic_t nr_iowait; +#ifdef CONFIG_SCHED_DEBUG +u64 last_seen_need_resched_ns; +int ticks_without_resched; +#endif +#ifdef CONFIG_MEMBARRIER int membarrier_state;#endif
@@ -2371,6 +2377,8 @@ extern void print_dl_stats(struct seq_file *m, int cpu);extern void print_cfs_rq (struct seq_file *m,int cpu,struct cfs_rq *cfs_rq);extern void print_rt_rq (struct seq_file *m,int cpu,struct rt_rq *rt_rq);extern void print_dl_rq (struct seq_file *m,int cpu,struct dl_rq *dl_rq); + +extern void resched_latency_warn (int cpu,u64 latency);#ifdef CONFIG_NUMA_BALANCING extern void show_numa_stats (struct task_struct *p,struct seq_file *m);
@@ -2378,6 +2386,8 @@ extern void print_numa_stats(struct seq_file *m, int node, unsigned long tsf, unsigned long tpf, unsigned long gsf, unsigned long gpf);#endif /* CONFIG_NUMA_BALANCING */ +#else +static inline void resched_latency_warn (int cpu,u64 latency) {}#endif /* CONFIG_SCHED_DEBUG */ extern void init_cfs_rq (struct cfs_rq *cfs_rq);