Skip to contentSkip to conversation

docs/platform: sifive_fu540: Update U-Boot defconfig name

PATCH New Bin Meng 2 participants 4 messages Apr 21, 2021 – Apr 29, 2021 SiFive drivers

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/1 docs/platform: sifive_fu540: Update U-Boot defconfig name

With latest U-Boot upstream (v2021.07 in development), the defconfig name has been changed to sifive_unleashed_defconfig. Update the doc.

---

 docs/platform/sifive_fu540.md | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
docs/platform/sifive_fu540.md +6 -5
index b4d3c60..b38df47 100644
@@ -42,7 +42,7 @@ make PLATFORM=sifive/fu540 FW_PAYLOAD_PATH=<linux_build_directory>/arch/riscv/bo
 
 The command-line example here assumes that U-Boot was compiled using the
 sifive_fu540_defconfig configuration and with U-Boot v2020.01, and up to
-v2020.07-rc3.
+v2021.04. sifive_unleashed_defconfig shall be used with v2021.07 or above.
 
 ```
 make PLATFORM=sifive/fu540 FW_PAYLOAD_PATH=<u-boot_build_dir>/u-boot-dtb.bin
@@ -153,11 +153,12 @@ This is because QEMU generates a device tree blob on the fly based on the
 command line parameters and it's compatible with the one used in the upstream
 Linux kernel.
 
-When U-Boot v2020.01 (or higher) is used as the payload, as the SiFive FU540
+When U-Boot v2021.07 (or higher) is used as the payload, as the SiFive FU540
 DTB for the real hardware is embedded in U-Boot binary itself, due to the same
-reason above, we need to switch the U-Boot sifive_fu540_defconfig configuration
-from **CONFIG_OF_SEPARATE** to **CONFIG_OF_PRIOR_STAGE** so that U-Boot uses the
-DTB generated by QEMU, and u-boot.bin should be used as the payload image, like:
+reason above, we need to switch the U-Boot sifive_unleashed_defconfig
+configuration from **CONFIG_OF_SEPARATE** to **CONFIG_OF_PRIOR_STAGE** so that
+U-Boot uses the DTB generated by QEMU, and u-boot.bin should be used as the
+payload image, like:
 
 ```
 make PLATFORM=sifive/fu540 FW_PAYLOAD_PATH=<u-boot_build_dir>/u-boot.bin
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 1/1 docs/platform: sifive_fu540: Update U-Boot defconfig name

Quoted 10 lines · Bin Meng

With latest U-Boot upstream (v2021.07 in development), the defconfig name has been changed to sifive_unleashed_defconfig. Update the doc.

---

 docs/platform/sifive_fu540.md | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

Ping?

#2 lore raw

PATCH 1/1 docs/platform: sifive_fu540: Update U-Boot defconfig name

In reply to Bin Meng
Quoted 10 lines

-----Original Message-----
From: opensbi <[email protected]> On Behalf Of Bin Meng
Sent: 21 April 2021 09:50
To: opensbi at lists.infradead.org
Subject: [PATCH] docs/platform: sifive_fu540: Update U-Boot defconfig name

Quoted 4 lines

With latest U-Boot upstream (v2021.07 in development), the defconfig name has been changed to sifive_unleashed_defconfig. Update the doc.

My bad, I totally missed this patch.

Overall, patch look good to me. I will wait few more hours and merge it.

Regards,
Anup

Quoted 50 lines

---

 docs/platform/sifive_fu540.md | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
docs/platform/sifive_fu540.md +0 -0
index b4d3c60..b38df47 100644
@@ -42,7 +42,7 @@ make PLATFORM=sifive/fu540

FW_PAYLOAD_PATH=<linux_build_directory>/arch/riscv/bo

The command-line example here assumes that U-Boot was compiled using
the sifive_fu540_defconfig configuration and with U-Boot v2020.01, and up to -v2020.07-rc3.
+v2021.04. sifive_unleashed_defconfig shall be used with v2021.07 or above.

```
make PLATFORM=sifive/fu540 FW_PAYLOAD_PATH=<u-boot_build_dir>/u-
boot-dtb.bin

docs/platform/sifive_fu540.md +0 -0
@@ -153,11 +153,12 @@ This is because QEMU generates a device tree blob

on the fly based on the command line parameters and it's compatible with the one used in the upstream Linux kernel.

-When U-Boot v2020.01 (or higher) is used as the payload, as the SiFive FU540

docs/platform/sifive_fu540.md +2 -0
+When U-Boot v2021.07 (or higher) is used as the payload, as the SiFive
+FU540
 DTB for the real hardware is embedded in U-Boot binary itself, due to the

same -reason above, we need to switch the U-Boot sifive_fu540_defconfig configuration -from **CONFIG_OF_SEPARATE** to **CONFIG_OF_PRIOR_STAGE** so that U-Boot uses the -DTB generated by QEMU, and u-boot.bin should be used as the payload image, like:

docs/platform/sifive_fu540.md +2 -0
+reason above, we need to switch the U-Boot sifive_unleashed_defconfig
+configuration from **CONFIG_OF_SEPARATE** to

**CONFIG_OF_PRIOR_STAGE**

docs/platform/sifive_fu540.md +2 -0
+so that U-Boot uses the DTB generated by QEMU, and u-boot.bin should be
+used as the payload image, like:
 
 ```
 make PLATFORM=sifive/fu540 FW_PAYLOAD_PATH=<u-boot_build_dir>/u-

boot.bin
--
2.25.1

--
opensbi mailing list
opensbi at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi

Applied
#3 lore raw

PATCH 1/1 docs/platform: sifive_fu540: Update U-Boot defconfig name

Quoted 22 lines

-----Original Message-----
From: Anup Patel
Sent: 29 April 2021 11:16
To: Bin Meng <[email protected]>; opensbi at lists.infradead.org
Subject: RE: [PATCH] docs/platform: sifive_fu540: Update U-Boot defconfig name

Quoted 11 lines

-----Original Message-----
From: opensbi <[email protected]> On Behalf Of Bin Meng
Sent: 21 April 2021 09:50
To: opensbi at lists.infradead.org
Subject: [PATCH] docs/platform: sifive_fu540: Update U-Boot defconfig name

With latest U-Boot upstream (v2021.07 in development), the defconfig name has been changed to sifive_unleashed_defconfig. Update the doc.

Quoted 7 lines
Quoted 1 line

My bad, I totally missed this patch.

Overall, patch look good to me. I will wait few more hours and merge it.

Applied this patch to the riscv/opensbi repo

Thanks,
Anup

Quoted 60 lines

Regards,
Anup

Quoted 12 lines

---

 docs/platform/sifive_fu540.md | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
(quoted diff) +0 -0

b/docs/platform/sifive_fu540.md index b4d3c60..b38df47 100644

docs/platform/sifive_fu540.md +0 -0
@@ -42,7 +42,7 @@ make PLATFORM=sifive/fu540

FW_PAYLOAD_PATH=<linux_build_directory>/arch/riscv/bo

Quoted 4 lines

The command-line example here assumes that U-Boot was compiled using
the sifive_fu540_defconfig configuration and with U-Boot v2020.01, and up to -v2020.07-rc3.
+v2021.04. sifive_unleashed_defconfig shall be used with v2021.07 or

above.

Quoted 3 lines

```
make PLATFORM=sifive/fu540 FW_PAYLOAD_PATH=<u-

boot_build_dir>/u-

Quoted 12 lines

boot-dtb.bin

docs/platform/sifive_fu540.md +0 -0
@@ -153,11 +153,12 @@ This is because QEMU generates a device tree

blob on the fly based on the command line parameters and it's compatible with the one used in the upstream Linux kernel.

-When U-Boot v2020.01 (or higher) is used as the payload, as the SiFive
FU540

docs/platform/sifive_fu540.md +3 -0
+When U-Boot v2021.07 (or higher) is used as the payload, as the
+SiFive
+FU540
 DTB for the real hardware is embedded in U-Boot binary itself, due to
Quoted 3 lines

the same -reason above, we need to switch the U-Boot sifive_fu540_defconfig configuration -from **CONFIG_OF_SEPARATE** to **CONFIG_OF_PRIOR_STAGE** so that U-Boot uses the -DTB generated

by

docs/platform/sifive_fu540.md

Quoted 9 lines

QEMU, and u-boot.bin should be used as the payload image, like:

docs/platform/sifive_fu540.md +2 -0
+reason above, we need to switch the U-Boot sifive_unleashed_defconfig
+configuration from **CONFIG_OF_SEPARATE** to

**CONFIG_OF_PRIOR_STAGE**

docs/platform/sifive_fu540.md +2 -0
+so that U-Boot uses the DTB generated by QEMU, and u-boot.bin should
+be used as the payload image, like:
 
 ```
 make PLATFORM=sifive/fu540 FW_PAYLOAD_PATH=<u-

boot_build_dir>/u-

Quoted 9 lines

boot.bin
--
2.25.1

--
opensbi mailing list
opensbi at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi