Skip to contentSkip to conversation

bcache: add BLK_DEV dependency for BCACHE_NVM_PAGES

PATCH In review Arnd Bergmann 2 participants 2 messages Apr 21, 2021 bcache (block layer cache)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcache: add BLK_DEV dependency for BCACHE_NVM_PAGES

From: Arnd Bergmann <[email protected]>

Selecting this without CONFIG_BLK_DEV causes a Kconfig warning:

WARNING: unmet direct dependencies detected for LIBNVDIMM
Depends on [n]: PHYS_ADDR_T_64BIT [=y] && HAS_IOMEM [=y] && BLK_DEV [=n] Selected by [y]:
- BCACHE_NVM_PAGES [=y] && MD [=y] && BCACHE [=y] && PHYS_ADDR_T_64BIT [=y]

Add it as another dependency.

Fixes 688330711e9a ("bcache: initialize the nvm pages allocator")
---
 drivers/md/bcache/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/md/bcache/Kconfig +1 -0
index 0996e366ad0b..9cb3d8c39fc1 100644
@@ -40,6 +40,7 @@ config BCACHE_NVM_PAGES
 	bool "NVDIMM support for bcache (EXPERIMENTAL)"
 	depends on BCACHE
 	depends on PHYS_ADDR_T_64BIT
+	depends on BLKDEV
 	select LIBNVDIMM
 	select DAX
 	help
Signature · 1 line
2.29.2
#1 lore raw
Quoted 22 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Selecting this without CONFIG_BLK_DEV causes a Kconfig warning:

WARNING: unmet direct dependencies detected for LIBNVDIMM
Depends on [n]: PHYS_ADDR_T_64BIT [=y] && HAS_IOMEM [=y] && BLK_DEV [=n] Selected by [y]:
- BCACHE_NVM_PAGES [=y] && MD [=y] && BCACHE [=y] && PHYS_ADDR_T_64BIT [=y]

Add it as another dependency.

Fixes 688330711e9a ("bcache: initialize the nvm pages allocator")
---
 drivers/md/bcache/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/md/bcache/Kconfig +0 -0
index 0996e366ad0b..9cb3d8c39fc1 100644

drivers/md/bcache/Kconfig config BCACHE_NVM_PAGES · line 43

Quoted 4 lines
drivers/md/bcache/Kconfig +1 -0
@@ -40,6 +40,7 @@ config BCACHE_NVM_PAGES
 	bool "NVDIMM support for bcache (EXPERIMENTAL)"
 	depends on BCACHE
 	depends on PHYS_ADDR_T_64BIT
+	depends on BLKDEV

BLK_DEV

drivers/md/bcache/Kconfig config BCACHE_NVM_PAGES · line 46

Quoted 4 lines
drivers/md/bcache/Kconfig +0 -0
 	select LIBNVDIMM
 	select DAX
 	help

tested?

Signature · 1 line
~Randy