staging: media: atomisp: replace [pr|dev]_info() by dev_dbg()
Subsystems (4)
PATCH v2 1/1 staging: media: atomisp: replace [pr|dev]_info() by dev_dbg()
It is recommended to use driver model diagnostic macros dev_*() instead of pr_*() since the former ensures that the log messages are always associated with the corresponding device and driver. Also, using dev_dbg() is less log spamming as against dev_info().
Suggested-by Fabio Aiuto <[email protected]>
Signed-off-by Deepak R Varma <[email protected]>
---
Changes in v2:
- use dev_dbg() instead of dev_info(). Feedback from Hans Verkuil.
- update patch summary and description accordingly.
.../media/atomisp/i2c/atomisp-gc0310.c | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-)
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c +15 -15
@@ -300,7 +300,7 @@ static int gc0310_get_intg_factor(struct i2c_client *client,/* pixel clock calculattion */ dev->vt_pix_clk_freq_mhz =14400000 ;// 16.8MHz buf->vt_pix_clk_freq_mhz = dev->vt_pix_clk_freq_mhz; -pr_info ("vt_pix_clk_freq_mhz=%d\n" , buf->vt_pix_clk_freq_mhz); +dev_dbg (&client->dev,"vt_pix_clk_freq_mhz=%d\n" , buf->vt_pix_clk_freq_mhz);/* get integration time */ buf->coarse_integration_time_min =GC0310_COARSE_INTG_TIME_MIN ;
@@ -326,7 +326,7 @@ static int gc0310_get_intg_factor(struct i2c_client *client,if (ret)return ret; buf->crop_horizontal_start = val | (reg_val &0xFF ); -pr_info ("crop_horizontal_start=%d\n" , buf->crop_horizontal_start); +dev_dbg (&client->dev,"crop_horizontal_start=%d\n" , buf->crop_horizontal_start);/* Getting crop_vertical_start */ ret = gc0310_read_reg(client, GC0310_8BIT,
@@ -339,7 +339,7 @@ static int gc0310_get_intg_factor(struct i2c_client *client,if (ret)return ret; buf->crop_vertical_start = val | (reg_val &0xFF ); -pr_info ("crop_vertical_start=%d\n" , buf->crop_vertical_start); +dev_dbg (&client->dev,"crop_vertical_start=%d\n" , buf->crop_vertical_start);/* Getting output_width */ ret = gc0310_read_reg(client, GC0310_8BIT,
@@ -352,7 +352,7 @@ static int gc0310_get_intg_factor(struct i2c_client *client,if (ret)return ret; buf->output_width = val | (reg_val &0xFF ); -pr_info ("output_width=%d\n" , buf->output_width); +dev_dbg (&client->dev,"output_width=%d\n" , buf->output_width);/* Getting output_height */ ret = gc0310_read_reg(client, GC0310_8BIT,
@@ -365,12 +365,12 @@ static int gc0310_get_intg_factor(struct i2c_client *client,if (ret)return ret; buf->output_height = val | (reg_val &0xFF ); -pr_info ("output_height=%d\n" , buf->output_height); +dev_dbg (&client->dev,"output_height=%d\n" , buf->output_height); buf->crop_horizontal_end = buf->crop_horizontal_start + buf->output_width -1 ; buf->crop_vertical_end = buf->crop_vertical_start + buf->output_height -1 ; -pr_info ("crop_horizontal_end=%d\n" , buf->crop_horizontal_end); -pr_info ("crop_vertical_end=%d\n" , buf->crop_vertical_end); +dev_dbg (&client->dev,"crop_horizontal_end=%d\n" , buf->crop_horizontal_end); +dev_dbg (&client->dev,"crop_vertical_end=%d\n" , buf->crop_vertical_end);/* Getting line_length_pck */ ret = gc0310_read_reg(client, GC0310_8BIT,
@@ -389,7 +389,7 @@ static int gc0310_get_intg_factor(struct i2c_client *client,return ret; sh_delay = reg_val; buf->line_length_pck = buf->output_width + hori_blanking + sh_delay +4 ; -pr_info ("hori_blanking=%d sh_delay=%d line_length_pck=%d\n" , hori_blanking, +dev_dbg (&client->dev,"hori_blanking=%d sh_delay=%d line_length_pck=%d\n" , hori_blanking, sh_delay, buf->line_length_pck);/* Getting frame_length_lines */
@@ -404,7 +404,7 @@ static int gc0310_get_intg_factor(struct i2c_client *client,return ret; vert_blanking = val | (reg_val &0xFF ); buf->frame_length_lines = buf->output_height + vert_blanking; -pr_info ("vert_blanking=%d frame_length_lines=%d\n" , vert_blanking, +dev_dbg (&client->dev,"vert_blanking=%d frame_length_lines=%d\n" , vert_blanking, buf->frame_length_lines); buf->binning_factor_x = res->bin_factor_x ?
@@ -434,7 +434,7 @@ static int gc0310_set_gain(struct v4l2_subdev *sd, int gain) dgain = gain /2 ; } -pr_info ("gain=0x%x again=0x%x dgain=0x%x\n" , gain, again, dgain); +dev_dbg (&client->dev,"gain=0x%x again=0x%x dgain=0x%x\n" , gain, again, dgain);/* set analog gain */ ret = gc0310_write_reg(client, GC0310_8BIT,
@@ -458,7 +458,7 @@ static int __gc0310_set_exposure(struct v4l2_subdev *sd, int coarse_itg,struct i2c_client *client =v4l2_get_subdevdata (sd);int ret; -pr_info ("coarse_itg=%d gain=%d digitgain=%d\n" , coarse_itg, gain, digitgain); +dev_dbg (&client->dev,"coarse_itg=%d gain=%d digitgain=%d\n" , coarse_itg, gain, digitgain);/* set exposure */ ret = gc0310_write_reg(client, GC0310_8BIT,
@@ -1020,8 +1020,8 @@ static int gc0310_set_fmt(struct v4l2_subdev *sd,return -EINVAL ; } -dev_info (&client->dev,"%s: before gc0310_write_reg_array %s\n" , - __func__, gc0310_res[dev->fmt_idx].desc); +dev_dbg (&client->dev,"%s: before gc0310_write_reg_array %s\n" , + __func__, gc0310_res[dev->fmt_idx].desc); ret =startup (sd);if (ret) {dev_err (&client->dev,"gc0310 startup err\n" );
@@ -1085,7 +1085,7 @@ static int gc0310_detect(struct i2c_client *client)return -ENODEV ; } id = ((((u16 )high) <<8 ) | (u16 )low); -pr_info ("sensor ID = 0x%x\n" , id); +dev_dbg (&client->dev,"sensor ID = 0x%x\n" , id);if (id !=GC0310_ID ) { dev_err(&client->dev, "sensor ID error, read id = 0x%x, target id = 0x%x\n", id,
@@ -1106,7 +1106,7 @@ static int gc0310_s_stream(struct v4l2_subdev *sd, int enable)struct i2c_client *client =v4l2_get_subdevdata (sd);int ret; -pr_info ("%s S enable=%d\n" , __func__, enable); +dev_dbg (&client->dev,"%s S enable=%d\n" , __func__, enable);mutex_lock (&dev->input_lock);if (enable) {
Signature · 1 line
2.25.1