coding-style.rst: trivial: fix location of driver model macros
Subsystems (2)
PATCH 1/1 coding-style.rst: trivial: fix location of driver model macros
The dev_printk()-like functions moved to include/linux/dev_print.h in commit af628aae8640 ("device.h: move dev_printk()-like functions to dev_printk.h").
--- Documentation/process/coding-style.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/process/coding-style.rst +1 -1
@@ -855,7 +855,7 @@ Kernel messages do not have to be terminated with a period. Printing numbers in parentheses (%d) adds no value and should be avoided. -There are a number of driver model diagnostic macros in <linux/device.h> +There are a number of driver model diagnostic macros in <linux/dev_printk.h> which you should use to make sure messages are matched to the right device and driver, and are tagged with the right level: dev_err(), dev_warn(), dev_info(), and so forth. For messages that aren't associated with a
Signature · 1 line
2.30.0.rc0
Quoted 15 lines · Trevor Woerner
The dev_printk()-like functions moved to
include/linux/dev_print.hin commitaf628aae8640("device.h: move dev_printk()-like functions todev_printk.h").Signed-off-by Trevor Woerner <[email protected]>--- Documentation/process/coding-style.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/process/coding-style.rst +0
-0
Documentation/process/coding-style.rst Kernel messages do not have to be terminated with a period. · line 861
Quoted 8 lines
Documentation/process/coding-style.rst +1
-1@@ -855,7 +855,7 @@ Kernel messages do not have to be terminated with a period. Printing numbers in parentheses (%d) adds no value and should be avoided. -There are a number of driver model diagnostic macros in <linux/device.h> +There are a number of driver model diagnostic macros in <linux/dev_printk.h> which you should use to make sure messages are matched to the right device and driver, and are tagged with the right level: dev_err(), dev_warn(), dev_info(), and so forth. For messages that aren't associated with a
Looks good to me. Thanks for catching this.
thanks,
-- Shuah
Quoted 6 lines · Trevor Woerner
The dev_printk()-like functions moved to
include/linux/dev_print.hin commitaf628aae8640("device.h: move dev_printk()-like functions todev_printk.h").Signed-off-by Trevor Woerner <[email protected]>
LGTM
Cheers,
Miguel
A message that is not in the archive (sent off-list or not yet received): CAHUNapQfFBcqrX7MvUvq8qbPgk2bPu-h3+9NxAUFpRtpOGFODw@mail.gmail.com
Quoted 4 lines · Trevor Woerner
ping?
It doesn't look like this was picked up by trivial? Although, it doesn't look like
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.githas been used in a while. Is there an alternate (preferred) path for trivial patches?
Jonathan should be able to take it, or perhaps Andrew.
Note that you should put whoever should take it in the To field (I just noticed your original email did not) -- use scripts/get_maintainer.pl for getting the relevant people for a patch or path.
Cheers,
Miguel
Quoted 4 lines · Miguel Ojeda
Quoted 3 lines · Trevor Woerner
ping?
Quoted 8 lines
Quoted 1 line
It doesn't look like this was picked up by trivial? Although, it doesn't look like
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.githas been used in a while. Is there an alternate (preferred) path for trivial patches?Jonathan should be able to take it, or perhaps Andrew.
Note that you should put whoever should take it in the To field (I just noticed your original email did not) -- use
scripts/get_maintainer.plfor getting the relevant people for a patch or path.
Ah, good point. I have a "cccmd" line in my ~/.gitconfig for adding people to the CC when I "git send-email", maybe I should switch that to a "tocmd"?
get_maintainer.pl didn't add Andrew back then on my patch and still doesn't even now. Maybe the MAINTAINERS file needs an update if Andrew is to be included on trivial/documentation patches?
Quoted 4 lines · Trevor Woerner
get_maintainer.pl didn't add Andrew back then on my patch and still doesn't even now. Maybe the
MAINTAINERSfile needs an update if Andrew is to be included on trivial/documentation patches?
I mentioned Andrew because he does the hard job of being a backup for everything and everyone, but normally you should try to put the actual maintainer first in the To field and/or [email protected].
Cheers,
Miguel
Randy Dunlap
reviewerQuoted 9 lines · Miguel Ojeda
Quoted 4 lines · Trevor Woerner
get_maintainer.pl didn't add Andrew back then on my patch and still doesn't even now. Maybe the
MAINTAINERSfile needs an update if Andrew is to be included on trivial/documentation patches?I mentioned Andrew because he does the hard job of being a backup for everything and everyone, but normally you should try to put the actual maintainer first in the
Tofield and/or [email protected].
I think that we decided to stop using [email protected] for new patches a few months ago...
Signature · 1 line
~Randy
Quoted 7 lines · Randy Dunlap
Quoted 6 lines · Miguel Ojeda
Quoted 4 lines · Trevor Woerner
get_maintainer.pl didn't add Andrew back then on my patch and still doesn't even now. Maybe the
MAINTAINERSfile needs an update if Andrew is to be included on trivial/documentation patches?
Quoted 6 lines
Quoted 3 lines
I mentioned Andrew because he does the hard job of being a backup for everything and everyone, but normally you should try to put the actual maintainer first in the
Tofield and/or [email protected].I think that we decided to stop using [email protected] for new patches a few months ago...
Dunno who the "we" is but then maybe this is appropriate:
--- MAINTAINERS | 6 ------ 1 file changed, 6 deletions(-)
MAINTAINERS +0 -6
@@ -19282,12 +19282,6 @@ W: https://github.com/srcres258/linux-doc T: git git://github.com/srcres258/linux-doc.git doc-zh-tw F: Documentation/translations/zh_TW/ -TRIVIAL PATCHES -M: Jiri Kosina <[email protected]> -S: Maintained -T: git git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git -K: ^Subject:.*(?i)trivial - TTY LAYER M: Greg Kroah-Hartman <[email protected]> M: Jiri Slaby <[email protected]>
Quoted 28 lines · Joe Perches
Quoted 7 lines · Randy Dunlap
Quoted 6 lines · Miguel Ojeda
Quoted 4 lines · Trevor Woerner
get_maintainer.pl didn't add Andrew back then on my patch and still doesn't even now. Maybe the
MAINTAINERSfile needs an update if Andrew is to be included on trivial/documentation patches?Quoted 6 lines
Quoted 3 lines
I mentioned Andrew because he does the hard job of being a backup for everything and everyone, but normally you should try to put the actual maintainer first in the
Tofield and/or [email protected].I think that we decided to stop using [email protected] for new patches a few months ago...
Dunno who the "we" is but then maybe this is appropriate:
--- MAINTAINERS | 6 ------ 1 file changed, 6 deletions(-)MAINTAINERS +0
-0@@ -19282,12 +19282,6 @@ W: https://github.com/srcres258/linux-doc T: git git://github.com/srcres258/linux-doc.git doc-zh-tw F: Documentation/translations/zh_TW/
MAINTAINERS W: https://github.com/srcres258/linux-doc · line 19287
Quoted 10 lines
MAINTAINERS +0
-6-TRIVIAL PATCHES -M: Jiri Kosina <[email protected]> -S: Maintained -T: git git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git -K: ^Subject:.*(?i)trivial - TTY LAYER M: Greg Kroah-Hartman <[email protected]> M: Jiri Slaby <[email protected]>
Jiri?
thanks.
Signature · 1 line
~Randy
Quoted 3 lines · Randy Dunlap
I think that we decided to stop using [email protected] for new patches a few months ago...
Ah, good to know, thanks! Then we should update submitting-patches.rst at least.
Cheers,
Miguel
Quoted 3 lines · Trevor Woerner
Quoted 2 lines · Miguel Ojeda
Quoted 1 line · Trevor Woerner
ping?
[]
Quoted 7 lines
Quoted 4 lines
Note that you should put whoever should take it in the To field (I just noticed your original email did not) -- use
scripts/get_maintainer.plfor getting the relevant people for a patch or path.Ah, good point. I have a "cccmd" line in my ~/.gitconfig for adding people to the CC when I "git send-email", maybe I should switch that to a "tocmd"?
I use scripts for both.
Joe,
Quoted 10 lines · Joe Perches
Quoted 3 lines · Trevor Woerner
Quoted 2 lines · Miguel Ojeda
Quoted 1 line · Trevor Woerner
ping?
[]
Quoted 5 lines
Quoted 4 lines
Note that you should put whoever should take it in the To field (I just noticed your original email did not) -- use
scripts/get_maintainer.plfor getting the relevant people for a patch or path.
Quoted 6 lines
Quoted 2 lines
Ah, good point. I have a "cccmd" line in my ~/.gitconfig for adding people to the CC when I "git send-email", maybe I should switch that to a "tocmd"?
I use scripts for both.
That is awesome, thanks!
Jonathan Corbet
maintainerQuoted 6 lines · Trevor Woerner
ping?
It doesn't look like this was picked up by trivial? Although, it doesn't look like
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git
has been used in a while. Is there an alternate (preferred) path for trivial patches?
Hmm...no idea why I missed it the first time around. Applied now, apologies for the delay.
Thanks,
jon
Quoted 10 lines · Jonathan Corbet
Quoted 6 lines · Trevor Woerner
ping?
It doesn't look like this was picked up by trivial? Although, it doesn't look like
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git
has been used in a while. Is there an alternate (preferred) path for trivial patches?Hmm...no idea why I missed it the first time around. Applied now,
Maybe because I added you in the CC instead of TO? Sorry about that. Anyway, that's cleaned up now (thanks to Joe's scripts).
Quoted 2 lines
Applied now,
apologies for the delay.
Thanks!