Generate uevent on namespace AENs
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 Generate uevent on namespace AENs
From: Martin Belanger <[email protected]>
--- drivers/nvme/host/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/nvme/host/core.c +3 -1
@@ -1115,7 +1115,7 @@ EXPORT_SYMBOL_NS_GPL(nvme_execute_passthru_rq, NVME_TARGET_PASSTHRU);/* * Recommended frequency for KATO commands per NVMe 1.4 section 7.12.1: -* +* * The host should send Keep Alive commands at half of the Keep Alive Timeout * accounting for transport roundtrip times [..]. */
@@ -4133,6 +4133,7 @@ static void nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result)case NVME_AER_NOTICE_NS_CHANGED :set_bit (NVME_AER_NOTICE_NS_CHANGED , &ctrl->events);nvme_queue_scan (ctrl); + ctrl->aen_result = result;break ;case NVME_AER_NOTICE_FW_ACT_STARTING :/*
@@ -4148,6 +4149,7 @@ static void nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result)if (!ctrl->ana_log_buf)break ;queue_work (nvme_wq, &ctrl->ana_work); + ctrl->aen_result = result;break ;#endif case NVME_AER_NOTICE_DISC_CHANGED :
Signature · 7 lines
2.25.1 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 3 lines · Martin Belanger
From: Martin Belanger <[email protected]>
---
Please resend the patch with proper commit description.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Hi Chaitanya,
I'm sorry, but I'm not sure what you mean by "proper commit description". What is "improper" about the description I submitted.
Thanks,
Martin
________________________________________
From: Chaitanya Kulkarni <[email protected]>
Sent: Monday, April 26, 2021 22:34
To: Martin Belanger; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Belanger, Martin
Subject: Re: [PATCH 1/1] Generate uevent on namespace AENs
[EXTERNAL EMAIL]
Quoted 3 lines · Martin Belanger
From: Martin Belanger <[email protected]>
---
Please resend the patch with proper commit description.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 6 lines · Martin
Hi Chaitanya,
I'm sorry, but I'm not sure what you mean by "proper commit description". What is "improper" about the description I submitted.
Thanks,
Martin
Commit log is as important as functionality :-
1. There is no commit log in the patch but in the cover letter.
2. Subject line doesn't involve subsystem prefix.
That is "improper" from maintainer's point of view.
For more examples see the git log and kernel documentation.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keith Busch
maintainerQuoted 5 lines · Chaitanya Kulkarni
Quoted 4 lines · Martin
Hi Chaitanya,
I'm sorry, but I'm not sure what you mean by "proper commit description". What is "improper" about the description I submitted.
Quoted 7 lines
Quoted 2 lines
Thanks,
MartinCommit log is as important as functionality :-
1. There is no commit log in the patch but in the cover letter.
2. Subject line doesn't involve subsystem prefix.
Also need the author's "Signed-off-by:" tag on the commit.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 6 lines · Keith Busch
Quoted 5 lines · Chaitanya Kulkarni
Quoted 4 lines · Martin
Hi Chaitanya,
I'm sorry, but I'm not sure what you mean by "proper commit description". What is "improper" about the description I submitted.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Thanks,
MartinCommit log is as important as functionality :-
1. There is no commit log in the patch but in the cover letter.
2. Subject line doesn't involve subsystem prefix.Also need the author's "Signed-off-by:" tag on the commit.
True, you need to run checkpatch.pl and make sure to fix all the warnings.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme