Removed set but unused variables
cover Removed set but unused variables
Removed set but unused variables. Issue detected by gcc.
Fabio M. De Francesco (2):
staging: rtl8723bs: hal: Remove set but unused variables.
staging: rtl8723bs: core: Removed set but unused variable.
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 +--- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- 2 files changed, 1 insertion(+), 8 deletions(-)
Signature · 1 line
2.31.1
PATCH 1/2 staging: rtl8723bs: hal: Remove set but unused variables
Removed four set but unused variables. Issue detected by gcc.
--- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0 -5
@@ -3900,14 +3900,11 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, vu32 cmd;u32 ra_info1, ra_info2;u32 rate_mask1, rate_mask2; -u8 curr_tx_rate, curr_tx_sgi, hight_rate, lowest_rate; cmd =0x40000100 | mac_id;rtw_write32 (padapter,REG_HMEBOX_DBG_2_8723B , cmd);msleep (10 ); ra_info1 =rtw_read32 (padapter,0x2F0 ); - curr_tx_rate = ra_info1&0x7F ; - curr_tx_sgi = (ra_info1>>7 )&0x01 ; cmd =0x40000400 | mac_id;rtw_write32 (padapter,REG_HMEBOX_DBG_2_8723B , cmd);
@@ -3916,8 +3913,6 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v ra_info2 =rtw_read32 (padapter,0x2F4 ); rate_mask1 =rtw_read32 (padapter,0x2F8 ); rate_mask2 =rtw_read32 (padapter,0x2FC ); - hight_rate = ra_info2&0xFF ; - lowest_rate = (ra_info2>>8 ) &0xFF ; }break ;
Signature · 1 line
2.31.1
Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: hal: Remove set but unused variables
Hi Fabio,
Quoted 39 lines · Fabio M. De Francesco
Removed four set but unused variables. Issue detected by gcc.
Signed-off-by Fabio M. De Francesco <[email protected]>--- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- 1 file changed, 5 deletions(-)drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-5@@ -3900,14 +3900,11 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, vu32 cmd;u32 ra_info1, ra_info2;u32 rate_mask1, rate_mask2; -u8 curr_tx_rate, curr_tx_sgi, hight_rate, lowest_rate; cmd =0x40000100 | mac_id;rtw_write32 (padapter,REG_HMEBOX_DBG_2_8723B , cmd);msleep (10 ); ra_info1 =rtw_read32 (padapter,0x2F0 ); - curr_tx_rate = ra_info1&0x7F ; - curr_tx_sgi = (ra_info1>>7 )&0x01 ; cmd =0x40000400 | mac_id;rtw_write32 (padapter,REG_HMEBOX_DBG_2_8723B , cmd);@@ -3916,8 +3913,6 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v ra_info2 =rtw_read32 (padapter,0x2F4 ); rate_mask1 =rtw_read32 (padapter,0x2F8 ); rate_mask2 =rtw_read32 (padapter,0x2FC ); - hight_rate = ra_info2&0xFF ; - lowest_rate = (ra_info2>>8 ) &0xFF ; }break ;Signature · 1 line
2.31.1
rate_mask{1,2} and ra_info{1,2} seems to be unused as well.
thank you,
fabio
Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: hal: Remove set but unused variables
Quoted 5 lines · CEST Fabio Aiuto
Hi Fabio,
Quoted 2 lines · Fabio M. De Francesco
Removed four set but unused variables. Issue detected by gcc.
Quoted 8 lines
Quoted 8 lines
Signed-off-by Fabio M. De Francesco <[email protected]>---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- 1 file changed, 5 deletions(-)(quoted diff) +0
-0
b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.cindex
082448557b53..96cb4426a0f4
Quoted 4 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter,
Quoted 4 lines
100644
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3900,14 +3900,11 @@ u8 GetHalDefVar8723B(struct adapter *padapter,
enum
Quoted 6 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 6 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-1u32 cmd;u32 ra_info1, ra_info2;u32 rate_mask1, rate_mask2; - u8 curr_tx_rate, curr_tx_sgi, hight_rate,
lowest_rate;
Quoted 3 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 3 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000100 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);
Quoted 8 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 8 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2msleep (10 ); ra_info1 =rtw_read32 (padapter,0x2F0 ); - curr_tx_rate = ra_info1&0x7F ; - curr_tx_sgi = (ra_info1>>7 )&0x01 ; cmd =0x40000400 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);
Quoted 10 lines
Quoted 10 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3916,8 +3913,6 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2ra_info2 =rtw_read32 (padapter,0x2F4 ); rate_mask1 =rtw_read32 (padapter,0x2F8 ); rate_mask2 =rtw_read32 (padapter,0x2FC ); - hight_rate = ra_info2&0xFF ; - lowest_rate = (ra_info2>>8 ) &0xFF ;
Quoted 9 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0}break ;rate_mask{1,2} and ra_info{1,2} seems to be unused as well.
thank you,
fabio
Hello Fabio,
I'm not sure about it: rtw_read32 calls a pointer to a function. I'm don't know drivers programming, however that function looks like an implementation of a read() system call. So I wouldn't be so sure to remove those calls.
Could calling a (*read) method have side effects on subsequent read()? I mean:
could it update some internal data structure? If not I can remove the variables you mentioned above and the calls to read32.
I'm looking forward to read your reply.
Thanks,
Fabio
Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: hal: Remove set but unused variables
Quoted 69 lines · Fabio M. De Francesco
Quoted 5 lines · CEST Fabio Aiuto
Hi Fabio,
Quoted 2 lines · Fabio M. De Francesco
Removed four set but unused variables. Issue detected by gcc.
Quoted 8 lines
Quoted 8 lines
Signed-off-by Fabio M. De Francesco <[email protected]>---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- 1 file changed, 5 deletions(-)(quoted diff) +0
-0
b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.cindex
082448557b53..96cb4426a0f4Quoted 4 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter,
Quoted 4 lines
100644
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3900,14 +3900,11 @@ u8 GetHalDefVar8723B(struct adapter *padapter,enum
Quoted 6 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 6 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-1u32 cmd;u32 ra_info1, ra_info2;u32 rate_mask1, rate_mask2; - u8 curr_tx_rate, curr_tx_sgi, hight_rate,
lowest_rate;Quoted 3 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 3 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000100 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 8 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 8 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2msleep (10 ); ra_info1 =rtw_read32 (padapter,0x2F0 ); - curr_tx_rate = ra_info1&0x7F ; - curr_tx_sgi = (ra_info1>>7 )&0x01 ; cmd =0x40000400 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 10 lines
Quoted 10 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3916,8 +3913,6 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2ra_info2 =rtw_read32 (padapter,0x2F4 ); rate_mask1 =rtw_read32 (padapter,0x2F8 ); rate_mask2 =rtw_read32 (padapter,0x2FC ); - hight_rate = ra_info2&0xFF ; - lowest_rate = (ra_info2>>8 ) &0xFF ;Quoted 9 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0}break ;rate_mask{1,2} and ra_info{1,2} seems to be unused as well.
thank you,
fabio
Hello Fabio,
I'm not sure about it:
rtw_read32calls a pointer to a function. I'm don't know drivers programming, however that function looks like an implementation of aread()system call. So I wouldn't be so sure to remove those calls.Could calling a (*read) method have side effects on subsequent
read()? I mean:
could it update some internal data structure? If not I can remove the variables you mentioned above and the calls to read32.
Quoted 8 lines
I'm looking forward to read your reply.
Thanks,
Fabio
hi Fabio,
rtw_read32 is a macro wrapping _rtw_read32() defined as follows (in core/rtw_io.c):
u32 _rtw_read32(struct adapter *adapter, u32 addr)
{
u32 r_val;
/* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */
struct io_priv *pio_priv = &adapter->iopriv;
struct intf_hdl *pintfhdl = &(pio_priv->intf);
u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr);
_read32 = pintfhdl->io_ops._read32;
r_val = _read32(pintfhdl, addr);
return rtw_le32_to_cpu(r_val);}
the actual read seems to be performed by the handler contained in
pintfhdl->io_ops._read32;
so:
$ grep -r '\b_read32' drivers/staging/rtl8723bs/
drivers/staging/rtl8723bs/hal/sdio_ops.c: ops->_read32 = &sdio_read32;
this is the place where _read32 is stored with sdio_read32 reference...
drivers/staging/rtl8723bs/core/rtw_io.c: u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr);drivers/staging/rtl8723bs/core/rtw_io.c: _read32 = pintfhdl->io_ops._read32;
...
if you check it in hal/sdio_ops.c, nothing is written, just reads are performed (and it's not odd, for a read function isn't supposed to write something under the hood ;)).
I think those variables could be easily removed as W=1 gcc suggests.
thank you,
fabio
Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: hal: Remove set but unused variables
Quoted 46 lines · CEST Fabio Aiuto
Quoted 45 lines · Fabio M. De Francesco
Quoted 5 lines · CEST Fabio Aiuto
Hi Fabio,
Quoted 2 lines · Fabio M. De Francesco
Removed four set but unused variables. Issue detected by gcc.
Quoted 8 lines
Quoted 8 lines
Signed-off-by Fabio M. De Francesco <[email protected]>---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- 1 file changed, 5 deletions(-)(quoted diff) +0
-0
b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.cindex
082448557b53..96cb4426a0f4Quoted 4 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter,
Quoted 4 lines
100644
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3900,14 +3900,11 @@ u8 GetHalDefVar8723B(struct adapter *padapter,enum
Quoted 7 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 7 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-1u32 cmd;u32 ra_info1, ra_info2;u32 rate_mask1, rate_mask2; - u8 curr_tx_rate, curr_tx_sgi, hight_rate,
lowest_rate;Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000100 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 6 lines
Quoted 6 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2msleep (10 ); ra_info1 =rtw_read32 (padapter,0x2F0 ); - curr_tx_rate = ra_info1&0x7F ; - curr_tx_sgi = (ra_info1>>7 )&0x01 ;
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000400 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 1 line
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter,
Quoted 1 line
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3916,8 +3913,6 @@ u8 GetHalDefVar8723B(struct adapter *padapter,
enum
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v · line 3918
Quoted 11 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2ra_info2 =rtw_read32 (padapter,0x2F4 ); rate_mask1 =rtw_read32 (padapter,0x2F8 ); rate_mask2 =rtw_read32 (padapter,0x2FC ); - hight_rate = ra_info2&0xFF ; - lowest_rate = (ra_info2>>8 ) &0xFF ; }break ;rate_mask{1,2} and ra_info{1,2} seems to be unused as well.
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines
thank you,
fabio
Hello Fabio,
I'm not sure about it:
rtw_read32calls a pointer to a function. I'm don't know drivers programming, however that function looks like an
implementation
Quoted 3 lines
Quoted 3 lines
of a
read()system call. So I wouldn't be so sure to remove those calls.Could calling a (*read) method have side effects on subsequent
read()? I
mean:
Quoted 5 lines
Quoted 5 lines
could it update some internal data structure? If not I can remove the variables you mentioned above and the calls to read32.
I'm looking forward to read your reply.
Quoted 7 lines
Quoted 3 lines
Thanks,
Fabio
hi Fabio,
rtw_read32is a macro wrapping_rtw_read32()defined as follows (in core/
rtw_io.c):
Quoted 1 line
Hi Fabio,
Thanks a lot for your reply.
However, There is something less than clear to me... how did you find that rtw_read32 is a macro wrapping _rtw_read32()? I mean: I knew that, in vim, one can go to the definition of something by using ctrl-] key.
If I do that on rtw_read32 it takes me to a static definition of it in drivers/net/wireless/realtek/rtw88/hci.h. This is a one line function:
static inline void rtw_write32(struct rtw_dev *rtwdev, u32 addr, u32 val)
{
rtwdev->hci.ops->write32(rtwdev, addr, val);
}When I use ctrl-] on write32() it takes me to struct rtw_hci_ops in drivers/ net/wireless/realtek/rtw88/hci.h.
After that I wanted to find where the member (*read32)() is assigned but I don't know where and how to grep it: I tried "grep -rn "\bwrite32\b=" drivers/ staging/rtl8723bs/" but I found nothing...
Can you please explain what I'm doing wrong in following the path I mentioned above and how you find out that macro?
Thanks for your time,
Fabio
Quoted 18 lines
u32
_rtw_read32(struct adapter *adapter, u32 addr){ u32 r_val; /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */ struct io_priv *pio_priv = &adapter->iopriv; struct intf_hdl *pintfhdl = &(pio_priv->intf); u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr); _read32 = pintfhdl->io_ops._read32; r_val = _read32(pintfhdl, addr); return rtw_le32_to_cpu(r_val);}
the actual read seems to be performed by the handler contained in
Quoted 7 lines
pintfhdl->io_ops._read32;so:
$ grep -r '\b_read32' drivers/staging/rtl8723bs/
drivers/staging/rtl8723bs/hal/sdio_ops.c:ops->_read32=
&sdio_read32;
Quoted 4 lines
this is the place where
_read32is stored withsdio_read32reference...
drivers/staging/rtl8723bs/core/rtw_io.c: u32 (*_read32)(struct
intf_hdl *pintfhdl, u32
Quoted 13 lines
addr);
drivers/staging/rtl8723bs/core/rtw_io.c:_read32= pintfhdl-
io_ops._read32;
...if you check it in
hal/sdio_ops.c, nothing is written, just reads are performed (and it's not odd, for a read function isn't supposed to write something under the hood ;)).I think those variables could be easily removed as W=1 gcc suggests.
thank you,
fabio
Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: hal: Remove set but unused variables
Quoted 114 lines · Fabio M. De Francesco
Quoted 46 lines · CEST Fabio Aiuto
Quoted 45 lines · Fabio M. De Francesco
Quoted 5 lines · CEST Fabio Aiuto
Hi Fabio,
Quoted 2 lines · Fabio M. De Francesco
Removed four set but unused variables. Issue detected by gcc.
Quoted 8 lines
Quoted 8 lines
Signed-off-by Fabio M. De Francesco <[email protected]>---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- 1 file changed, 5 deletions(-)(quoted diff) +0
-0
b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.cindex
082448557b53..96cb4426a0f4Quoted 4 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter,
Quoted 4 lines
100644
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3900,14 +3900,11 @@ u8 GetHalDefVar8723B(struct adapter *padapter,enum
Quoted 7 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 7 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-1u32 cmd;u32 ra_info1, ra_info2;u32 rate_mask1, rate_mask2; - u8 curr_tx_rate, curr_tx_sgi, hight_rate,
lowest_rate;Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000100 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 6 lines
Quoted 6 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2msleep (10 ); ra_info1 =rtw_read32 (padapter,0x2F0 ); - curr_tx_rate = ra_info1&0x7F ; - curr_tx_sgi = (ra_info1>>7 )&0x01 ;Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000400 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 1 line
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter,
Quoted 1 line
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3916,8 +3913,6 @@ u8 GetHalDefVar8723B(struct adapter *padapter,enum
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v · line 3918
Quoted 11 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2ra_info2 =rtw_read32 (padapter,0x2F4 ); rate_mask1 =rtw_read32 (padapter,0x2F8 ); rate_mask2 =rtw_read32 (padapter,0x2FC ); - hight_rate = ra_info2&0xFF ; - lowest_rate = (ra_info2>>8 ) &0xFF ; }break ;rate_mask{1,2} and ra_info{1,2} seems to be unused as well.
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines
thank you,
fabio
Hello Fabio,
I'm not sure about it:
rtw_read32calls a pointer to a function. I'm don't know drivers programming, however that function looks like animplementation
Quoted 3 lines
Quoted 3 lines
of a
read()system call. So I wouldn't be so sure to remove those calls.Could calling a (*read) method have side effects on subsequent
read()? Imean:
Quoted 5 lines
Quoted 5 lines
could it update some internal data structure? If not I can remove the variables you mentioned above and the calls to read32.
I'm looking forward to read your reply.
Quoted 7 lines
Quoted 3 lines
Thanks,
Fabio
hi Fabio,
rtw_read32is a macro wrapping_rtw_read32()defined as follows (in core/
rtw_io.c):Quoted 1 line
Hi Fabio,
Thanks a lot for your reply.
However, There is something less than clear to me... how did you find that
rtw_read32is a macro wrapping_rtw_read32()? I mean: I knew that, in vim, one can go to the definition of something by using ctrl-] key.If I do that on
rtw_read32it takes me to a static definition of it indrivers/net/wireless/realtek/rtw88/hci.h. This is a one line function:static inline void
rtw_write32(struct rtw_dev *rtwdev, u32 addr, u32 val){ rtwdev->hci.ops->write32(rtwdev, addr, val); }When I use ctrl-] on
write32()it takes me to structrtw_hci_opsindrivers/net/wireless/realtek/rtw88/hci.h.
Quoted 6 lines
After that I wanted to find where the member (*read32)() is assigned but I don't know where and how to grep it: I tried "grep -rn "\bwrite32\b="
drivers/staging/rtl8723bs/" but I found nothing...Can you please explain what I'm doing wrong in following the path I mentioned above and how you find out that macro?
$grep -r 'define\s*\brtw_read32' drivers/staging/rtl8723bs/
it's a grep I always do to check if a function is actally a function or a macro..
Quoted 28 lines
Thanks for your time,
Fabio
Quoted 24 lines
u32
_rtw_read32(struct adapter *adapter, u32 addr){ u32 r_val; /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */ struct io_priv *pio_priv = &adapter->iopriv; struct intf_hdl *pintfhdl = &(pio_priv->intf); u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr); _read32 = pintfhdl->io_ops._read32; r_val = _read32(pintfhdl, addr); return rtw_le32_to_cpu(r_val);}
the actual read seems to be performed by the handler contained in
pintfhdl->io_ops._read32;so:
$ grep -r '\b_read32' drivers/staging/rtl8723bs/
Quoted 24 lines
Quoted 1 line
drivers/staging/rtl8723bs/hal/sdio_ops.c:ops->_read32=
&sdio_read32;Quoted 4 lines
this is the place where
_read32is stored withsdio_read32reference...
drivers/staging/rtl8723bs/core/rtw_io.c: u32 (*_read32)(struct
intf_hdl*pintfhdl, u32Quoted 13 lines
addr);
drivers/staging/rtl8723bs/core/rtw_io.c:_read32= pintfhdl-
io_ops._read32;
...if you check it in
hal/sdio_ops.c, nothing is written, just reads are performed (and it's not odd, for a read function isn't supposed to write something under the hood ;)).I think those variables could be easily removed as W=1 gcc suggests.
thank you,
fabio
thanks,
fabio
Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: hal: Remove set but unused variables
Quoted 7 lines · CEST Fabio Aiuto
Quoted 6 lines · Fabio M. De Francesco
Quoted 5 lines · CEST Fabio Aiuto
Quoted 4 lines · Fabio M. De Francesco
Quoted 3 lines · CEST Fabio Aiuto
Hi Fabio,
On Wed, Apr 28, 2021 at 01:33:45PM +0200, Fabio M. De Francesco
Quoted 13 lines · wrote:
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 10 lines
Quoted 10 lines
Removed four set but unused variables. Issue detected by gcc.
Signed-off-by Fabio M. De Francesco <[email protected]>---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- 1 file changed, 5 deletions(-)(quoted diff) +0
-0
b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.cindex
082448557b53..96cb4426a0f4
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter
Quoted 4 lines
100644
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3900,14 +3900,11 @@ u8 GetHalDefVar8723B(struct adapter
*padapter,
Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
enum
Quoted 7 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 7 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-1u32 cmd;u32 ra_info1, ra_info2;u32 rate_mask1, rate_mask2; - u8 curr_tx_rate, curr_tx_sgi, hight_rate,
lowest_rate;Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000100 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 6 lines
Quoted 6 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2msleep (10 ); ra_info1 =rtw_read32 (padapter,0x2F0 ); - curr_tx_rate = ra_info1&0x7F ; - curr_tx_sgi = (ra_info1>>7 )&0x01 ;
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000400 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 1 line
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter
Quoted 1 line
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3916,8 +3913,6 @@ u8 GetHalDefVar8723B(struct adapter
*padapter,
Quoted 17 lines
Quoted 17 lines
enum
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v · line 3918
Quoted 11 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2ra_info2 =rtw_read32 (padapter,0x2F4 ); rate_mask1 =rtw_read32 (padapter,0x2F8 ); rate_mask2 =rtw_read32 (padapter,0x2FC ); - hight_rate = ra_info2&0xFF ; - lowest_rate = (ra_info2>>8 ) &0xFF ; }break ;rate_mask{1,2} and ra_info{1,2} seems to be unused as well.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
thank you,
fabio
Hello Fabio,
I'm not sure about it:
rtw_read32calls a pointer to a function. I'm
don't
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
Quoted 1 line
know drivers programming, however that function looks like an
implementation
Quoted 1 line
Quoted 1 line
of a
read()system call. So I wouldn't be so sure to remove those
calls.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Could calling a (*read) method have side effects on subsequent
read()?
I
Quoted 7 lines
Quoted 7 lines
mean:
Quoted 5 lines
Quoted 5 lines
could it update some internal data structure? If not I can remove the variables you mentioned above and the calls to read32.
I'm looking forward to read your reply.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Thanks,
Fabio
hi Fabio,
rtw_read32is a macro wrapping_rtw_read32()defined as follows (in
core/
Quoted 9 lines
Quoted 9 lines
rtw_io.c):Hi Fabio,
Thanks a lot for your reply.
However, There is something less than clear to me... how did you find that
rtw_read32is a macro wrapping_rtw_read32()? I mean: I knew that, in vim,
one
Quoted 5 lines
Quoted 5 lines
can go to the definition of something by using ctrl-] key.
If I do that on
rtw_read32it takes me to a static definition of it indrivers/net/wireless/realtek/rtw88/hci.h. This is a one line function:
Quoted 8 lines
Quoted 8 lines
static inline void
rtw_write32(struct rtw_dev *rtwdev, u32 addr, u32 val){rtwdev->hci.ops->write32(rtwdev, addr, val);}
When I use ctrl-] on
write32()it takes me to structrtw_hci_opsin
drivers/
Quoted 4 lines
Quoted 4 lines
net/wireless/realtek/rtw88/hci.h.After that I wanted to find where the member (*read32)() is assigned but I don't know where and how to grep it: I tried "grep -rn "\bwrite32\b="
drivers/
Quoted 3 lines
Quoted 3 lines
staging/rtl8723bs/" but I found nothing...
Can you please explain what I'm doing wrong in following the path I
mentioned
Quoted 4 lines
Quoted 1 line
above and how you find out that macro?
$grep -r 'define\s*\brtw_read32'
drivers/staging/rtl8723bs/
Really interesting... does it imply that ctrl-] is broken? Or, does it just imply that I should use ctrl-] *if_and_only_if* the the command you showed above outputs nothing?
I think that automated finding of definitions is a fundamental tool, so I'd like to understand, in general, what are the steps and in which order they should be carried out. I'd really appreciate if you can list all the necessary steps. Other newcomers would benefit from that, IMO.
Apart the above question, I'm going to remove the other unused variables and add a Suggested-by in v2.
Thanks again,
Fabio
Quoted 63 lines
it's a grep I always do to check if a function is actually a function or a macro..
Quoted 32 lines
Thanks for your time,
Fabio
Quoted 20 lines
u32
_rtw_read32(struct adapter *adapter, u32 addr){u32 r_val; /* struct io_queue *pio_queue = (struct io_queue*)adapter->pio_queue; */ struct
io_priv*pio_priv=&adapter->iopriv;struct intf_hdl *pintfhdl = &(pio_priv->intf); u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr); _read32 = pintfhdl->io_ops._read32; r_val = _read32(pintfhdl, addr); return rtw_le32_to_cpu(r_val);}
the actual read seems to be performed by the handler contained in
Quoted 7 lines
pintfhdl->io_ops._read32;so:
$ grep -r '\b_read32' drivers/staging/rtl8723bs/
drivers/staging/rtl8723bs/hal/sdio_ops.c:ops->_read32=Quoted 23 lines
&sdio_read32;Quoted 3 lines
this is the place where
_read32is stored withsdio_read32reference...
drivers/staging/rtl8723bs/core/rtw_io.c: u32 (*_read32)(struct
intf_hdl*pintfhdl, u32Quoted 15 lines
addr);
drivers/staging/rtl8723bs/core/rtw_io.c:_read32= pintfhdl-io_ops._read32;
...
if you check it in
hal/sdio_ops.c, nothing is written, just reads are performed (and it's not odd, for a read function isn't supposed to write something under the hood ;)).I think those variables could be easily removed as W=1 gcc suggests.
thank you,
fabio
thanks,
fabio
Greg Kroah-Hartman
maintainerRe: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: hal: Remove set but unused variables
In reply to Fabio AiutoQuoted 110 lines · Fabio Aiuto
Quoted 69 lines · Fabio M. De Francesco
Quoted 5 lines · CEST Fabio Aiuto
Hi Fabio,
Quoted 2 lines · Fabio M. De Francesco
Removed four set but unused variables. Issue detected by gcc.
Quoted 8 lines
Quoted 8 lines
Signed-off-by Fabio M. De Francesco <[email protected]>---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- 1 file changed, 5 deletions(-)(quoted diff) +0
-0
b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.cindex
082448557b53..96cb4426a0f4Quoted 4 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter,
Quoted 4 lines
100644
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3900,14 +3900,11 @@ u8 GetHalDefVar8723B(struct adapter *padapter,enum
Quoted 6 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 6 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-1u32 cmd;u32 ra_info1, ra_info2;u32 rate_mask1, rate_mask2; - u8 curr_tx_rate, curr_tx_sgi, hight_rate,
lowest_rate;Quoted 3 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 3 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000100 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 8 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 8 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2msleep (10 ); ra_info1 =rtw_read32 (padapter,0x2F0 ); - curr_tx_rate = ra_info1&0x7F ; - curr_tx_sgi = (ra_info1>>7 )&0x01 ; cmd =0x40000400 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 10 lines
Quoted 10 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3916,8 +3913,6 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2ra_info2 =rtw_read32 (padapter,0x2F4 ); rate_mask1 =rtw_read32 (padapter,0x2F8 ); rate_mask2 =rtw_read32 (padapter,0x2FC ); - hight_rate = ra_info2&0xFF ; - lowest_rate = (ra_info2>>8 ) &0xFF ;Quoted 9 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0}break ;rate_mask{1,2} and ra_info{1,2} seems to be unused as well.
thank you,
fabio
Hello Fabio,
I'm not sure about it:
rtw_read32calls a pointer to a function. I'm don't know drivers programming, however that function looks like an implementation of aread()system call. So I wouldn't be so sure to remove those calls.Could calling a (*read) method have side effects on subsequent
read()? I mean:
could it update some internal data structure? If not I can remove the variables you mentioned above and the calls to read32.Quoted 8 lines
I'm looking forward to read your reply.
Thanks,
Fabio
hi Fabio,
rtw_read32is a macro wrapping_rtw_read32()defined as follows (incore/rtw_io.c):u32
_rtw_read32(struct adapter *adapter, u32 addr){ u32 r_val; /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */ struct io_priv *pio_priv = &adapter->iopriv; struct intf_hdl *pintfhdl = &(pio_priv->intf); u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr); _read32 = pintfhdl->io_ops._read32; r_val = _read32(pintfhdl, addr); return rtw_le32_to_cpu(r_val);}
the actual read seems to be performed by the handler contained in
pintfhdl->io_ops._read32;so:
$ grep -r '\b_read32' drivers/staging/rtl8723bs/
drivers/staging/rtl8723bs/hal/sdio_ops.c:ops->_read32=&sdio_read32;this is the place where
_read32is stored withsdio_read32reference...
Quoted 7 lines
drivers/staging/rtl8723bs/core/rtw_io.c: u32 (*_read32)(structintf_hdl*pintfhdl, u32 addr);drivers/staging/rtl8723bs/core/rtw_io.c:_read32=pintfhdl->io_ops._read32;
...if you check it in
hal/sdio_ops.c, nothing is written, just reads are performed (and it's not odd, for a read function isn't supposed to write something under the hood ;)).
Yes, but many types of hardware _REQUIRE_ reads to do something. So "read that does nothing" is a requirement for some operations.
As an example, a write is only guaranteed to have been finished if you do a read of the same location back from it on some hardware busses. The bus can reorder things, but a write/read of the same location can not be reordered.
Sometimes you have to do reads multiple times to get things to "stick".
Other times reading from a location changes a state in the hardware (horrid but HW designers aren't the brightest at times...)
So you can NOT just remove reads without knowing that the hardware does not require this. This is an issue where GCC "warnings" mean nothing as gcc does not actually know what hardware does, or does not, do for many things.
thanks,
greg k-h
Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: hal: Remove set but unused variables
Quoted 19 lines · CEST Greg Kroah-Hartman
Quoted 18 lines · Fabio Aiuto
Quoted 17 lines · Fabio M. De Francesco
Quoted 5 lines · CEST Fabio Aiuto
Hi Fabio,
Quoted 2 lines · Fabio M. De Francesco
Removed four set but unused variables. Issue detected by gcc.
Quoted 8 lines
Quoted 8 lines
Signed-off-by Fabio M. De Francesco <[email protected]>---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- 1 file changed, 5 deletions(-)(quoted diff) +0
-0
b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.cindex
082448557b53..96cb4426a0f4
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter
Quoted 4 lines
100644
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3900,14 +3900,11 @@ u8 GetHalDefVar8723B(struct adapter
*padapter,
Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
enum
Quoted 7 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 7 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-1u32 cmd;u32 ra_info1, ra_info2;u32 rate_mask1, rate_mask2; - u8 curr_tx_rate, curr_tx_sgi, hight_rate,
lowest_rate;Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000100 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 6 lines
Quoted 6 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2msleep (10 ); ra_info1 =rtw_read32 (padapter,0x2F0 ); - curr_tx_rate = ra_info1&0x7F ; - curr_tx_sgi = (ra_info1>>7 )&0x01 ;
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000400 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 1 line
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter,
Quoted 1 line
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3916,8 +3913,6 @@ u8 GetHalDefVar8723B(struct adapter *padapter,
enum
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v · line 3918
Quoted 11 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2ra_info2 =rtw_read32 (padapter,0x2F4 ); rate_mask1 =rtw_read32 (padapter,0x2F8 ); rate_mask2 =rtw_read32 (padapter,0x2FC ); - hight_rate = ra_info2&0xFF ; - lowest_rate = (ra_info2>>8 ) &0xFF ; }break ;rate_mask{1,2} and ra_info{1,2} seems to be unused as well.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
thank you,
fabio
Hello Fabio,
I'm not sure about it:
rtw_read32calls a pointer to a function. I'm
don't
Quoted 1 line
Quoted 1 line
Quoted 1 line
know drivers programming, however that function looks like an
implementation
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
of a
read()system call. So I wouldn't be so sure to remove those calls.Could calling a (*read) method have side effects on subsequent
read()? I
mean:
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
could it update some internal data structure? If not I can remove the variables you mentioned above and the calls to read32.
I'm looking forward to read your reply.
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Thanks,
Fabio
hi Fabio,
rtw_read32is a macro wrapping_rtw_read32()defined as follows (in core/
rtw_io.c):
Quoted 20 lines
Quoted 20 lines
u32
_rtw_read32(struct adapter *adapter, u32 addr){u32 r_val; /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */ struct io_priv *pio_priv = &adapter->iopriv; struct intf_hdl *pintfhdl = &(pio_priv->intf); u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr); _read32 = pintfhdl->io_ops._read32; r_val = _read32(pintfhdl, addr); return rtw_le32_to_cpu(r_val);}
the actual read seems to be performed by the handler contained in
Quoted 7 lines
Quoted 7 lines
pintfhdl->io_ops._read32;so:
$ grep -r '\b_read32' drivers/staging/rtl8723bs/
drivers/staging/rtl8723bs/hal/sdio_ops.c:ops->_read32=
&sdio_read32;
Quoted 4 lines
Quoted 4 lines
this is the place where
_read32is stored withsdio_read32reference...
drivers/staging/rtl8723bs/core/rtw_io.c: u32 (*_read32)(struct
intf_hdl *pintfhdl, u32
Quoted 21 lines
Quoted 1 line
addr);
drivers/staging/rtl8723bs/core/rtw_io.c:_read32= pintfhdl-io_ops._read32;
Quoted 5 lines
...
if you check it in
hal/sdio_ops.c, nothing is written, just reads are performed (and it's not odd, for a read function isn't supposed to write something under the hood ;)).Yes, but many types of hardware _REQUIRE_ reads to do something. So "read that does nothing" is a requirement for some operations.
As an example, a write is only guaranteed to have been finished if you do a read of the same location back from it on some hardware busses. The bus can reorder things, but a write/read of the same location can not be reordered.
Sometimes you have to do reads multiple times to get things to "stick".
Other times reading from a location changes a state in the hardware (horrid but HW designers aren't the brightest at times...)
Quoted 9 lines
So you can NOT just remove reads without knowing that the hardware does not require this. This is an issue where GCC "warnings" mean nothing as gcc does not actually know what hardware does, or does not, do for many things.
thanks,
greg k-h
Just to be sure... does it mean that v1 can be applied as-is?
Thanks,
Fabio
Greg Kroah-Hartman
maintainerRe: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: hal: Remove set but unused variables
Quoted 156 lines · Fabio M. De Francesco
Quoted 19 lines · CEST Greg Kroah-Hartman
Quoted 18 lines · Fabio Aiuto
Quoted 17 lines · Fabio M. De Francesco
Quoted 5 lines · CEST Fabio Aiuto
Hi Fabio,
Quoted 2 lines · Fabio M. De Francesco
Removed four set but unused variables. Issue detected by gcc.
Quoted 8 lines
Quoted 8 lines
Signed-off-by Fabio M. De Francesco <[email protected]>---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- 1 file changed, 5 deletions(-)(quoted diff) +0
-0
b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.cindex
082448557b53..96cb4426a0f4Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter
Quoted 4 lines
100644
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3900,14 +3900,11 @@ u8 GetHalDefVar8723B(struct adapter*padapter,
Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
enum
Quoted 7 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 7 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-1u32 cmd;u32 ra_info1, ra_info2;u32 rate_mask1, rate_mask2; - u8 curr_tx_rate, curr_tx_sgi, hight_rate,
lowest_rate;Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000100 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 6 lines
Quoted 6 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2msleep (10 ); ra_info1 =rtw_read32 (padapter,0x2F0 ); - curr_tx_rate = ra_info1&0x7F ; - curr_tx_sgi = (ra_info1>>7 )&0x01 ;Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000400 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 1 line
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter,
Quoted 1 line
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3916,8 +3913,6 @@ u8 GetHalDefVar8723B(struct adapter *padapter,enum
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v · line 3918
Quoted 11 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2ra_info2 =rtw_read32 (padapter,0x2F4 ); rate_mask1 =rtw_read32 (padapter,0x2F8 ); rate_mask2 =rtw_read32 (padapter,0x2FC ); - hight_rate = ra_info2&0xFF ; - lowest_rate = (ra_info2>>8 ) &0xFF ; }break ;rate_mask{1,2} and ra_info{1,2} seems to be unused as well.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
thank you,
fabio
Hello Fabio,
I'm not sure about it:
rtw_read32calls a pointer to a function. I'mdon't
Quoted 1 line
Quoted 1 line
Quoted 1 line
know drivers programming, however that function looks like an
implementation
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
of a
read()system call. So I wouldn't be so sure to remove those calls.Could calling a (*read) method have side effects on subsequent
read()? Imean:
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
could it update some internal data structure? If not I can remove the variables you mentioned above and the calls to read32.
I'm looking forward to read your reply.
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Thanks,
Fabio
hi Fabio,
rtw_read32is a macro wrapping_rtw_read32()defined as follows (in core/
rtw_io.c):Quoted 20 lines
Quoted 20 lines
u32
_rtw_read32(struct adapter *adapter, u32 addr){u32 r_val; /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */ struct io_priv *pio_priv = &adapter->iopriv; struct intf_hdl *pintfhdl = &(pio_priv->intf); u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr); _read32 = pintfhdl->io_ops._read32; r_val = _read32(pintfhdl, addr); return rtw_le32_to_cpu(r_val);}
the actual read seems to be performed by the handler contained in
Quoted 7 lines
Quoted 7 lines
pintfhdl->io_ops._read32;so:
$ grep -r '\b_read32' drivers/staging/rtl8723bs/
drivers/staging/rtl8723bs/hal/sdio_ops.c:ops->_read32=
&sdio_read32;Quoted 4 lines
Quoted 4 lines
this is the place where
_read32is stored withsdio_read32reference...
drivers/staging/rtl8723bs/core/rtw_io.c: u32 (*_read32)(struct
intf_hdl*pintfhdl, u32Quoted 26 lines
Quoted 1 line
addr);
drivers/staging/rtl8723bs/core/rtw_io.c:_read32= pintfhdl-io_ops._read32;
Quoted 5 lines
...
if you check it in
hal/sdio_ops.c, nothing is written, just reads are performed (and it's not odd, for a read function isn't supposed to write something under the hood ;)).Yes, but many types of hardware _REQUIRE_ reads to do something. So "read that does nothing" is a requirement for some operations.
As an example, a write is only guaranteed to have been finished if you do a read of the same location back from it on some hardware busses. The bus can reorder things, but a write/read of the same location can not be reordered.
Sometimes you have to do reads multiple times to get things to "stick".
Other times reading from a location changes a state in the hardware (horrid but HW designers aren't the brightest at times...)
So you can NOT just remove reads without knowing that the hardware does not require this. This is an issue where GCC "warnings" mean nothing as gcc does not actually know what hardware does, or does not, do for many things.
Quoted 5 lines
Quoted 4 lines
thanks,
greg k-h
Just to be sure... does it mean that v1 can be applied as-is?
I will review it when I get the time...
thanks,
greg k-h
Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: hal: Remove set but unused variables
In reply to Greg Kroah-HartmanQuoted 132 lines · Greg Kroah-Hartman
Quoted 110 lines · Fabio Aiuto
Quoted 69 lines · Fabio M. De Francesco
Quoted 5 lines · CEST Fabio Aiuto
Hi Fabio,
Quoted 2 lines · Fabio M. De Francesco
Removed four set but unused variables. Issue detected by gcc.
Quoted 8 lines
Quoted 8 lines
Signed-off-by Fabio M. De Francesco <[email protected]>---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- 1 file changed, 5 deletions(-)(quoted diff) +0
-0
b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.cindex
082448557b53..96cb4426a0f4Quoted 4 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter,
Quoted 4 lines
100644
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3900,14 +3900,11 @@ u8 GetHalDefVar8723B(struct adapter *padapter,enum
Quoted 6 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 6 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-1u32 cmd;u32 ra_info1, ra_info2;u32 rate_mask1, rate_mask2; - u8 curr_tx_rate, curr_tx_sgi, hight_rate,
lowest_rate;Quoted 3 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 3 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000100 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 8 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 8 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2msleep (10 ); ra_info1 =rtw_read32 (padapter,0x2F0 ); - curr_tx_rate = ra_info1&0x7F ; - curr_tx_sgi = (ra_info1>>7 )&0x01 ; cmd =0x40000400 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 10 lines
Quoted 10 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3916,8 +3913,6 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2ra_info2 =rtw_read32 (padapter,0x2F4 ); rate_mask1 =rtw_read32 (padapter,0x2F8 ); rate_mask2 =rtw_read32 (padapter,0x2FC ); - hight_rate = ra_info2&0xFF ; - lowest_rate = (ra_info2>>8 ) &0xFF ;Quoted 9 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0}break ;rate_mask{1,2} and ra_info{1,2} seems to be unused as well.
thank you,
fabio
Hello Fabio,
I'm not sure about it:
rtw_read32calls a pointer to a function. I'm don't know drivers programming, however that function looks like an implementation of aread()system call. So I wouldn't be so sure to remove those calls.Could calling a (*read) method have side effects on subsequent
read()? I mean:
could it update some internal data structure? If not I can remove the variables you mentioned above and the calls to read32.Quoted 8 lines
I'm looking forward to read your reply.
Thanks,
Fabio
hi Fabio,
rtw_read32is a macro wrapping_rtw_read32()defined as follows (incore/rtw_io.c):u32
_rtw_read32(struct adapter *adapter, u32 addr){ u32 r_val; /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */ struct io_priv *pio_priv = &adapter->iopriv; struct intf_hdl *pintfhdl = &(pio_priv->intf); u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr); _read32 = pintfhdl->io_ops._read32; r_val = _read32(pintfhdl, addr); return rtw_le32_to_cpu(r_val);}
the actual read seems to be performed by the handler contained in
pintfhdl->io_ops._read32;so:
$ grep -r '\b_read32' drivers/staging/rtl8723bs/
drivers/staging/rtl8723bs/hal/sdio_ops.c:ops->_read32=&sdio_read32;this is the place where
_read32is stored withsdio_read32reference...Quoted 7 lines
drivers/staging/rtl8723bs/core/rtw_io.c: u32 (*_read32)(structintf_hdl*pintfhdl, u32 addr);drivers/staging/rtl8723bs/core/rtw_io.c:_read32=pintfhdl->io_ops._read32;
...if you check it in
hal/sdio_ops.c, nothing is written, just reads are performed (and it's not odd, for a read function isn't supposed to write something under the hood ;)).Yes, but many types of hardware _REQUIRE_ reads to do something. So "read that does nothing" is a requirement for some operations.
As an example, a write is only guaranteed to have been finished if you do a read of the same location back from it on some hardware busses. The bus can reorder things, but a write/read of the same location can not be reordered.
Sometimes you have to do reads multiple times to get things to "stick".
Other times reading from a location changes a state in the hardware (horrid but HW designers aren't the brightest at times...)
Quoted 8 lines
So you can NOT just remove reads without knowing that the hardware does not require this. This is an issue where GCC "warnings" mean nothing as gcc does not actually know what hardware does, or does not, do for many things.
thanks,
greg k-h
thank you for explanation, my hardware knowledge is poor:( Sorry for noise.
fabio
Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: hal: Remove set but unused variables
Quoted 7 lines · CEST Fabio Aiuto
Quoted 6 lines · Greg Kroah-Hartman
Quoted 5 lines · Fabio Aiuto
Quoted 4 lines · Fabio M. De Francesco
Quoted 3 lines · CEST Fabio Aiuto
Hi Fabio,
On Wed, Apr 28, 2021 at 01:33:45PM +0200, Fabio M. De Francesco
Quoted 13 lines · wrote:
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 10 lines
Quoted 10 lines
Removed four set but unused variables. Issue detected by gcc.
Signed-off-by Fabio M. De Francesco <[email protected]>---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- 1 file changed, 5 deletions(-)(quoted diff) +0
-0
b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.cindex
082448557b53..96cb4426a0f4
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter
Quoted 4 lines
100644
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3900,14 +3900,11 @@ u8 GetHalDefVar8723B(struct adapter
*padapter,
Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
enum
Quoted 7 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v
Quoted 7 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-1u32 cmd;u32 ra_info1, ra_info2;u32 rate_mask1, rate_mask2; - u8 curr_tx_rate, curr_tx_sgi, hight_rate,
lowest_rate;Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000100 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 6 lines
Quoted 6 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2msleep (10 ); ra_info1 =rtw_read32 (padapter,0x2F0 ); - curr_tx_rate = ra_info1&0x7F ; - curr_tx_sgi = (ra_info1>>7 )&0x01 ;
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Quoted 2 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0cmd =0x40000400 | mac_id; rtw_write32(padapter,
REG_HMEBOX_DBG_2_8723B, cmd);Quoted 1 line
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter
Quoted 1 line
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-0@@ -3916,8 +3913,6 @@ u8 GetHalDefVar8723B(struct adapter
*padapter, enum
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c u8 GetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable variable, v · line 3918
Quoted 11 lines
hal_def_variablevariable, v>drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0
-2ra_info2 =rtw_read32 (padapter,0x2F4 ); rate_mask1 =rtw_read32 (padapter,0x2F8 ); rate_mask2 =rtw_read32 (padapter,0x2FC ); - hight_rate = ra_info2&0xFF ; - lowest_rate = (ra_info2>>8 ) &0xFF ; }break ;rate_mask{1,2} and ra_info{1,2} seems to be unused as well.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
thank you,
fabio
Hello Fabio,
I'm not sure about it:
rtw_read32calls a pointer to a function. I'm
don't
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
know drivers programming, however that function looks like an
implementation
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
of a
read()system call. So I wouldn't be so sure to remove those
calls.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Could calling a (*read) method have side effects on subsequent
read()?
I mean:
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
could it update some internal data structure? If not I can remove the variables you mentioned above and the calls to read32.
I'm looking forward to read your reply.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Thanks,
Fabio
hi Fabio,
rtw_read32is a macro wrapping_rtw_read32()defined as follows (in
core/rtw_io.c):
Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
u32
_rtw_read32(struct adapter *adapter, u32 addr){u32 r_val; /* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */ struct io_priv *pio_priv = &adapter->iopriv; struct intf_hdl *pintfhdl = &(pio_priv->intf); u32 (*_read32)(struct intf_hdl *pintfhdl, u32 addr); _read32 = pintfhdl->io_ops._read32; r_val = _read32(pintfhdl, addr); return rtw_le32_to_cpu(r_val);}
the actual read seems to be performed by the handler contained in
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
pintfhdl->io_ops._read32;so:
$ grep -r '\b_read32' drivers/staging/rtl8723bs/
drivers/staging/rtl8723bs/hal/sdio_ops.c:ops->_read32=
&sdio_read32;
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
this is the place where
_read32is stored withsdio_read32reference...
drivers/staging/rtl8723bs/core/rtw_io.c: u32 (*_read32)(struct
intf_hdl *pintfhdl,
Quoted 26 lines
Quoted 26 lines
Quoted 7 lines
u32 addr);
drivers/staging/rtl8723bs/core/rtw_io.c:_read32=pintfhdl->io_ops._read32;
...if you check it in
hal/sdio_ops.c, nothing is written, just reads are performed (and it's not odd, for a read function isn't supposed to write something under the hood ;)).Yes, but many types of hardware _REQUIRE_ reads to do something. So "read that does nothing" is a requirement for some operations.
As an example, a write is only guaranteed to have been finished if you do a read of the same location back from it on some hardware busses. The bus can reorder things, but a write/read of the same location can not be reordered.
Sometimes you have to do reads multiple times to get things to "stick".
Other times reading from a location changes a state in the hardware (horrid but HW designers aren't the brightest at times...)
So you can NOT just remove reads without knowing that the hardware does not require this. This is an issue where GCC "warnings" mean nothing as gcc does not actually know what hardware does, or does not, do for many things.
Quoted 9 lines
Quoted 3 lines
thanks,
greg k-h
thank you for explanation, my hardware knowledge is poor:( Sorry for noise.
fabio
I suspected that removing those variables could have been a source of troubles (but I was thinking of possible side effects on internal kernel's data, not of hardware related idiosyncrasies), however I think that you did well to point it out because:
1) We learned something new from Greg;
2) I learned that, for the purpose of finding definitions, vim's ctrl-] is not the right way to work out the problem.
If you have time, I'd appreciate some comments on the topic of line (2).
Thanks,
Fabio
Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8723bs: hal: Remove set but unused variables
Quoted 25 lines
Quoted 25 lines
Quoted 13 lines
Yes, but many types of hardware _REQUIRE_ reads to do something. So "read that does nothing" is a requirement for some operations.
As an example, a write is only guaranteed to have been finished if you do a read of the same location back from it on some hardware busses. The bus can reorder things, but a write/read of the same location can not be reordered.
Sometimes you have to do reads multiple times to get things to "stick".
Other times reading from a location changes a state in the hardware (horrid but HW designers aren't the brightest at times...)
Quoted 8 lines
So you can NOT just remove reads without knowing that the hardware does not require this. This is an issue where GCC "warnings" mean nothing as gcc does not actually know what hardware does, or does not, do for many things.
thanks,
greg k-h
thank you for explanation, my hardware knowledge is poor:( Sorry for noise.
Quoted 8 lines
Quoted 2 lines
fabio
I suspected that removing those variables could have been a source of troubles (but I was thinking of possible side effects on internal kernel's data, not of hardware related idiosyncrasies), however I think that you did well to point it out because:
1) We learned something new from Greg;
yes that's been very good for me
Quoted 2 lines
2) I learned that, for the purpose of finding definitions, vim's ctrl-] is not the right way to work out the problem.
3) I learned that with ctrl-] in vim one could (in some misterious conditions) see a function definition :-D
It seems that you know more than me about vim, I make intensive use of grep for finding function defs and usages in code.
Quoted 9 lines
If you have time, I'd appreciate some comments on the topic of line (2).
Thanks,
Fabio
thank you,
fabio
PATCH 2/2 staging: rtl8723bs: core: Removed set but unused variable.
In reply to Fabio M. De FrancescoRemoved set but unused variable. Issue detected by gcc.
--- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +1 -3
@@ -1019,7 +1019,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)u16 capab_info;struct rtw_ieee802_11_elems elems;struct sta_info *pstat; -unsigned char reassoc, *p, *pos, *wpa_ie; +unsigned char *p, *pos, *wpa_ie;unsigned char WMM_IE [] = {0x00 ,0x50 ,0xf2 ,0x02 ,0x00 ,0x01 };int i, ie_len, wpa_ie_len, left;unsigned char supportRate[16 ];
@@ -1040,10 +1040,8 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame) frame_type =GetFrameSubType (pframe);if (frame_type ==WIFI_ASSOCREQ ) { - reassoc =0 ; ie_offset = _ASOCREQ_IE_OFFSET_; }else {/* WIFI_REASSOCREQ */ - reassoc =1 ; ie_offset = _REASOCREQ_IE_OFFSET_; }
Signature · 1 line
2.31.1
Re: [Outreachy kernel] [PATCH 2/2] staging: rtl8723bs: core: Removed set but unused variable.
Quoted 21 lines · Fabio M. De Francesco
Removed set but unused variable. Issue detected by gcc.
Signed-off-by Fabio M. De Francesco <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +1
-1@@ -1019,7 +1019,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)u16 capab_info;struct rtw_ieee802_11_elems elems;struct sta_info *pstat; -unsigned char reassoc, *p, *pos, *wpa_ie; +unsigned char *p, *pos, *wpa_ie;unsigned char WMM_IE [] = {0x00 ,0x50 ,0xf2 ,0x02 ,0x00 ,0x01 };int i, ie_len, wpa_ie_len, left;unsigned char supportRate[16 ];
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame) · line 1046
Quoted 9 lines
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0
-2@@ -1040,10 +1040,8 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame) frame_type =GetFrameSubType (pframe);if (frame_type ==WIFI_ASSOCREQ ) { - reassoc =0 ; ie_offset = _ASOCREQ_IE_OFFSET_; }else {/* WIFI_REASSOCREQ */ - reassoc =1 ; ie_offset = _REASOCREQ_IE_OFFSET_; }
Get rid of the curly braces as well, otherwise the patch introduces a checkpatch warning.
regards,
dan carpenter