i2c: core: Make debug message even more debuggish
Subsystems (2)
PATCH 1/1 i2c: core: Make debug message even more debuggish
One may notice that dev_printk(KERN_DEBUG ...) is *not* an equivalent to dev_dbg(). It will be printed whenever loglevel is high enough. And currently it will be the only message in the I²C core in some configurations that got printed under above conditions.
Moving to dev_dbg() will hide it in the configurations where Dynamic Debug is enabled and hence align with all other debug messages in the I²C core..
--- drivers/i2c/i2c-core-base.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/i2c/i2c-core-base.c +7 -3
@@ -399,7 +399,8 @@ static int i2c_gpio_init_recovery(struct i2c_adapter *adap)static int i2c_init_recovery (struct i2c_adapter *adap) {struct i2c_bus_recovery_info *bri = adap->bus_recovery_info; -char *err_str, *err_level =KERN_ERR ; +bool error_or_debug = true; +char *err_str;if (!bri)return 0 ;
@@ -409,7 +410,7 @@ static int i2c_init_recovery(struct i2c_adapter *adap)if (!bri->recover_bus) { err_str ="no suitable method provided" ; - err_level =KERN_DEBUG ; + error_or_debug = false; goto err; }
@@ -436,7 +437,10 @@ static int i2c_init_recovery(struct i2c_adapter *adap)return 0 ; err: -dev_printk (err_level, &adap->dev,"Not using recovery: %s\n" , err_str); +if (error_or_debug) +dev_err (&adap->dev,"Not using recovery: %s\n" , err_str); +else +dev_dbg (&adap->dev,"Not using recovery: %s\n" , err_str); adap->bus_recovery_info =NULL ;return -EINVAL ;
Signature · 1 line
2.30.2
Quoted 7 lines · Andy Shevchenko
One may notice that
dev_printk(KERN_DEBUG ...)is *not* an equivalent todev_dbg(). It will be printed whenever loglevel is high enough. And currently it will be the only message in the I²C core in some configurations that got printed under above conditions.Moving to
dev_dbg()will hide it in the configurations where Dynamic Debug is enabled and hence align with all other debug messages in the I²C core..
Wolfram, any comment on this?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Andy Shevchenko
One may notice that
dev_printk(KERN_DEBUG ...)is *not* an equivalent todev_dbg(). It will be printed whenever loglevel is high enough. And currently it will be the only message in the I²C core in some configurations that got printed under above conditions.Moving to
dev_dbg()will hide it in the configurations where Dynamic Debug is enabled and hence align with all other debug messages in the I²C core..
OK in general.
drivers/i2c/i2c-core-base.c static int i2c_gpio_init_recovery(struct i2c_adapter *adap) · line 402
Quoted 1 line
drivers/i2c/i2c-core-base.c +1
-0+bool error_or_debug = true;
A bool having "or" in the name is quite confusing: "do you want this or that" - "yes!" :) What about "is_error_level"?