staging: rtl8712: Use list iterators and helpers
PATCH 1/1 staging: rtl8712: Use list iterators and helpers
Use existing list iterators and helper functions.
The following coccinelle script was used to convert the code.
@@
identifier v1, v2, v3, v4;
symbol next;
expression e;
iterator name list_for_each;
statement S;
@@
<+...
(
- e = v1->next;
|
- e = get_next(v1);
)
... when != e
- while ( \( v1 != e \| e != v1 \) )
+ list_for_each (e, v1)
{
...
- v2 = container_of(e, struct v3, v4);
+ v2 = list_entry(e, struct v3, v4);
?- if (!v2) S
...(
- e = e->next;
|
- e = get_next(e);
)
... when != e
}
...+>
Compile tested only.
Signed-off-by Guenter Roeck <[email protected]>
--- drivers/staging/rtl8712/rtl871x_mlme.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/rtl8712/rtl871x_mlme.c +2 -4
@@ -139,10 +139,8 @@ static struct wlan_network *r8712_find_network(struct __queue *scanned_queue,return NULL ;spin_lock_irqsave (&scanned_queue->lock, irqL); phead = &scanned_queue->queue; - plist = phead->next; -while (plist != phead) { - pnetwork = container_of(plist, struct wlan_network, list); - plist = plist->next; +list_for_each (plist, phead) { + pnetwork = list_entry(plist, struct wlan_network, list);if (!memcmp (addr, pnetwork->network.MacAddress,ETH_ALEN ))break ; }
Signature · 1 line
2.17.1