libxfs: copy crtime correctly now that it's timespec64
PATCH 1/1 libxfs: copy crtime correctly now that it's timespec64
From: Darrick J. Wong <[email protected]>
The incore i_mtime and di_crtime are both timespec64 now, which means that tv_sec is a 64-bit value. Don't cast that to int32_t when we're creating an inode, because we'll end up truncating the creation time incorrectly, should an xfsprogs of this vintage make it to 2039. :P
--- libxfs/util.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
libxfs/util.c +1 -2
@@ -290,8 +290,7 @@ libxfs_init_new_inode(VFS_I (ip)->i_version =1 ; ip->i_d.di_flags2 = pip ? ip->i_mount->m_ino_geo.new_diflags2 :xfs_flags2diflags2 (ip, fsx->fsx_xflags); - ip->i_d.di_crtime.tv_sec = (int32_t )VFS_I (ip)->i_mtime.tv_sec; - ip->i_d.di_crtime.tv_nsec = (int32_t )VFS_I (ip)->i_mtime.tv_nsec; + ip->i_d.di_crtime =VFS_I (ip)->i_mtime;/* struct copy */ ip->i_d.di_cowextsize = pip ?0 : fsx->fsx_cowextsize; }
Quoted 8 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
The incore
i_mtimeanddi_crtimeare both timespec64 now, which means thattv_secis a 64-bit value. Don't cast that toint32_twhen we're creating an inode, because we'll end up truncating the creation time incorrectly, should an xfsprogs of this vintage make it to 2039. :PSigned-off-by Darrick J. Wong <[email protected]>
I'm not sure the struct copy comment is all that useful, but otherwise this looks good: