Skip to contentSkip to conversation

usb: musb: remove unused function argument

PATCH In review Saurav Girepunje 2 participants 2 messages May 5, 2021 – May 6, 2021

Subsystems (2)
USB MUSB multipoint high speed dual-role controller
lore
Share & tools
lore

Saurav Girepunje

author
#0 lore raw

PATCH 1/1 usb: musb: remove unused function argument

Remove unused function argument from musb_tx_dma_set_mode_cppi_tusb() in musb_host.c

Signed-off-by Saurav Girepunje <[email protected]>
---
 drivers/usb/musb/musb_host.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/usb/musb/musb_host.c +2 -7
index 8b7d22a0c0fb..978d822af2c5 100644
@@ -602,12 +602,8 @@ static void musb_tx_dma_set_mode_mentor(struct dma_controller *dma,
 	musb_writew(epio, MUSB_TXCSR, csr);
 }
 
-static void musb_tx_dma_set_mode_cppi_tusb(struct dma_controller *dma,
-					   struct musb_hw_ep *hw_ep,
-					   struct musb_qh *qh,
+static void musb_tx_dma_set_mode_cppi_tusb(struct musb_hw_ep *hw_ep,
 					   struct urb *urb,
-					   u32 offset,
-					   u32 *length,
 					   u8 *mode)
 {
 	struct dma_channel *channel = hw_ep->tx_channel;

@@ -633,8 +629,7 @@ static bool musb_tx_dma_program(struct dma_controller *dma,
 		musb_tx_dma_set_mode_mentor(dma, hw_ep, qh, urb, offset,
 					    &length, &mode);
 	else if (is_cppi_enabled(hw_ep->musb) || tusb_dma_omap(hw_ep->musb))
-		musb_tx_dma_set_mode_cppi_tusb(dma, hw_ep, qh, urb, offset,
-					       &length, &mode);
+		musb_tx_dma_set_mode_cppi_tusb(hw_ep, urb, &mode);
 	else
 		return false;

--
2.25.1

maintainer
#1 lore raw
Quoted 7 lines · Saurav Girepunje

Remove unused function argument from musb_tx_dma_set_mode_cppi_tusb() in musb_host.c

Signed-off-by Saurav Girepunje <[email protected]>
---
 drivers/usb/musb/musb_host.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

This has the same identical subject line as your previous patch, yet it does something different.

Please fix up both of these patches and resubmit them as a patch series, with unique subject lines.

thanks,

greg k-h