media: mxl692: make a const array static, makes object smaller
Subsystems (2)
PATCH 1/1 media: mxl692: make a const array static, makes object smaller
From: Colin Ian King <[email protected]>
Don't populate the const array fw_hdr on the stack but instead it static. Makes the object code smaller by 5 bytes:
Before:
text data bss dec hex filename
31948 12072 64 44084 ac34 drivers/media/dvb-frontends/mxl692.o
After:
text data bss dec hex filename
31879 12136 64 44079 ac2f drivers/media/dvb-frontends/mxl692.o
(gcc version 10.3.0)
Signed-off-by Colin Ian King <[email protected]>
--- drivers/media/dvb-frontends/mxl692.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/media/dvb-frontends/mxl692.c +3 -1
@@ -224,7 +224,9 @@ static int mxl692_validate_fw_header(struct mxl692_dev *dev,u32 ix, temp;__be32 *local_buf =NULL ;u8 temp_cksum =0 ; -const u8 fw_hdr[] = {0x4D ,0x31 ,0x10 ,0x02 ,0x40 ,0x00 ,0x00 ,0x80 }; +static const u8 fw_hdr[] = { +0x4D ,0x31 ,0x10 ,0x02 ,0x40 ,0x00 ,0x00 ,0x80 + };if (memcmp (buffer, fw_hdr,8 ) !=0 ) { status = -EINVAL ;
Signature · 1 line
2.30.2