Skip to contentSkip to conversation

station: Fix autoconnect loops

PATCH New Andrew Zaborowski 1 participant 1 message May 10, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 station: Fix autoconnect loops

Make sure we process the result of a connect attempt both in a D-Bus triggered connection and during autoconnect. Until now we'd only call station_connect_cb() on NETDEV_EVENT_DISCONNECT_BY_{AP,SME} if station->connect_pending was non-NULL, i.e. only in the D-Bus method. As a result we were never blacklisting BSSes and never calling network_connect_failed() (to set ask_passphrase) during autoconnect.

---
 src/station.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
src/station.c +2 -1
index 479f81f5..aba16c83 100644
@@ -1370,7 +1370,8 @@ static void station_disconnect_event(struct station *station, void *event_data)
 {
 	l_debug("%u", netdev_get_ifindex(station->netdev));
 
-	if (station->connect_pending)
+	if (station->connect_pending ||
+			station->state == STATION_STATE_CONNECTING)
 		station_connect_cb(station->netdev,
 					NETDEV_RESULT_HANDSHAKE_FAILED,
 					event_data, station);
Signature · 1 line
2.27.0