hwmon: (ltc2992) Put fwnode in error case during ->probe()
PATCH 1/1 hwmon: (ltc2992) Put fwnode in error case during ->probe()
In each iteration fwnode_for_each_available_child_node() bumps a reference counting of a loop variable followed by dropping in on a next iteration,
Since in error case the loop is broken, we have to drop a reference count by ourselves. Do it for port_fwnode in error case during ->probe().
Fixes b0bd407e94b0 ("hwmon: (ltc2992) Add support")
Cc Alexandru Tachici <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/hwmon/ltc2992.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/hwmon/ltc2992.c +6 -2
@@ -900,11 +900,15 @@ static int ltc2992_parse_dt(struct ltc2992_state *st)fwnode_for_each_available_child_node (fwnode, child) { ret =fwnode_property_read_u32 (child,"reg" , &addr); -if (ret <0 ) +if (ret <0 ) { +fwnode_handle_put (child);return ret; + } -if (addr >1 ) +if (addr >1 ) { +fwnode_handle_put (child);return -EINVAL ; + } ret =fwnode_property_read_u32 (child,"shunt-resistor-micro-ohms" , &val);if (!ret)
Signature · 1 line
2.31.1
Quoted 9 lines · Andy Shevchenko
In each iteration
fwnode_for_each_available_child_node()bumps a reference counting of a loop variable followed by dropping in on a next iteration,Since in error case the loop is broken, we have to drop a reference count by ourselves. Do it for
port_fwnodein error case during ->probe().Fixes b0bd407e94b0 ("hwmon: (ltc2992) Add support")Cc Alexandru Tachici <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Applied.
Thanks,
Guenter
Quoted 26 lines
--- drivers/hwmon/ltc2992.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)drivers/hwmon/ltc2992.c +6
-2@@ -900,11 +900,15 @@ static int ltc2992_parse_dt(struct ltc2992_state *st)fwnode_for_each_available_child_node (fwnode, child) { ret =fwnode_property_read_u32 (child,"reg" , &addr); -if (ret <0 ) +if (ret <0 ) { +fwnode_handle_put (child);return ret; + } -if (addr >1 ) +if (addr >1 ) { +fwnode_handle_put (child);return -EINVAL ; + } ret =fwnode_property_read_u32 (child,"shunt-resistor-micro-ohms" , &val);if (!ret)