Skip to contentSkip to conversation

ACPI / EC: Fix media keys not working problem on more Asus laptops

PATCH Applied Jian-Hong Pan 3 participants 8 messages May 11, 2021 – May 21, 2021 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI / EC: Fix media keys not working problem on more Asus laptops

From: Chris Chiu <[email protected]>

More ASUS laptops have the _GPE define in the DSDT table with a different value than the _GPE number in the ECDT.

This is causing media keys not working on ASUS X505BA/BP, X542BA/BP

Add model info to the quirks list.

---
 drivers/acpi/ec.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
drivers/acpi/ec.c +16 -0
index 13565629ce0a..e8c5da2b964a 100644
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
 	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
 	DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
 	{
+	ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+	DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+	{
+	ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+	DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+	{
+	ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+	DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+	{
+	ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+	DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
+	{
 	ec_honor_ecdt_gpe, "ASUS X550VXK", {
 	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
 	DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
Signature · 1 line
2.31.1
maintainer Applied
#1 lore raw
Quoted 34 lines · Jian-Hong Pan

From: Chris Chiu <[email protected]>

More ASUS laptops have the _GPE define in the DSDT table with a different value than the _GPE number in the ECDT.

This is causing media keys not working on ASUS X505BA/BP, X542BA/BP

Add model info to the quirks list.

---
 drivers/acpi/ec.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
drivers/acpi/ec.c +10 -0
index 13565629ce0a..e8c5da2b964a 100644
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
        DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
        {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),

drivers/acpi/ec.c static const struct dmi_system_id ec_dmi_table[] __initconst = {

Quoted 10 lines
drivers/acpi/ec.c +6 -1
+       DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
+       {
        ec_honor_ecdt_gpe, "ASUS X550VXK", {
        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
        DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
--

Applied as 5.14 material under a different subject ("ACPI: EC: Make more Asus laptops use ECDT _GPE"), thanks!

#2 lore raw
Quoted 41 lines · Rafael J. Wysocki
Quoted 39 lines · Jian-Hong Pan

From: Chris Chiu <[email protected]>

More ASUS laptops have the _GPE define in the DSDT table with a different value than the _GPE number in the ECDT.

This is causing media keys not working on ASUS X505BA/BP, X542BA/BP

Add model info to the quirks list.

---
 drivers/acpi/ec.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
drivers/acpi/ec.c +15 -0
index 13565629ce0a..e8c5da2b964a 100644
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
        DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
        {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
Quoted 8 lines

drivers/acpi/ec.c static const struct dmi_system_id ec_dmi_table[] __initconst = {

Quoted 5 lines
drivers/acpi/ec.c +1 -1
+       {
        ec_honor_ecdt_gpe, "ASUS X550VXK", {
        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
        DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
--

Applied as 5.14 material under a different subject ("ACPI: EC: Make more Asus laptops use ECDT _GPE"), thanks!

And dropped, because the [email protected] email address is bouncing.

Please resend with a valid email address in the From: field, thanks!

#3 lore raw

PATCH v2 1/1 ACPI: EC: Make more Asus laptops use ECDT _GPE

From: Chris Chiu <[email protected]>

More ASUS laptops have the _GPE define in the DSDT table with a different value than the _GPE number in the ECDT.

This is causing media keys not working on ASUS X505BA/BP, X542BA/BP

Add model info to the quirks list.

---
v2: Edit the author information with valid email address

 drivers/acpi/ec.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
drivers/acpi/ec.c +16 -0
index 13565629ce0a..e8c5da2b964a 100644
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
 	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
 	DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
 	{
+	ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+	DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+	{
+	ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+	DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+	{
+	ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+	DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+	{
+	ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+	DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
+	{
 	ec_honor_ecdt_gpe, "ASUS X550VXK", {
 	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
 	DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
Signature · 1 line
2.31.1
#4 lore raw

Re: [PATCH v2] ACPI: EC: Make more Asus laptops use ECDT _GPE

Quoted 11 lines · Jian-Hong Pan

From: Chris Chiu <[email protected]>

More ASUS laptops have the _GPE define in the DSDT table with a different value than the _GPE number in the ECDT.

This is causing media keys not working on ASUS X505BA/BP, X542BA/BP

Add model info to the quirks list.

This has to match the From address.

Chris, can the e-mail address in the S-o-b be changed?

Quoted 37 lines

---
v2: Edit the author information with valid email address

 drivers/acpi/ec.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
drivers/acpi/ec.c +16 -1
index 13565629ce0a..e8c5da2b964a 100644
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
        DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
        {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
+       {
        ec_honor_ecdt_gpe, "ASUS X550VXK", {
        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
        DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
--

2.31.1

#5 lore raw

Re: [PATCH v2] ACPI: EC: Make more Asus laptops use ECDT _GPE

Quoted 10 lines · Rafael J. Wysocki
Quoted 8 lines · Jian-Hong Pan

From: Chris Chiu <[email protected]>

More ASUS laptops have the _GPE define in the DSDT table with a different value than the _GPE number in the ECDT.

This is causing media keys not working on ASUS X505BA/BP, X542BA/BP

Quoted 8 lines
Quoted 3 lines

Add model info to the quirks list.

This has to match the From address.

Chris, can the e-mail address in the S-o-b be changed?

Sure. I've updated the .mailmap. Jian-Hong, could you help fix the S-o-b? Thanks.

Chris

Quoted 37 lines
Quoted 37 lines

---
v2: Edit the author information with valid email address

 drivers/acpi/ec.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
drivers/acpi/ec.c +16 -1
index 13565629ce0a..e8c5da2b964a 100644
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
        DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
        {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
+       {
        ec_honor_ecdt_gpe, "ASUS X550VXK", {
        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
        DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
--

2.31.1

#6 lore raw

PATCH v3 1/1 ACPI: EC: Make more Asus laptops use ECDT _GPE

From: Chris Chiu <[email protected]>

More ASUS laptops have the _GPE define in the DSDT table with a different value than the _GPE number in the ECDT.

This is causing media keys not working on ASUS X505BA/BP, X542BA/BP

Add model info to the quirks list.

---
v2: Edit the author information with valid email address

v3: Edit Chris' S-o-b with current valid email address

 drivers/acpi/ec.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
drivers/acpi/ec.c +16 -0
index 13565629ce0a..e8c5da2b964a 100644
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
 	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
 	DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
 	{
+	ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+	DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+	{
+	ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+	DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+	{
+	ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+	DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+	{
+	ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+	DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
+	{
 	ec_honor_ecdt_gpe, "ASUS X550VXK", {
 	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
 	DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
Signature · 1 line
2.31.1
maintainer Applied
#7 lore raw

Re: [PATCH v3] ACPI: EC: Make more Asus laptops use ECDT _GPE

Quoted 38 lines · Jian-Hong Pan

From: Chris Chiu <[email protected]>

More ASUS laptops have the _GPE define in the DSDT table with a different value than the _GPE number in the ECDT.

This is causing media keys not working on ASUS X505BA/BP, X542BA/BP

Add model info to the quirks list.

---
v2: Edit the author information with valid email address

v3: Edit Chris' S-o-b with current valid email address

 drivers/acpi/ec.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
drivers/acpi/ec.c +10 -0
index 13565629ce0a..e8c5da2b964a 100644
@@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
        DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
        {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),

drivers/acpi/ec.c static const struct dmi_system_id ec_dmi_table[] __initconst = {

Quoted 10 lines
drivers/acpi/ec.c +6 -1
+       DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
+       {
+       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
+       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+       DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
+       {
        ec_honor_ecdt_gpe, "ASUS X550VXK", {
        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
        DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
--

Applied as 5.14 material, thanks!