iio: ep93xx: Remove redundant error printing in ep93xx_adc_probe()
Subsystems (2)
PATCH 1/1 iio: ep93xx: Remove redundant error printing in ep93xx_adc_probe()
When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information.
Therefore, remove the error printing here to simplify code and reduce the binary size.
--- drivers/iio/adc/ep93xx_adc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/ep93xx_adc.c +1 -3
@@ -165,10 +165,8 @@ static int ep93xx_adc_probe(struct platform_device *pdev) res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); priv->base =devm_ioremap_resource (&pdev->dev, res); -if (IS_ERR (priv->base)) { -dev_err (&pdev->dev,"Cannot map memory resource\n" ); +if (IS_ERR (priv->base))return PTR_ERR (priv->base); - } iiodev->name =dev_name (&pdev->dev); iiodev->modes =INDIO_DIRECT_MODE ;
Signature · 1 line
2.26.0.106.g9fadedd
Jonathan Cameron
maintainerQuoted 10 lines · On Tue, 11 May 2021 19:39:12 +0800 Zhen Lei <[email protected]> wrote:
When
devm_ioremap_resource()fails, a clear enough error message will be printed by its subfunction__devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information.Therefore, remove the error printing here to simplify code and reduce the binary size.
Reported-by Hulk Robot <[email protected]>Signed-off-by Zhen Lei <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing for 0-day to poke at it.
Thanks,
Jonathan
Quoted 20 lines
--- drivers/iio/adc/ep93xx_adc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/iio/adc/ep93xx_adc.c +1
-3@@ -165,10 +165,8 @@ static int ep93xx_adc_probe(struct platform_device *pdev) res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); priv->base =devm_ioremap_resource (&pdev->dev, res); -if (IS_ERR (priv->base)) { -dev_err (&pdev->dev,"Cannot map memory resource\n" ); +if (IS_ERR (priv->base))return PTR_ERR (priv->base); - } iiodev->name =dev_name (&pdev->dev); iiodev->modes =INDIO_DIRECT_MODE ;