hwmon: adm1272: enable adm1272 temperature reporting
PATCH 1/1 hwmon: adm1272: enable adm1272 temperature reporting
adm1272 supports temperature reporting but it is disabled by default.
Tested:
ls temp1_*
temp1_crit temp1_highest temp1_max temp1_crit_alarm temp1_input temp1_max_alarm
cat temp1_input
26642
Signed-off-by Chu Lin <[email protected]>
--- drivers/hwmon/pmbus/adm1275.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/hwmon/pmbus/adm1275.c +6 -8
@@ -611,11 +611,13 @@ static int adm1275_probe(struct i2c_client *client) tindex =8 ; info->func[0 ] |=PMBUS_HAVE_PIN |PMBUS_HAVE_STATUS_INPUT | -PMBUS_HAVE_VOUT |PMBUS_HAVE_STATUS_VOUT ; +PMBUS_HAVE_VOUT |PMBUS_HAVE_STATUS_VOUT | +PMBUS_HAVE_TEMP |PMBUS_HAVE_STATUS_TEMP ; -/* Enable VOUT if not enabled (it is disabled by default) */ -if (!(config &ADM1278_VOUT_EN )) { - config |=ADM1278_VOUT_EN ; +/* Enable VOUT & TEMP1 if not enabled (disabled by default) */ +if ((config & (ADM1278_VOUT_EN |ADM1278_TEMP1_EN )) != + (ADM1278_VOUT_EN |ADM1278_TEMP1_EN )) { + config |=ADM1278_VOUT_EN |ADM1278_TEMP1_EN ; ret =i2c_smbus_write_byte_data (client,ADM1275_PMON_CONFIG , config);
@@ -625,10 +627,6 @@ static int adm1275_probe(struct i2c_client *client)return -ENODEV ; } } - -if (config &ADM1278_TEMP1_EN ) - info->func[0 ] |= -PMBUS_HAVE_TEMP |PMBUS_HAVE_STATUS_TEMP ;if (config &ADM1278_VIN_EN ) info->func[0 ] |=PMBUS_HAVE_VIN ;break ;
Signature · 1 line
2.31.1.607.g51e8a6a459-goog
Quoted 11 lines · Chu Lin
adm1272 supports temperature reporting but it is disabled by default.
Tested:
ls temp1_*temp1_crit temp1_highest temp1_max temp1_crit_alarm temp1_input temp1_max_alarmcat
temp1_input
26642Signed-off-by Chu Lin <[email protected]>
Applied, after updating the affected driver in the subject line (the change affects adm1272, but the driver is still the adm1275 driver).
Thanks,
Guenter
Quoted 37 lines
--- drivers/hwmon/pmbus/adm1275.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)drivers/hwmon/pmbus/adm1275.c +6
-8@@ -611,11 +611,13 @@ static int adm1275_probe(struct i2c_client *client) tindex =8 ; info->func[0 ] |=PMBUS_HAVE_PIN |PMBUS_HAVE_STATUS_INPUT | -PMBUS_HAVE_VOUT |PMBUS_HAVE_STATUS_VOUT ; +PMBUS_HAVE_VOUT |PMBUS_HAVE_STATUS_VOUT | +PMBUS_HAVE_TEMP |PMBUS_HAVE_STATUS_TEMP ; -/* Enable VOUT if not enabled (it is disabled by default) */ -if (!(config &ADM1278_VOUT_EN )) { - config |=ADM1278_VOUT_EN ; +/* Enable VOUT & TEMP1 if not enabled (disabled by default) */ +if ((config & (ADM1278_VOUT_EN |ADM1278_TEMP1_EN )) != + (ADM1278_VOUT_EN |ADM1278_TEMP1_EN )) { + config |=ADM1278_VOUT_EN |ADM1278_TEMP1_EN ; ret =i2c_smbus_write_byte_data (client,ADM1275_PMON_CONFIG , config);@@ -625,10 +627,6 @@ static int adm1275_probe(struct i2c_client *client)return -ENODEV ; } } - -if (config &ADM1278_TEMP1_EN ) - info->func[0 ] |= -PMBUS_HAVE_TEMP |PMBUS_HAVE_STATUS_TEMP ;if (config &ADM1278_VIN_EN ) info->func[0 ] |=PMBUS_HAVE_VIN ;break ;