Skip to contentSkip to conversation

arm64: dts: qcom: Add wakeup delay for adau codec

PATCH In review Srinivasa Rao Mandadapu 3 participants 3 messages May 13, 2021 – May 20, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: qcom: Add wakeup delay for adau codec

Add wakeup delay for fixing PoP noise during capture begin.

---
 arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi +1 -0
index 4c6e433c8226..3eb8550da1fc 100644
@@ -23,6 +23,7 @@ / {
 	adau7002: audio-codec-1 {
 		compatible = "adi,adau7002";
 		IOVDD-supply = <&pp1800_l15a>;
+		wakeup-delay-ms = <15>;
 		#sound-dai-cells = <0>;
 	};
 };
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
#1 lore raw

Quoting Srinivasa Rao Mandadapu (2021-05-13 05:24:29)

Quoted 13 lines

Add wakeup delay for fixing PoP noise during capture begin.

---
 arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi +0 -0
index 4c6e433c8226..3eb8550da1fc 100644

arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi / { · line 26

Quoted 4 lines
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi +1 -0
@@ -23,6 +23,7 @@ / {
        adau7002: audio-codec-1 {
                compatible = "adi,adau7002";
                IOVDD-supply = <&pp1800_l15a>;
+               wakeup-delay-ms = <15>;

Is this part of the binding?

Reviewed-by
#2 lore raw

Hi,

Quoted 10 lines · Stephen Boyd

Quoting Srinivasa Rao Mandadapu (2021-05-13 05:24:29)

Quoted 8 lines

Add wakeup delay for fixing PoP noise during capture begin.

---
 arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi / { · line 26

Quoted 9 lines
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi +1 -0
index 4c6e433c8226..3eb8550da1fc 100644
@@ -23,6 +23,7 @@ / {
        adau7002: audio-codec-1 {
                compatible = "adi,adau7002";
                IOVDD-supply = <&pp1800_l15a>;
+               wakeup-delay-ms = <15>;

Is this part of the binding?

It doesn't seem to be, but it's supported by the code. It's also in the generic "dmic" bindings. The bindings are pre-yaml. Seems like someone needs to take charge and clean those up, but I'm not sure we need to block this patch on it?

Though I'm not an expert on audio stuff, assuming that this works OK I'm fine with:

-Doug