Skip to contentSkip to conversation

libnotify: Make gtk+3 dependency optional

PATCH Superseded Mike Crowe 2 participants 2 messages May 13, 2021

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Mike Crowe

author
#0 lore raw

PATCH v2 1/1 libnotify: Make gtk+3 dependency optional

libnotify only requires gtk+3 for its tests. Let's disable them by default.

---
 meta/recipes-gnome/libnotify/libnotify_0.7.9.bb | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
meta/recipes-gnome/libnotify/libnotify_0.7.9.bb +4 -3
index bbbd72193e..0dc3dc3a3c 100644
@@ -9,15 +9,16 @@ SECTION = "libs"
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING;md5=7fbc338309ac38fefcd64b04bb903e34"
 
-DEPENDS = "dbus gtk+3 glib-2.0"
+DEPENDS = "dbus glib-2.0 gdk-pixbuf"
+
+PACKAGECONFIG ?= ""
+PACKAGECONFIG[gtk+] = "-Dtests=true,-Dtests=false,gtk+3"
 
 GNOMEBASEBUILDCLASS = "meson"
 GTKDOC_MESON_OPTION = "gtk_doc"
 GIR_MESON_ENABLE_FLAG = "enabled"
 GIR_MESON_DISABLE_FLAG = "disabled"
 inherit gnomebase gtk-doc features_check gobject-introspection
-# depends on gtk+3
-ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
 
 SRC_URI[archive.md5sum] = "ccd9c53364174cc8d13e18a1988faa76"
 SRC_URI[archive.sha256sum] = "66c0517ed16df7af258e83208faaf5069727dfd66995c4bbc51c16954d674761"
Signature · 1 line
2.30.2
#1 lore raw
Quoted 14 lines · Mike Crowe via lists.openembedded.org

libnotify only requires gtk+3 for its tests. Let's disable them by default.

---
 meta/recipes-gnome/libnotify/libnotify_0.7.9.bb | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
meta/recipes-gnome/libnotify/libnotify_0.7.9.bb +0 -0
index bbbd72193e..0dc3dc3a3c 100644

meta/recipes-gnome/libnotify/libnotify_0.7.9.bb SECTION = "libs" · line 16

Quoted 9 lines
meta/recipes-gnome/libnotify/libnotify_0.7.9.bb +4 -1
@@ -9,15 +9,16 @@ SECTION = "libs"
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING;md5=7fbc338309ac38fefcd64b04bb903e34"
 
-DEPENDS = "dbus gtk+3 glib-2.0"
+DEPENDS = "dbus glib-2.0 gdk-pixbuf"
+
+PACKAGECONFIG ?= ""
+PACKAGECONFIG[gtk+] = "-Dtests=true,-Dtests=false,gtk+3"
 

perhaps knob should be called 'tests'

meta/recipes-gnome/libnotify/libnotify_0.7.9.bb SECTION = "libs" · line 22

Quoted 8 lines
meta/recipes-gnome/libnotify/libnotify_0.7.9.bb +0 -2
 GNOMEBASEBUILDCLASS = "meson"
 GTKDOC_MESON_OPTION = "gtk_doc"
 GIR_MESON_ENABLE_FLAG = "enabled"
 GIR_MESON_DISABLE_FLAG = "disabled"
 inherit gnomebase gtk-doc features_check gobject-introspection
-# depends on gtk+3
-ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
 

do we need to check for them when tests are enabled ?

Quoted 8 lines
meta/recipes-gnome/libnotify/libnotify_0.7.9.bb +0 -1
 SRC_URI[archive.md5sum] = "ccd9c53364174cc8d13e18a1988faa76"
 SRC_URI[archive.sha256sum] = "66c0517ed16df7af258e83208faaf5069727dfd66995c4bbc51c16954d674761"
--

2.30.2