net: mana: Use struct_size() in kzalloc()
PATCH 1/1 net: mana: Use struct_size() in kzalloc()
Make use of the struct_size() helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worst scenario, could lead to heap overflows.
This code was detected with the help of Coccinelle and, audited and fixed manually.
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/net/ethernet/microsoft/mana/mana_en.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/microsoft/mana/mana_en.c +1 -2
@@ -1387,8 +1387,7 @@ static struct mana_rxq *mana_create_rxq(struct mana_port_context *apc, gc = gd->gdma_context; - rxq =kzalloc (sizeof (*rxq) + -RX_BUFFERS_PER_QUEUE *sizeof (struct mana_recv_buf_oob ), + rxq =kzalloc (struct_size (rxq, rx_oobs,RX_BUFFERS_PER_QUEUE ),GFP_KERNEL );if (!rxq)return NULL ;
Signature · 1 line
2.27.0