Skip to contentSkip to conversation

mm/huge_memory.c: remove unused variable 'count'

PATCH In review Pu Lehui 2 participants 2 messages May 14, 2021

Subsystems (2)
lore
Share & tools
lore

Pu Lehui

author
#0 lore raw

PATCH 1/1 mm/huge_memory.c: remove unused variable 'count'

mm/huge_memory.c:2663:6: warning:
variable ‘count’ set but not used [-Wunused-but-set-variable]

  2663 |  int count, mapcount, extra_pins, ret;
       |      ^~~~~

This variable is not used in function , this commit remove it to fix the warning.

---
 mm/huge_memory.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
mm/huge_memory.c +1 -2
index 52ca04b905cf..a23a127302e9 100644
@@ -2660,7 +2660,7 @@ int split_huge_page_to_list(struct page *page, struct list_head *list)
 	struct deferred_split *ds_queue = get_deferred_split_queue(head);
 	struct anon_vma *anon_vma = NULL;
 	struct address_space *mapping = NULL;
-	int count, mapcount, extra_pins, ret;
+	int mapcount, extra_pins, ret;
 	pgoff_t end;
 
 	VM_BUG_ON_PAGE(is_huge_zero_page(head), head);
@@ -2737,7 +2737,6 @@ int split_huge_page_to_list(struct page *page, struct list_head *list)
 
 	/* Prevent deferred_split_scan() touching ->_refcount */
 	spin_lock(&ds_queue->split_queue_lock);
-	count = page_count(head);
 	mapcount = total_mapcount(head);
 	if (!mapcount && page_ref_freeze(head, 1 + extra_pins)) {
 		if (!list_empty(page_deferred_list(head))) {
Signature · 1 line
2.17.1
#1 lore raw
Quoted 8 lines · Pu Lehui

mm/huge_memory.c:2663:6: warning:
variable ‘count’ set but not used [-Wunused-but-set-variable]

  2663 |  int count, mapcount, extra_pins, ret;
       |      ^~~~~

This variable is not used in function , this commit remove it to fix the warning.

Thanks for catching this warning. Not sure why my gcc 10 doesn't catch this warning at all. What compiler are you using?

Andrew, the compile warning was introduced by my mm-thp-check-total_mapcount-instead-of-page_mapcount.patch.

Quoted 31 lines
---
 mm/huge_memory.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
mm/huge_memory.c +1 -3
index 52ca04b905cf..a23a127302e9 100644
@@ -2660,7 +2660,7 @@ int split_huge_page_to_list(struct page *page, struct list_head *list)
        struct deferred_split *ds_queue = get_deferred_split_queue(head);
        struct anon_vma *anon_vma = NULL;
        struct address_space *mapping = NULL;
-       int count, mapcount, extra_pins, ret;
+       int mapcount, extra_pins, ret;
        pgoff_t end;
 
        VM_BUG_ON_PAGE(is_huge_zero_page(head), head);
@@ -2737,7 +2737,6 @@ int split_huge_page_to_list(struct page *page, struct list_head *list)
 
        /* Prevent deferred_split_scan() touching ->_refcount */
        spin_lock(&ds_queue->split_queue_lock);
-       count = page_count(head);
        mapcount = total_mapcount(head);
        if (!mapcount && page_ref_freeze(head, 1 + extra_pins)) {
                if (!list_empty(page_deferred_list(head))) {
--

2.17.1