Skip to contentSkip to conversation

drm: bridge: fix wrong pointer passed to PTR_ERR()

PATCH In review Qiheng Lin 2 participants 2 messages May 14, 2021 – May 17, 2021

Subsystems (5)
lore
Share & tools
lore

Qiheng Lin

author
#0 lore raw

PATCH 1/1 drm: bridge: fix wrong pointer passed to PTR_ERR()

PTR_ERR should access the value just tested by IS_ERR, otherwise the wrong error code will be returned.

---
 drivers/gpu/drm/bridge/ite-it66121.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/ite-it66121.c +1 -1
index d8a60691fd32..6980c9801d0d 100644
@@ -943,7 +943,7 @@ static int it66121_probe(struct i2c_client *client,
 	ctx->regmap = devm_regmap_init_i2c(client, &it66121_regmap_config);
 	if (IS_ERR(ctx->regmap)) {
 		ite66121_power_off(ctx);
-		return PTR_ERR(ctx);
+		return PTR_ERR(ctx->regmap);
 	}
 
 	regmap_read(ctx->regmap, IT66121_VENDOR_ID0_REG, &vendor_ids[0]);
Reviewed-by on v1 1/1
#1 lore raw

Hey Qiheng,

Thanks for submitting this bugfix.

The title of this patch should probably be:
drm: bridge: it66121: fix wrong pointer passed to PTR_ERR()

With this fixed, feel free to add my r-b.

Quoted 24 lines · Qiheng Lin

PTR_ERR should access the value just tested by IS_ERR, otherwise the wrong error code will be returned.

---
 drivers/gpu/drm/bridge/ite-it66121.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/ite-it66121.c +1 -1
index d8a60691fd32..6980c9801d0d 100644
@@ -943,7 +943,7 @@ static int it66121_probe(struct i2c_client *client,
        ctx->regmap = devm_regmap_init_i2c(client, &it66121_regmap_config);
        if (IS_ERR(ctx->regmap)) {
                ite66121_power_off(ctx);
-               return PTR_ERR(ctx);
+               return PTR_ERR(ctx->regmap);
        }
 
        regmap_read(ctx->regmap, IT66121_VENDOR_ID0_REG, &vendor_ids[0]);