KVM: x86/pt: Do not inject TraceToPAPMI when guest PT isn't supported
Subsystems (4)
PATCH 1/1 KVM: x86/pt: Do not inject TraceToPAPMI when guest PT isn't supported
When a PT perf user is running in system-wide mode on the host, the guest (w/ pt_mode=0) will warn about anonymous NMIs from kvm_handle_intel_pt_intr():
[ 18.126444] Uhhuh. NMI received for unknown reason 10 on CPU 0. [ 18.126447] Do you have a strange power saving mode enabled? [ 18.126448] Dazed and confused, but trying to continue
In this case, these PMIs should be handled by the host PT handler(). When PT is used in guest-only mode, it's harmless to call host handler.
Fix: 8479e04e7d("KVM: x86: Inject PMI for KVM guest")
--- arch/x86/events/intel/core.c | 3 +-- arch/x86/kvm/x86.c | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-)
arch/x86/events/intel/core.c +1 -2
@@ -2853,8 +2853,7 @@ static int handle_pmi_common(struct pt_regs *regs, u64 status)if (unlikely (perf_guest_cbs && perf_guest_cbs->is_in_guest () && perf_guest_cbs->handle_intel_pt_intr)) perf_guest_cbs->handle_intel_pt_intr (); -else -intel_pt_interrupt (); +intel_pt_interrupt (); }/*
arch/x86/kvm/x86.c +3 -0
@@ -8087,6 +8087,9 @@ static void kvm_handle_intel_pt_intr(void) {struct kvm_vcpu *vcpu =__this_cpu_read (current_vcpu); +if (!guest_cpuid_has (vcpu,X86_FEATURE_INTEL_PT )) +return ; +kvm_make_request (KVM_REQ_PMI , vcpu);__set_bit (MSR_CORE_PERF_GLOBAL_OVF_CTRL_TRACE_TOPA_PMI_BIT , (unsigned long *)&vcpu->arch.pmu.global_status);
Signature · 1 line
2.31.1
Sean Christopherson
maintainerQuoted 4 lines · Like Xu
When a PT perf user is running in system-wide mode on the host, the guest (w/ pt_mode=0) will warn about anonymous NMIs from
kvm_handle_intel_pt_intr():
Quoted 8 lines
[ 18.126444] Uhhuh. NMI received for unknown reason 10 on CPU 0. [ 18.126447] Do you have a strange power saving mode enabled? [ 18.126448] Dazed and confused, but trying to continueIn this case, these PMIs should be handled by the host PT
handler(). When PT is used in guest-only mode, it's harmless to call host handler.Fix: 8479e04e7d("KVM: x86: Inject PMI for KVM guest")
s/Fix/Fixes
Quoted 11 lines
Signed-off-by Like Xu <[email protected]>--- arch/x86/events/intel/core.c | 3 +-- arch/x86/kvm/x86.c | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-)arch/x86/events/intel/core.c +0
-0
arch/x86/events/intel/core.c static int handle_pmi_common(struct pt_regs *regs, u64 status) · line 2856
Quoted 6 lines
arch/x86/events/intel/core.c +1
-2@@ -2853,8 +2853,7 @@ static int handle_pmi_common(struct pt_regs *regs, u64 status)if (unlikely (perf_guest_cbs && perf_guest_cbs->is_in_guest () && perf_guest_cbs->handle_intel_pt_intr)) perf_guest_cbs->handle_intel_pt_intr (); -else -intel_pt_interrupt (); +intel_pt_interrupt ();
Would it make sense to instead do something like:
bool host_pmi = true; ... if (unlikely(perf_guest_cbs && perf_guest_cbs->is_in_guest() && perf_guest_cbs->handle_intel_pt_intr) host_pmi = !perf_guest_cbs->handle_intel_pt_intr(); if (likely(host_pmi)) intel_pt_interrupt();
Quoted 20 lines
arch/x86/events/intel/core.c +0
-0}/* arch/x86/kvm/x86.c +3
-0@@ -8087,6 +8087,9 @@ static void kvm_handle_intel_pt_intr(void) {struct kvm_vcpu *vcpu =__this_cpu_read (current_vcpu); +if (!guest_cpuid_has (vcpu,X86_FEATURE_INTEL_PT )) +return ; +kvm_make_request (KVM_REQ_PMI , vcpu);__set_bit (MSR_CORE_PERF_GLOBAL_OVF_CTRL_TRACE_TOPA_PMI_BIT , (unsigned long *)&vcpu->arch.pmu.global_status);Signature · 1 line
2.31.1
Quoted 36 lines · Sean Christopherson
Quoted 4 lines · Like Xu
When a PT perf user is running in system-wide mode on the host, the guest (w/ pt_mode=0) will warn about anonymous NMIs from
kvm_handle_intel_pt_intr():Quoted 8 lines
[ 18.126444] Uhhuh. NMI received for unknown reason 10 on CPU 0. [ 18.126447] Do you have a strange power saving mode enabled? [ 18.126448] Dazed and confused, but trying to continueIn this case, these PMIs should be handled by the host PT
handler(). When PT is used in guest-only mode, it's harmless to call host handler.Fix: 8479e04e7d("KVM: x86: Inject PMI for KVM guest")
s/Fix/Fixes
Quoted 11 lines
Signed-off-by Like Xu <[email protected]>--- arch/x86/events/intel/core.c | 3 +-- arch/x86/kvm/x86.c | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-)arch/x86/events/intel/core.c +0
-0arch/x86/events/intel/core.c static int handle_pmi_common(struct pt_regs *regs, u64 status) · line 2856
Quoted 6 lines
arch/x86/events/intel/core.c +1
-2@@ -2853,8 +2853,7 @@ static int handle_pmi_common(struct pt_regs *regs, u64 status)if (unlikely (perf_guest_cbs && perf_guest_cbs->is_in_guest () && perf_guest_cbs->handle_intel_pt_intr)) perf_guest_cbs->handle_intel_pt_intr (); -else -intel_pt_interrupt (); +intel_pt_interrupt ();Would it make sense to instead do something like:
Quoted 7 lines
bool host_pmi = true; ... if (unlikely(perf_guest_cbs && perf_guest_cbs->is_in_guest() && perf_guest_cbs->handle_intel_pt_intr) host_pmi = !perf_guest_cbs->handle_intel_pt_intr();
struct perf_guest_info_callbacks {
...
void (*handle_intel_pt_intr)(void);
};This fix is deferred until the following proposal is finalized.
https://lore.kernel.org/lkml/YKImQ2%[email protected]/
Quoted 24 lines
if (likely(host_pmi)) intel_pt_interrupt();Quoted 20 lines
arch/x86/events/intel/core.c +0
-0}/* arch/x86/kvm/x86.c +3
-0@@ -8087,6 +8087,9 @@ static void kvm_handle_intel_pt_intr(void) {struct kvm_vcpu *vcpu =__this_cpu_read (current_vcpu); +if (!guest_cpuid_has (vcpu,X86_FEATURE_INTEL_PT )) +return ; +kvm_make_request (KVM_REQ_PMI , vcpu);__set_bit (MSR_CORE_PERF_GLOBAL_OVF_CTRL_TRACE_TOPA_PMI_BIT , (unsigned long *)&vcpu->arch.pmu.global_status);Signature · 1 line
2.31.1