Skip to contentSkip to conversation

ACPI: APEI: Don't warn if ACPI is disabled

PATCH Applied Jon Hunter 2 participants 2 messages May 14, 2021 – May 21, 2021

Subsystems (3)
lore
Share & tools
lore

Jon Hunter

author maintainer
#0 lore raw

PATCH 1/1 ACPI: APEI: Don't warn if ACPI is disabled

If ACPI is not enabled but support for ACPI and APEI is enabled in the kernel, then the following warning is seen on boot ...

WARNING KERN EINJ: ACPI disabled.

For ARM64 platforms, the 'acpi_disabled' variable is true by default and hence, the above is often seen on ARM64. Given that it can be normal for ACPI to be disabled, make this an informational print rather that a warning.

---
Please note that the motivation for this change is to filter out any warnings that might not be actual issues. We have some automated tests that we run to catch warnings and errors and although we could add this to a list of non critical warnings, it is preferred to make this an informational print.

 drivers/acpi/apei/einj.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/apei/einj.c +1 -1
index 328e8aeece6c..2882450c443e 100644
@@ -673,7 +673,7 @@ static int __init einj_init(void)
 	struct apei_exec_context ctx;
 
 	if (acpi_disabled) {
-		pr_warn("ACPI disabled.\n");
+		pr_info("ACPI disabled.\n");
 		return -ENODEV;
 	}
 
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 27 lines · Jon Hunter

If ACPI is not enabled but support for ACPI and APEI is enabled in the kernel, then the following warning is seen on boot ...

WARNING KERN EINJ: ACPI disabled.

For ARM64 platforms, the 'acpi_disabled' variable is true by default and hence, the above is often seen on ARM64. Given that it can be normal for ACPI to be disabled, make this an informational print rather that a warning.

---
Please note that the motivation for this change is to filter out any warnings that might not be actual issues. We have some automated tests that we run to catch warnings and errors and although we could add this to a list of non critical warnings, it is preferred to make this an informational print.

 drivers/acpi/apei/einj.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/apei/einj.c +0 -0
index 328e8aeece6c..2882450c443e 100644

drivers/acpi/apei/einj.c static int __init einj_init(void)

Quoted 9 lines
drivers/acpi/apei/einj.c +1 -2
@@ -673,7 +673,7 @@ static int __init einj_init(void)
        struct apei_exec_context ctx;
 
        if (acpi_disabled) {
-               pr_warn("ACPI disabled.\n");
+               pr_info("ACPI disabled.\n");
                return -ENODEV;
        }
 
--

Applied as 5.14 material, thanks!