Skip to contentSkip to conversation

hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_3 for RAA228228

PATCH In review Grant Peltier 2 participants 3 messages May 14, 2021 1 message not in the archive Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_3 for RAA228228

The initial version of the RAA228228 datasheet claimed that the device supported READ_TEMPERATURE_3 but not READ_TEMPERATURE_1. It has since been discovered that the datasheet was incorrect. The RAA228228 does support READ_TEMPERATURE_1 but does not support READ_TEMPERATURE_3.

This change fixes an error introduced in commit:
51fb91ed5a6fa855a74731610cd5435d83d6e17f

---
 drivers/hwmon/pmbus/isl68137.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/pmbus/isl68137.c +2 -2
index 40597a9e799f..1a8caff1ac5f 100644
@@ -244,8 +244,8 @@ static int isl68137_probe(struct i2c_client *client)
 		info->read_word_data = raa_dmpvr2_read_word_data;
 		break;
 	case raa_dmpvr2_2rail_nontc:
-		info->func[0] &= ~PMBUS_HAVE_TEMP;
-		info->func[1] &= ~PMBUS_HAVE_TEMP;
+		info->func[0] &= ~PMBUS_HAVE_TEMP3;
+		info->func[1] &= ~PMBUS_HAVE_TEMP3;
 		fallthrough;
 	case raa_dmpvr2_2rail:
 		info->pages = 2;
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 5 lines · Grant Peltier

The initial version of the RAA228228 datasheet claimed that the device supported READ_TEMPERATURE_3 but not READ_TEMPERATURE_1. It has since been discovered that the datasheet was incorrect. The RAA228228 does support READ_TEMPERATURE_1 but does not support READ_TEMPERATURE_3.

Sorry that I have to ask, but do you have some kind of reference for that ? Due to recent events I can unfortunately no longer trust such submissions without some kind of confirmation (for example resend from your Renesas e-mail address if that is possible, or ask someone from a Renesas e-mail address to send a Reviewed-by: / Acked-by:).

Quoted 3 lines

This change fixes an error introduced in commit:
51fb91ed5a6fa855a74731610cd5435d83d6e17f

That should be

Fixes 51fb91ed5a6fa ("hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228")

Thanks,
Guenter

Quoted 21 lines
---
  drivers/hwmon/pmbus/isl68137.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/pmbus/isl68137.c +2 -2
index 40597a9e799f..1a8caff1ac5f 100644
@@ -244,8 +244,8 @@ static int isl68137_probe(struct i2c_client *client)
  		info->read_word_data = raa_dmpvr2_read_word_data;
  		break;
  	case raa_dmpvr2_2rail_nontc:
-		info->func[0] &= ~PMBUS_HAVE_TEMP;
-		info->func[1] &= ~PMBUS_HAVE_TEMP;
+		info->func[0] &= ~PMBUS_HAVE_TEMP3;
+		info->func[1] &= ~PMBUS_HAVE_TEMP3;
  		fallthrough;
  	case raa_dmpvr2_2rail:
  		info->pages = 2;

A message that is not in the archive (sent off-list or not yet received): OS3PR01MB64529FC38D0AD138EC814DCCD2509@OS3PR01MB6452.jpnprd01.prod.outlook.com

maintainer
#3 lore raw
Quoted 4 lines · Adam Vaughn

Hi, Guenter,

Attached is the datasheet behind this change. See section 11 for the revision history.

Great, thanks. I'll apply the patch.

Sorry for the trouble, I wish things were easier :-(.

Guenter

Quoted 60 lines

Regards,

Adam Vaughn
Staff Product Marketing Manager
Core Power Solutions
Mobility Infrastructre & IoT Power Business Division Renesas Electronics America

-----Original Message-----
From: Guenter Roeck <[email protected]> On Behalf Of Guenter Roeck
Sent: Friday, May 14, 2021 4:43 PM
To: Grant Peltier <[email protected]>
Cc: [email protected]; Grant Peltier <[email protected]>; Adam Vaughn <[email protected]>
Subject: Re: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_3 for RAA228228

Quoted 6 lines · Grant Peltier

The initial version of the RAA228228 datasheet claimed that the device supported READ_TEMPERATURE_3 but not READ_TEMPERATURE_1. It has since been discovered that the datasheet was incorrect. The RAA228228 does support
READ_TEMPERATURE_1 but does not support READ_TEMPERATURE_3.

Sorry that I have to ask, but do you have some kind of reference for that ?
Due to recent events I can unfortunately no longer trust such submissions without some kind of confirmation (for example resend from your Renesas e-mail address if that is possible, or ask someone from a Renesas e-mail address to send a Reviewed-by: / Acked-by:).

Quoted 3 lines

This change fixes an error introduced in commit:
51fb91ed5a6fa855a74731610cd5435d83d6e17f

That should be

Fixes 51fb91ed5a6fa ("hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228")

Thanks,
Guenter

Quoted 22 lines
---
   drivers/hwmon/pmbus/isl68137.c | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/hwmon/pmbus/isl68137.c index 40597a9e799f..1a8caff1ac5f 100644

drivers/hwmon/pmbus/isl68137.c +2 -2
@@ -244,8 +244,8 @@ static int isl68137_probe(struct i2c_client *client)
   		info->read_word_data = raa_dmpvr2_read_word_data;
   		break;
   	case raa_dmpvr2_2rail_nontc:
-		info->func[0] &= ~PMBUS_HAVE_TEMP;
-		info->func[1] &= ~PMBUS_HAVE_TEMP;
+		info->func[0] &= ~PMBUS_HAVE_TEMP3;
+		info->func[1] &= ~PMBUS_HAVE_TEMP3;
   		fallthrough;
   	case raa_dmpvr2_2rail:
   		info->pages = 2;