sata: fsl: fix DPRINTK format string
PATCH 1/1 sata: fsl: fix DPRINTK format string
From: Arnd Bergmann <[email protected]>
Printing an __iomem pointer as %x produces a warning:
drivers/ata/sata_fsl.c: In function 'fsl_sata_set_irq_coalescing':drivers/ata/sata_fsl.c:316:17: error: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'void *' [-Werror=format=]
316 | DPRINTK("ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
317 | hcr_base, ioread32(hcr_base + ICC));
| ~~~~~~~~
| |
| void *It's not clear why that pointer should be printed here, but if we do, then using %p is the way to avoid the warnings.
--- drivers/ata/sata_fsl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/sata_fsl.c +1 -1
@@ -313,7 +313,7 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host,DPRINTK ("interrupt coalescing, count = 0x%x, ticks = %x\n" , intr_coalescing_count, intr_coalescing_ticks); -DPRINTK ("ICC register status: (hcr base: 0x%x) = 0x%x\n" , +DPRINTK ("ICC register status: (hcr base: %p) = 0x%x\n" , hcr_base,ioread32 (hcr_base +ICC )); }
Signature · 1 line
2.29.2
Jens Axboe
AppliedQuoted 13 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Printing an
__iomempointer as %x produces a warning:
drivers/ata/sata_fsl.c: In function 'fsl_sata_set_irq_coalescing':drivers/ata/sata_fsl.c:316:17: error: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'void *' [-Werror=format=]316 | DPRINTK("ICC register status: (hcr base: 0x%x) = 0x%x\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 317 | hcr_base, ioread32(hcr_base + ICC)); | ~~~~~~~~ | | | void *
Quoted 2 lines
It's not clear why that pointer should be printed here, but if we do, then using %p is the way to avoid the warnings.
Applied, thanks.
Signature · 1 line
Jens Axboe