Patch "arm64: entry: factor irq triage logic into macros" has been added to the 5.12-stable tree

DISCUSSION Marc Zyngier 2 participants 4 messages May 15, 2021 1 message not in the archive Stable branch

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Marc Zyngier

author

2021-05-15 10:40 UTC #1 lore raw

Hi Sasha,

Quoted 38 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled
arm64: entry: factor irq triage logic into macros
to the 5.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
arm64-entry-factor-irq-triage-logic-into-macros.patch
and it can be found in the queue-5.12 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
commit ec301e4d131aad1648e28305c8d02ae8265a50d7
Author: Marc Zyngier <[email protected]>
Date:   Mon Mar 15 11:56:27 2021 +0000
arm64: entry: factor irq triage logic into macros
[ Upstream commit 9eb563cdabe1d583c262042d5d44cc256f644543 ]
In subsequent patches we'll allow an FIQ handler to be registered, and FIQ exceptions will need to be triaged very similarly to IRQ exceptions. So that we can reuse the existing logic, this patch factors the IRQ triage logic out into macros that can be reused for FIQ.
The macros are named to follow the elX_foo_handler scheme used by the C exception handlers. For consistency with other top-level exception handlers, the kernel_entry/kernel_exit logic is not moved into the macros. As FIQ will use a different C handler, this handler name is provided as an argument to the macros.
There should be no functional change as a result of this patch.

Quoted 11 lines

Signed-off-by Marc Zyngier <[email protected]>
[Mark: rework macros, commit message, rebase before DAIF rework]
Signed-off-by Mark Rutland <[email protected]>
Tested-by Hector Martin <[email protected]>
Cc James Morse <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Will Deacon <[email protected]>
Acked-by Will Deacon <[email protected]>
Link https://lore.kernel.org/r/[email protected] open here
Signed-off-by Catalin Marinas <[email protected]>
Signed-off-by Sasha Levin <[email protected]>

I don't think there is any reason for backporting this patch at this stage. It isn't a fix, and we don't plan to support the feature it subsequently enables in anything older than 5.13.

Unless there is a another pressing reason for adding this patch, I suggest it is dropped from 5.10, 5.11 and 5.12 stable branches.

Thanks,

M.

Signature · 1 line

Without deviation from the norm, progress is not possible.

Sasha Levin

maintainer

2021-05-15 12:36 UTC #2 lore raw

Quoted 54 lines · Marc Zyngier

Hi Sasha,
Quoted 38 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
arm64: entry: factor irq triage logic into macros
to the 5.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
arm64-entry-factor-irq-triage-logic-into-macros.patch
and it can be found in the queue-5.12 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
commit ec301e4d131aad1648e28305c8d02ae8265a50d7
Author: Marc Zyngier <[email protected]>
Date:   Mon Mar 15 11:56:27 2021 +0000
arm64: entry: factor irq triage logic into macros
[ Upstream commit 9eb563cdabe1d583c262042d5d44cc256f644543 ]
In subsequent patches we'll allow an FIQ handler to be registered, and FIQ exceptions will need to be triaged very similarly to IRQ exceptions. So that we can reuse the existing logic, this patch factors the IRQ triage logic out into macros that can be reused for FIQ.
The macros are named to follow the elX_foo_handler scheme used by the C exception handlers. For consistency with other top-level exception handlers, the kernel_entry/kernel_exit logic is not moved into the macros. As FIQ will use a different C handler, this handler name is provided as an argument to the macros.
There should be no functional change as a result of this patch.
Quoted 11 lines
Signed-off-by Marc Zyngier <[email protected]>
[Mark: rework macros, commit message, rebase before DAIF rework]
Signed-off-by Mark Rutland <[email protected]>
Tested-by Hector Martin <[email protected]>
Cc James Morse <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Will Deacon <[email protected]>
Acked-by Will Deacon <[email protected]>
Link https://lore.kernel.org/r/[email protected] open here
Signed-off-by Catalin Marinas <[email protected]>
Signed-off-by Sasha Levin <[email protected]>

Quoted 6 lines

I don't think there is any reason for backporting this patch at this stage. It isn't a fix, and we don't plan to support the feature it subsequently enables in anything older than 5.13.
Unless there is a another pressing reason for adding this patch, I suggest it is dropped from 5.10, 5.11 and 5.12 stable branches.

I'll drop it, thanks!

Signature · 2 lines

Thanks,
Sasha

Sasha Levin

maintainer

2021-05-15 12:37 UTC #3 lore raw

In reply to Marc Zyngier

Quoted 54 lines · Marc Zyngier

Hi Sasha,
Quoted 38 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
arm64: entry: factor irq triage logic into macros
to the 5.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
arm64-entry-factor-irq-triage-logic-into-macros.patch
and it can be found in the queue-5.12 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
commit ec301e4d131aad1648e28305c8d02ae8265a50d7
Author: Marc Zyngier <[email protected]>
Date:   Mon Mar 15 11:56:27 2021 +0000
arm64: entry: factor irq triage logic into macros
[ Upstream commit 9eb563cdabe1d583c262042d5d44cc256f644543 ]
In subsequent patches we'll allow an FIQ handler to be registered, and FIQ exceptions will need to be triaged very similarly to IRQ exceptions. So that we can reuse the existing logic, this patch factors the IRQ triage logic out into macros that can be reused for FIQ.
The macros are named to follow the elX_foo_handler scheme used by the C exception handlers. For consistency with other top-level exception handlers, the kernel_entry/kernel_exit logic is not moved into the macros. As FIQ will use a different C handler, this handler name is provided as an argument to the macros.
There should be no functional change as a result of this patch.
Quoted 11 lines
Signed-off-by Marc Zyngier <[email protected]>
[Mark: rework macros, commit message, rebase before DAIF rework]
Signed-off-by Mark Rutland <[email protected]>
Tested-by Hector Martin <[email protected]>
Cc James Morse <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Will Deacon <[email protected]>
Acked-by Will Deacon <[email protected]>
Link https://lore.kernel.org/r/[email protected] open here
Signed-off-by Catalin Marinas <[email protected]>
Signed-off-by Sasha Levin <[email protected]>

Quoted 6 lines

I don't think there is any reason for backporting this patch at this stage. It isn't a fix, and we don't plan to support the feature it subsequently enables in anything older than 5.13.
Unless there is a another pressing reason for adding this patch, I suggest it is dropped from 5.10, 5.11 and 5.12 stable branches.

Actually, looks like I took it to make 4d6a38da8e79 ("arm64: entry:
always set GIC_PRIO_PSR_I_SET during entry") apply easier, does it make sense to keep it in this scenario?

Signature · 2 lines

Thanks,
Sasha

Marc Zyngier

author

2021-05-15 13:07 UTC #4 lore raw

Quoted 60 lines · Sasha Levin

Quoted 58 lines · Marc Zyngier
Hi Sasha,
Quoted 38 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
arm64: entry: factor irq triage logic into macros
to the 5.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
arm64-entry-factor-irq-triage-logic-into-macros.patch
and it can be found in the queue-5.12 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
commit ec301e4d131aad1648e28305c8d02ae8265a50d7
Author: Marc Zyngier <[email protected]>
Date:   Mon Mar 15 11:56:27 2021 +0000
arm64: entry: factor irq triage logic into macros
[ Upstream commit 9eb563cdabe1d583c262042d5d44cc256f644543 ]
In subsequent patches we'll allow an FIQ handler to be registered, and FIQ exceptions will need to be triaged very similarly to IRQ exceptions. So that we can reuse the existing logic, this patch factors the IRQ triage logic out into macros that can be reused for FIQ.
The macros are named to follow the elX_foo_handler scheme used by the C exception handlers. For consistency with other top-level exception handlers, the kernel_entry/kernel_exit logic is not moved into the macros. As FIQ will use a different C handler, this handler name is provided as an argument to the macros.
There should be no functional change as a result of this patch.
Quoted 11 lines
Signed-off-by Marc Zyngier <[email protected]>
[Mark: rework macros, commit message, rebase before DAIF rework]
Signed-off-by Mark Rutland <[email protected]>
Tested-by Hector Martin <[email protected]>
Cc James Morse <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Will Deacon <[email protected]>
Acked-by Will Deacon <[email protected]>
Link https://lore.kernel.org/r/[email protected] open here
Signed-off-by Catalin Marinas <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
I don't think there is any reason for backporting this patch at this stage. It isn't a fix, and we don't plan to support the feature it subsequently enables in anything older than 5.13.

Quoted 6 lines

Quoted 2 lines
Unless there is a another pressing reason for adding this patch, I suggest it is dropped from 5.10, 5.11 and 5.12 stable branches.
Actually, looks like I took it to make 4d6a38da8e79 ("arm64: entry:
always set GIC_PRIO_PSR_I_SET during entry") apply easier, does it make sense to keep it in this scenario?

Ah, right. In this case, it indeed makes sense to keep it.

Thanks for the clarification,

M.

Signature · 1 line

Without deviation from the norm, progress is not possible.