gpio: gpio-tc3589x: emove platform_set_drvdata() + cleanup probe
PATCH 1/1 gpio: gpio-tc3589x: emove platform_set_drvdata() + cleanup probe
The platform_set_drvdata() call is only useful if we need to retrieve back the private information.
Since the driver doesn't do that, it's not useful to have it.
If this is removed, we can also just do a direct return on devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe.
--- drivers/gpio/gpio-tc3589x.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/gpio/gpio-tc3589x.c +1 -10
@@ -357,16 +357,7 @@ static int tc3589x_gpio_probe(struct platform_device *pdev)return ret; } - ret =devm_gpiochip_add_data (&pdev->dev, &tc3589x_gpio->chip, - tc3589x_gpio); -if (ret) { -dev_err (&pdev->dev,"unable to add gpiochip: %d\n" , ret); -return ret; - } - -platform_set_drvdata (pdev, tc3589x_gpio); - -return 0 ; +return devm_gpiochip_add_data (&pdev->dev, &tc3589x_gpio->chip, tc3589x_gpio); }static struct platform_driver tc3589x_gpio_driver = {
Signature · 1 line
2.31.1
Bartosz Golaszewski
AppliedQuoted 37 lines · Alexandru Ardelean
The
platform_set_drvdata()call is only useful if we need to retrieve back the private information.
Since the driver doesn't do that, it's not useful to have it.If this is removed, we can also just do a direct return on
devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe.Signed-off-by Alexandru Ardelean <[email protected]>--- drivers/gpio/gpio-tc3589x.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)drivers/gpio/gpio-tc3589x.c +1
-11@@ -357,16 +357,7 @@ static int tc3589x_gpio_probe(struct platform_device *pdev)return ret; } - ret =devm_gpiochip_add_data (&pdev->dev, &tc3589x_gpio->chip, - tc3589x_gpio); -if (ret) { -dev_err (&pdev->dev,"unable to add gpiochip: %d\n" , ret); -return ret; - } - -platform_set_drvdata (pdev, tc3589x_gpio); - -return 0 ; +return devm_gpiochip_add_data (&pdev->dev, &tc3589x_gpio->chip, tc3589x_gpio); }static struct platform_driver tc3589x_gpio_driver = { --
Quoted 2 lines
2.31.1
Applied, thanks!
Bart