Skip to contentSkip to conversation

hwmon:q54sj108a2: the PMBUS_MFR_ID is actually 6 chars instead of 5

PATCH In review Chu Lin 2 participants 4 messages May 17, 2021 Hardware monitoring

lore
Share & tools
lore

Chu Lin

author
#0 lore raw

PATCH 1/1 hwmon:q54sj108a2: the PMBUS_MFR_ID is actually 6 chars instead of 5

The PMBUS_MFR_ID block is actually 6 chars for q54sj108a2. /sys/bus/i2c/drivers/q54sj108a2_test# iotools smbus_read8 $BUS $ADDR 0x99 0x06

Tested: Devices are able to bind to the q54sj108a2 driver successfully.

---
 drivers/hwmon/pmbus/q54sj108a2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/pmbus/q54sj108a2.c +1 -1
index aec512766c31..0976268b2670 100644
@@ -299,7 +299,7 @@ static int q54sj108a2_probe(struct i2c_client *client)
 		dev_err(&client->dev, "Failed to read Manufacturer ID\n");
 		return ret;
 	}
-	if (ret != 5 || strncmp(buf, "DELTA", 5)) {
+	if (ret != 6 || strncmp(buf, "DELTA", 5)) {
 		buf[ret] = '\0';
 		dev_err(dev, "Unsupported Manufacturer ID '%s'\n", buf);
 		return -ENODEV;
Signature · 1 line
2.31.1.751.gd2f1c929bd-goog
maintainer
#1 lore raw
Quoted 4 lines · Chu Lin

The PMBUS_MFR_ID block is actually 6 chars for q54sj108a2. /sys/bus/i2c/drivers/q54sj108a2_test# iotools smbus_read8 $BUS $ADDR 0x99 0x06

What is the 6th character ? Should it be checked as well ?

Quoted 21 lines

Tested: Devices are able to bind to the q54sj108a2 driver successfully.

---
  drivers/hwmon/pmbus/q54sj108a2.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/pmbus/q54sj108a2.c +1 -1
index aec512766c31..0976268b2670 100644
@@ -299,7 +299,7 @@ static int q54sj108a2_probe(struct i2c_client *client)
  		dev_err(&client->dev, "Failed to read Manufacturer ID\n");
  		return ret;
  	}
-	if (ret != 5 || strncmp(buf, "DELTA", 5)) {
+	if (ret != 6 || strncmp(buf, "DELTA", 5)) {
  		buf[ret] = '\0';
  		dev_err(dev, "Unsupported Manufacturer ID '%s'\n", buf);
  		return -ENODEV;
author
#2 lore raw
Quoted 9 lines · Guenter Roeck
Quoted 4 lines · Chu Lin

The PMBUS_MFR_ID block is actually 6 chars for q54sj108a2. /sys/bus/i2c/drivers/q54sj108a2_test# iotools smbus_read8 $BUS $ADDR 0x99 0x06

What is the 6th character ? Should it be checked as well ?

The 6th char is \0. Do you suggest we check that as well?

Thanks,
Chu

Quoted 22 lines
Quoted 21 lines

Tested: Devices are able to bind to the q54sj108a2 driver successfully.

---
  drivers/hwmon/pmbus/q54sj108a2.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/pmbus/q54sj108a2.c +1 -1
index aec512766c31..0976268b2670 100644
@@ -299,7 +299,7 @@ static int q54sj108a2_probe(struct i2c_client *client)
              dev_err(&client->dev, "Failed to read Manufacturer ID\n");
              return ret;
      }
-     if (ret != 5 || strncmp(buf, "DELTA", 5)) {
+     if (ret != 6 || strncmp(buf, "DELTA", 5)) {
              buf[ret] = '\0';
              dev_err(dev, "Unsupported Manufacturer ID '%s'\n", buf);
              return -ENODEV;
maintainer
#3 lore raw
Quoted 12 lines · Chu Lin
Quoted 9 lines · Guenter Roeck
Quoted 4 lines · Chu Lin

The PMBUS_MFR_ID block is actually 6 chars for q54sj108a2. /sys/bus/i2c/drivers/q54sj108a2_test# iotools smbus_read8 $BUS $ADDR 0x99 0x06

What is the 6th character ? Should it be checked as well ?

The 6th char is \0. Do you suggest we check that as well?

No, that would be a bit pointless. I'll apply the patch.

Thanks,
Guenter

Quoted 25 lines

Thanks,
Chu

Quoted 22 lines
Quoted 21 lines

Tested: Devices are able to bind to the q54sj108a2 driver successfully.

---
   drivers/hwmon/pmbus/q54sj108a2.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/pmbus/q54sj108a2.c +1 -1
index aec512766c31..0976268b2670 100644
@@ -299,7 +299,7 @@ static int q54sj108a2_probe(struct i2c_client *client)
               dev_err(&client->dev, "Failed to read Manufacturer ID\n");
               return ret;
       }
-     if (ret != 5 || strncmp(buf, "DELTA", 5)) {
+     if (ret != 6 || strncmp(buf, "DELTA", 5)) {
               buf[ret] = '\0';
               dev_err(dev, "Unsupported Manufacturer ID '%s'\n", buf);
               return -ENODEV;