Skip to contentSkip to conversation

staging: emxx_udc: Fixed coding style in places where lines should not end in '('

PATCH In review Hriday Hegde 3 participants 5 messages May 20, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: emxx_udc: Fixed coding style in places where lines should not end in '('

The fixes were for the following checkpatch outputs:

CHECK: Lines should not end with a '('
1076: FILE: drivers/staging/emxx_udc/emxx_udc.c:1076:
+ _nbu2ss_writel(

CHECK: Lines should not end with a '('
1228: FILE: drivers/staging/emxx_udc/emxx_udc.c:1228:
+ length = _nbu2ss_readl(

CHECK: Lines should not end with a '('
1465: FILE: drivers/staging/emxx_udc/emxx_udc.c:1465:
+ regdata = _nbu2ss_readl(

---
 drivers/staging/emxx_udc/emxx_udc.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/staging/emxx_udc/emxx_udc.c +4 -6
index 741147a4f0fe..8364316c1d25 100644
@@ -1073,8 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep,
 		i_word_length = length / sizeof(u32);
 		if (i_word_length > 0) {
 			for (i = 0; i < i_word_length; i++) {
-				_nbu2ss_writel(
-					&preg->EP_REGS[ep->epnum - 1].EP_WRITE,
+				_nbu2ss_writel(&preg->EP_REGS[ep->epnum - 1]
+					.EP_WRITE,
 					p_buf_32->dw);
 
 				p_buf_32++;
@@ -1225,8 +1225,7 @@ static void _nbu2ss_restert_transfer(struct nbu2ss_ep *ep)
 		return;
 
 	if (ep->epnum > 0) {
-		length = _nbu2ss_readl(
-			&ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT);
+		length = _nbu2ss_readl(&ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT);
 
 		length &= EPN_LDATA;
 		if (length < ep->ep.maxpacket)
@@ -1462,8 +1461,7 @@ static void _nbu2ss_epn_set_stall(struct nbu2ss_udc *udc,
 		for (limit_cnt = 0
 			; limit_cnt < IN_DATA_EMPTY_COUNT
 			; limit_cnt++) {
-			regdata = _nbu2ss_readl(
-				&preg->EP_REGS[ep->epnum - 1].EP_STATUS);
+			regdata = _nbu2ss_readl(&preg->EP_REGS[ep->epnum - 1].EP_STATUS);
 
 			if ((regdata & EPN_IN_DATA) == 0)
 				break;
Signature · 1 line
2.25.1
#1 lore raw
Quoted 24 lines · Hriday Hegde

The fixes were for the following checkpatch outputs:

CHECK: Lines should not end with a '('
1076: FILE: drivers/staging/emxx_udc/emxx_udc.c:1076:

(quoted diff) +1 -0
+				_nbu2ss_writel(

CHECK: Lines should not end with a '('
1228: FILE: drivers/staging/emxx_udc/emxx_udc.c:1228:

(quoted diff) +1 -0
+		length = _nbu2ss_readl(

CHECK: Lines should not end with a '('
1465: FILE: drivers/staging/emxx_udc/emxx_udc.c:1465:

(quoted diff) +1 -0
+			regdata = _nbu2ss_readl(
---
 drivers/staging/emxx_udc/emxx_udc.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/staging/emxx_udc/emxx_udc.c +0 -0
index 741147a4f0fe..8364316c1d25 100644

drivers/staging/emxx_udc/emxx_udc.c static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep, · line 1077

Quoted 7 lines
drivers/staging/emxx_udc/emxx_udc.c +2 -2
@@ -1073,8 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep,
 		i_word_length = length / sizeof(u32);
 		if (i_word_length > 0) {
 			for (i = 0; i < i_word_length; i++) {
-				_nbu2ss_writel(
-					&preg->EP_REGS[ep->epnum - 1].EP_WRITE,
+				_nbu2ss_writel(&preg->EP_REGS[ep->epnum - 1]
+					.EP_WRITE,

Please don't break the line at ".", that makes this really hard to follow.

thanks,

greg k-h

#2 lore raw
Quoted 35 lines · Greg Kroah-Hartman
Quoted 24 lines · Hriday Hegde

The fixes were for the following checkpatch outputs:

CHECK: Lines should not end with a '('
1076: FILE: drivers/staging/emxx_udc/emxx_udc.c:1076:

(quoted diff) +1 -0
+				_nbu2ss_writel(

CHECK: Lines should not end with a '('
1228: FILE: drivers/staging/emxx_udc/emxx_udc.c:1228:

(quoted diff) +1 -0
+		length = _nbu2ss_readl(

CHECK: Lines should not end with a '('
1465: FILE: drivers/staging/emxx_udc/emxx_udc.c:1465:

(quoted diff) +1 -0
+			regdata = _nbu2ss_readl(
---
 drivers/staging/emxx_udc/emxx_udc.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/staging/emxx_udc/emxx_udc.c +0 -0
index 741147a4f0fe..8364316c1d25 100644

drivers/staging/emxx_udc/emxx_udc.c static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep, · line 1077

Quoted 7 lines
drivers/staging/emxx_udc/emxx_udc.c +2 -2
@@ -1073,8 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep,
 		i_word_length = length / sizeof(u32);
 		if (i_word_length > 0) {
 			for (i = 0; i < i_word_length; i++) {
-				_nbu2ss_writel(
-					&preg->EP_REGS[ep->epnum - 1].EP_WRITE,
+				_nbu2ss_writel(&preg->EP_REGS[ep->epnum - 1]
+					.EP_WRITE,

Please don't break the line at ".", that makes this really hard to follow.

Quoted 3 lines

thanks,

greg k-h

Ok will keep that in mind. I don't yet see a way to make this into the proper coding style without losing readability.

Thanks
Hriday

#3 lore raw
In reply to Hriday Hegde
Quoted 24 lines · Hriday Hegde

The fixes were for the following checkpatch outputs:

CHECK: Lines should not end with a '('
1076: FILE: drivers/staging/emxx_udc/emxx_udc.c:1076:

(quoted diff) +1 -0
+				_nbu2ss_writel(

CHECK: Lines should not end with a '('
1228: FILE: drivers/staging/emxx_udc/emxx_udc.c:1228:

(quoted diff) +1 -0
+		length = _nbu2ss_readl(

CHECK: Lines should not end with a '('
1465: FILE: drivers/staging/emxx_udc/emxx_udc.c:1465:

(quoted diff) +1 -0
+			regdata = _nbu2ss_readl(
---
 drivers/staging/emxx_udc/emxx_udc.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/staging/emxx_udc/emxx_udc.c +0 -0
index 741147a4f0fe..8364316c1d25 100644

drivers/staging/emxx_udc/emxx_udc.c static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep, · line 1078

Quoted 8 lines
drivers/staging/emxx_udc/emxx_udc.c +2 -2
@@ -1073,8 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep,
 		i_word_length = length / sizeof(u32);
 		if (i_word_length > 0) {
 			for (i = 0; i < i_word_length; i++) {
-				_nbu2ss_writel(
-					&preg->EP_REGS[ep->epnum - 1].EP_WRITE,
+				_nbu2ss_writel(&preg->EP_REGS[ep->epnum - 1]
+					.EP_WRITE,
 					p_buf_32->dw);

No, this is worse than before.

regards,
dan carpenter

#4 lore raw
Quoted 35 lines · Dan Carpenter
Quoted 24 lines · Hriday Hegde

The fixes were for the following checkpatch outputs:

CHECK: Lines should not end with a '('
1076: FILE: drivers/staging/emxx_udc/emxx_udc.c:1076:

(quoted diff) +1 -0
+				_nbu2ss_writel(

CHECK: Lines should not end with a '('
1228: FILE: drivers/staging/emxx_udc/emxx_udc.c:1228:

(quoted diff) +1 -0
+		length = _nbu2ss_readl(

CHECK: Lines should not end with a '('
1465: FILE: drivers/staging/emxx_udc/emxx_udc.c:1465:

(quoted diff) +1 -0
+			regdata = _nbu2ss_readl(
---
 drivers/staging/emxx_udc/emxx_udc.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/staging/emxx_udc/emxx_udc.c +0 -0
index 741147a4f0fe..8364316c1d25 100644

drivers/staging/emxx_udc/emxx_udc.c static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep, · line 1078

Quoted 8 lines
drivers/staging/emxx_udc/emxx_udc.c +2 -2
@@ -1073,8 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep,
 		i_word_length = length / sizeof(u32);
 		if (i_word_length > 0) {
 			for (i = 0; i < i_word_length; i++) {
-				_nbu2ss_writel(
-					&preg->EP_REGS[ep->epnum - 1].EP_WRITE,
+				_nbu2ss_writel(&preg->EP_REGS[ep->epnum - 1]
+					.EP_WRITE,
 					p_buf_32->dw);

No, this is worse than before.

Quoted 3 lines

regards,
dan carpenter

Yes sorry, didn't really take into account readability.

Thanks
Hriday