Skip to contentSkip to conversation

gpio: gpio-xgene: simplify probe, return devm_gpiochip_add_data() directly

PATCH Applied Alexandru Ardelean 2 participants 3 messages May 21, 2021 – May 24, 2021 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: gpio-xgene: simplify probe, return devm_gpiochip_add_data() directly

The handling of the return value from devm_gpiochip_add_data() is a bit redundant. It prints messages on error and success cases. While the success message may be useful, it is more in the area of log spam, and these can be printed with other forms of kernel logging.

This change does a direct return with devm_gpiochip_add_data() in the probe function.

The platform_set_drvdata() is needed, as this driver uses the stored private date in the PM suspend/resume routines.

---
 drivers/gpio/gpio-xgene.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/gpio/gpio-xgene.c +1 -10
index 532b0df8a1f2..fb4b0c67aeef 100644
@@ -159,7 +159,6 @@ static SIMPLE_DEV_PM_OPS(xgene_gpio_pm, xgene_gpio_suspend, xgene_gpio_resume);
 static int xgene_gpio_probe(struct platform_device *pdev)
 {
 	struct xgene_gpio *gpio;
-	int err = 0;
 
 	gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
 	if (!gpio)
@@ -183,15 +182,7 @@ static int xgene_gpio_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, gpio);
 
-	err = devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);
-	if (err) {
-		dev_err(&pdev->dev,
-			"failed to register gpiochip.\n");
-		return err;
-	}
-
-	dev_info(&pdev->dev, "X-Gene GPIO driver registered.\n");
-	return 0;
+	return devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);
 }
 
 static const struct of_device_id xgene_gpio_of_match[] = {
Signature · 1 line
2.31.1
#1 lore raw
Quoted 47 lines · Alexandru Ardelean

The handling of the return value from devm_gpiochip_add_data() is a bit redundant. It prints messages on error and success cases. While the success message may be useful, it is more in the area of log spam, and these can be printed with other forms of kernel logging.

This change does a direct return with devm_gpiochip_add_data() in the probe function.

The platform_set_drvdata() is needed, as this driver uses the stored private date in the PM suspend/resume routines.

---
 drivers/gpio/gpio-xgene.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/gpio/gpio-xgene.c +1 -11
index 532b0df8a1f2..fb4b0c67aeef 100644
@@ -159,7 +159,6 @@ static SIMPLE_DEV_PM_OPS(xgene_gpio_pm, xgene_gpio_suspend, xgene_gpio_resume);
 static int xgene_gpio_probe(struct platform_device *pdev)
 {
        struct xgene_gpio *gpio;
-       int err = 0;
 
        gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
        if (!gpio)
@@ -183,15 +182,7 @@ static int xgene_gpio_probe(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, gpio);
 
-       err = devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);
-       if (err) {
-               dev_err(&pdev->dev,
-                       "failed to register gpiochip.\n");
-               return err;
-       }
-
-       dev_info(&pdev->dev, "X-Gene GPIO driver registered.\n");
-       return 0;
+       return devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);
 }
 
 static const struct of_device_id xgene_gpio_of_match[] = {
--
Quoted 2 lines

2.31.1

Applied, thanks.

For the future: the subject should be: "gpio: xgene: ..." here and everywhere else.

Bart

#2 lore raw
Quoted 55 lines · Bartosz Golaszewski
Quoted 47 lines · Alexandru Ardelean

The handling of the return value from devm_gpiochip_add_data() is a bit redundant. It prints messages on error and success cases. While the success message may be useful, it is more in the area of log spam, and these can be printed with other forms of kernel logging.

This change does a direct return with devm_gpiochip_add_data() in the probe function.

The platform_set_drvdata() is needed, as this driver uses the stored private date in the PM suspend/resume routines.

---
 drivers/gpio/gpio-xgene.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/gpio/gpio-xgene.c +1 -11
index 532b0df8a1f2..fb4b0c67aeef 100644
@@ -159,7 +159,6 @@ static SIMPLE_DEV_PM_OPS(xgene_gpio_pm, xgene_gpio_suspend, xgene_gpio_resume);
 static int xgene_gpio_probe(struct platform_device *pdev)
 {
        struct xgene_gpio *gpio;
-       int err = 0;
 
        gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
        if (!gpio)
@@ -183,15 +182,7 @@ static int xgene_gpio_probe(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, gpio);
 
-       err = devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);
-       if (err) {
-               dev_err(&pdev->dev,
-                       "failed to register gpiochip.\n");
-               return err;
-       }
-
-       dev_info(&pdev->dev, "X-Gene GPIO driver registered.\n");
-       return 0;
+       return devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);
 }
 
 static const struct of_device_id xgene_gpio_of_match[] = {
--
Quoted 2 lines

2.31.1

Applied, thanks.

Quoted 2 lines

For the future: the subject should be: "gpio: xgene: ..." here and everywhere else.

ack
will keep that in mind

thanks :)
Alex

Quoted 2 lines

Bart