Skip to contentSkip to conversation

regulator: bd718x7: Fix the BUCK7 voltage setting on BD71837

PATCH Superseded Matti Vaittinen 2 participants 2 messages May 24, 2021 – Jun 3, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: bd718x7: Fix the BUCK7 voltage setting on BD71837

The BD71837 voltages for other regulators except the first 4 BUCKs should be forbidden when regulator is enabled. There may be out-of-spec voltage spikes if the voltage is changed when these "non DVS" bucks are enabled. This restriction was accidentally removed when the LDO voltage change was allowed for BD71847. (It was not noticed that the BD71837 BUCK7 used same voltage setting function as LDOs).

Additionally this bug causes oncorrect voltage monitoring change if BUCK7 voltage is changed when it is enabled.

Fixes 9bcbabafa19b ("regulator: bd718x7: remove voltage change restriction from BD71847 LDOs")
---
 drivers/regulator/bd718x7-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/bd718x7-regulator.c +1 -1
index e61295b30503..b1eb46961993 100644
@@ -334,7 +334,7 @@ BD718XX_OPS(bd71837_buck_regulator_ops, regulator_list_voltage_linear_range,
 	    NULL);
 
 BD718XX_OPS(bd71837_buck_regulator_nolinear_ops, regulator_list_voltage_table,
-	    regulator_map_voltage_ascend, bd718xx_set_voltage_sel_restricted,
+	    regulator_map_voltage_ascend, bd71837_set_voltage_sel_restricted,
 	    regulator_get_voltage_sel_regmap, regulator_set_voltage_time_sel,
 	    NULL);
 /*

base-commit: 55f0e3d2ed3d198f639dcbef0366732fa7c71816

Signature · 14 lines
2.25.4


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 
maintainer
#1 lore raw
Quoted 8 lines · Matti Vaittinen

The BD71837 voltages for other regulators except the first 4 BUCKs should be forbidden when regulator is enabled. There may be out-of-spec voltage spikes if the voltage is changed when these "non DVS" bucks are enabled. This restriction was accidentally removed when the LDO voltage change was allowed for BD71847. (It was not noticed that the BD71837 BUCK7 used same voltage setting function as LDOs).

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: bd718x7: Fix the BUCK7 voltage setting on BD71837

      commit: bc537e65b09a05923f98a31920d1ab170e648dba

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark