Skip to contentSkip to conversation

staging: emxx_udc: fix alignment issues

PATCH In review Harold Mertzweiller 2 participants 3 messages May 24, 2021 – May 27, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: emxx_udc: fix alignment issues

Three function calls can now be properly formatted inside the 100 characters limit.

---
 drivers/staging/emxx_udc/emxx_udc.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
drivers/staging/emxx_udc/emxx_udc.c +4 -7
index ecc5c9da9027..b6abd3770e81 100644
@@ -1073,9 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep,
 		i_word_length = length / sizeof(u32);
 		if (i_word_length > 0) {
 			for (i = 0; i < i_word_length; i++) {
-				_nbu2ss_writel(
-					&preg->EP_REGS[ep->epnum - 1].EP_WRITE,
-					p_buf_32->dw);
+				_nbu2ss_writel(&preg->EP_REGS[ep->epnum - 1].EP_WRITE,
+					       p_buf_32->dw);
 
 				p_buf_32++;
 			}
@@ -1225,8 +1224,7 @@ static void _nbu2ss_restert_transfer(struct nbu2ss_ep *ep)
 		return;
 
 	if (ep->epnum > 0) {
-		length = _nbu2ss_readl(
-			&ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT);
+		length = _nbu2ss_readl(&ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT);
 
 		length &= EPN_LDATA;
 		if (length < ep->ep.maxpacket)
@@ -1462,8 +1460,7 @@ static void _nbu2ss_epn_set_stall(struct nbu2ss_udc *udc,
 		for (limit_cnt = 0
 			; limit_cnt < IN_DATA_EMPTY_COUNT
 			; limit_cnt++) {
-			regdata = _nbu2ss_readl(
-				&preg->EP_REGS[ep->epnum - 1].EP_STATUS);
+			regdata = _nbu2ss_readl(&preg->EP_REGS[ep->epnum - 1].EP_STATUS);
 
 			if ((regdata & EPN_IN_DATA) == 0)
 				break;
Signature · 1 line
2.20.1
#1 lore raw

Hi Harold,

Quoted 4 lines · Harold Mertzweiller

Three function calls can now be properly formatted inside the 100 characters limit.

Thanks for your patch!

Quoted 1 line
 drivers/staging/emxx_udc/emxx_udc.c | 11 ++++-------

I'm so happy people are improving this driver! Is it working well on your hardware?
Do you think it's ready to migrate out of staging?

Thanks again!

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#2 lore raw
Quoted 16 lines · Geert Uytterhoeven

Hi Harold,

Quoted 4 lines · Harold Mertzweiller

Three function calls can now be properly formatted inside the 100 characters limit.

Thanks for your patch!

Quoted 1 line
 drivers/staging/emxx_udc/emxx_udc.c | 11 ++++-------

I'm so happy people are improving this driver! Is it working well on your hardware?
Do you think it's ready to migrate out of staging?

Quoted 6 lines

Thanks again!

Gr{oetje,eeting}s,

Geert

Hi Geert,

I sent this patch as part of the Eudyptula challenge. I just wanted to improve the coding style of any driver and unfortunately I don't use it.

Have a great day,
Harold