clk: clk_versaclock: Add support for versaclock driver
PATCH 1/1 clk: clk_versaclock: Add support for versaclock driver
The driver is based on the Versaclock driver from the Linux code, but do differences in the clock API between them, some pieces had to change.
This driver creates a mux, pfd, pll, and a series of fod ouputs.
Rate Usecnt Name
------------------------------------------
25000000 0 `-- x304-clock 25000000 0 `-- [email protected] 25000000 0 |-- [email protected] 2800000000 0 | `-- [email protected] 33333333 0 | |-- [email protected] 33333333 0 | | `-- [email protected] 33333333 0 | |-- [email protected] 33333333 0 | | `-- [email protected] 50000000 0 | |-- [email protected] 50000000 0 | | `-- [email protected] 125000000 0 | `-- [email protected] 125000000 0 | `-- [email protected] 25000000 0 `-- [email protected]_sel_i2cb
A translation function is added so the references to <&versaclock X> get routed to the corresponding [email protected].
drivers/clk/Kconfig +8 -0
@@ -197,4 +197,12 @@ config SANDBOX_CLK_CCF Enable this option if you want to test the Linux kernel's Common Clock Framework [CCF] code in U-Boot's Sandbox clock driver. +config CLK_VERSACLOCK + tristate "Enable VersaClock 5/6 devices" + depends on CLK + depends on OF_CONTROL + help + This driver supports the IDT VersaClock 5 and VersaClock 6 + programmable clock generators. + endmenu
drivers/clk/Makefile +1 -0
@@ -51,3 +51,4 @@ obj-$(CONFIG_SANDBOX_CLK_CCF) += clk_sandbox_ccf.o obj-$(CONFIG_STM32H7) += clk_stm32h7.o obj-$(CONFIG_CLK_VERSAL) += clk_versal.o obj-$(CONFIG_CLK_CDCE9XX) += clk-cdce9xx.o +obj-$(CONFIG_CLK_VERSACLOCK) +=clk_versaclock.o
drivers/clk/clk_versaclock.c new file +1025 -0
1,025 lines not on this page · raw message
Signature · 1 line
2.25.1
Quoted 2 lines · Adam Ford
The driver is based on the Versaclock driver from the Linux code, but do differences in the clock API between them, some pieces had to change.
s/do/due to/ ?
s/had to change/had to be changed/
Quoted 17 lines
This driver creates a mux, pfd, pll, and a series of fod ouputs.
Rate Usecnt Name
------------------------------------------25000000 0 `-- x304-clock 25000000 0 `-- [email protected] 25000000 0 |-- [email protected] 2800000000 0 | `-- [email protected] 33333333 0 | |-- [email protected] 33333333 0 | | `-- [email protected] 33333333 0 | |-- [email protected] 33333333 0 | | `-- [email protected] 50000000 0 | |-- [email protected] 50000000 0 | | `-- [email protected] 125000000 0 | `-- [email protected] 125000000 0 | `-- [email protected] 25000000 0 `-- [email protected]_sel_i2cb
Quoted 4 lines
A translation function is added so the references to <&versaclock X> get routed to the corresponding [email protected].
Signed-off-by Adam Ford <[email protected]>
I've been reviewing this patch and it looks mostly OK to me except for a few notes below, mostly minor ones. However my knowledge of the U-Boot driver model is minimal, thus I couldn't go in depth in the most interesting and critical part of Adam's work, i.e. the adaptations for the U-Boot codebase. I'm afraid I cannot do more.
drivers/clk/Makefile obj-$(CONFIG_SANDBOX_CLK_CCF) += clk_sandbox_ccf.o · line 54
Quoted 9 lines
drivers/clk/Makefile +1
-0@@ -51,3 +51,4 @@ obj-$(CONFIG_SANDBOX_CLK_CCF) += clk_sandbox_ccf.o obj-$(CONFIG_STM32H7) += clk_stm32h7.o obj-$(CONFIG_CLK_VERSAL) += clk_versal.o obj-$(CONFIG_CLK_CDCE9XX) += clk-cdce9xx.o +obj-$(CONFIG_CLK_VERSACLOCK) +=clk_versaclock.o
Nit: space after '+='.
Quoted 16 lines
drivers/clk/clk_versaclock.c new file +10
-0@@ -0,0 +1,1025 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Driver for IDT Versaclock 5/6 +* +* Derived from code Copyright (C) 2017 Marek Vasut <[email protected]> +*/ + +#include <common.h> +#include <clk.h> +#include <clk-uclass.h>
drivers/clk/clk_versaclock.c line 20
Quoted 10 lines
drivers/clk/clk_versaclock.c new file +10
-0+#include <dm.h> +#include <errno.h> +#include <i2c.h> +#include <dm/device_compat.h> +#include <log.h> +#include <linux/clk-provider.h> +#include <linux/kernel.h> +#include <linux/math64.h> + +#include <dt-bindings/clk/versaclock.h>
Missing file?
Quoted 10 lines
drivers/clk/clk_versaclock.c new file +10
-0+ +/* VersaClock5 registers */ +#define VC5_OTP_CONTROL 0x00 + +/* Factory-reserved register block */ +#define VC5_RSVD_DEVICE_ID 0x01 +#define VC5_RSVD_ADC_GAIN_7_0 0x02 +#define VC5_RSVD_ADC_GAIN_15_8 0x03 +#define VC5_RSVD_ADC_OFFSET_7_0 0x04 +#define VC5_RSVD_ADC_OFFSET_15_8 0x05
drivers/clk/clk_versaclock.c line 40
Quoted 10 lines
drivers/clk/clk_versaclock.c new file +10
-0+#define VC5_RSVD_TEMPY 0x06 +#define VC5_RSVD_OFFSET_TBIN 0x07 +#define VC5_RSVD_GAIN 0x08 +#define VC5_RSVD_TEST_NP 0x09 +#define VC5_RSVD_UNUSED 0x0a +#define VC5_RSVD_BANDGAP_TRIM_UP 0x0b +#define VC5_RSVD_BANDGAP_TRIM_DN 0x0c +#define VC5_RSVD_CLK_R_12_CLK_AMP_4 0x0d +#define VC5_RSVD_CLK_R_34_CLK_AMP_4 0x0e +#define VC5_RSVD_CLK_AMP_123 0x0f
I wonder whether it really makes sense to define so many registers that are not used in the driver. But it's done the same way in the Linux driver, and it doesn't hurt much, so I'll be fine with or without them.
[...]
drivers/clk/clk_versaclock.c line 839
Quoted 9 lines
drivers/clk/clk_versaclock.c new file +9
-0+static const struct udevice_id versaclock_ids[] = { + { .compatible ="idt,5p49v5923" , .data = (ulong)&idt_5p49v5923_info }, + { .compatible ="idt,5p49v5925" , .data = (ulong)&idt_5p49v5925_info }, + { .compatible ="idt,5p49v5933" , .data = (ulong)&idt_5p49v5933_info }, + { .compatible ="idt,5p49v5935" , .data = (ulong)&idt_5p49v5935_info }, + { .compatible ="idt,5p49v6901" , .data = (ulong)&idt_5p49v6901_info }, + { .compatible ="idt,5p49v6965" , .data = (ulong)&idt_5p49v6965_info }, + {}, +};
Why not putting this array below, right before the U_BOOT_DRIVER() call where it is used, similarly to the Linux driver?
Signature · 1 line
Luca
Quoted 7 lines · Luca Ceresoli
Quoted 2 lines · Adam Ford
The driver is based on the Versaclock driver from the Linux code, but do differences in the clock API between them, some pieces had to change.
s/do/due to/ ?
s/had to change/had to be changed/
I am usually more careful about grammar. I must have been tired. :-)
Quoted 29 lines
Quoted 18 lines
This driver creates a mux, pfd, pll, and a series of fod ouputs.
Rate Usecnt Name
------------------------------------------25000000 0 `-- x304-clock 25000000 0 `-- [email protected] 25000000 0 |-- [email protected] 2800000000 0 | `-- [email protected] 33333333 0 | |-- [email protected] 33333333 0 | | `-- [email protected] 33333333 0 | |-- [email protected] 33333333 0 | | `-- [email protected] 50000000 0 | |-- [email protected] 50000000 0 | | `-- [email protected] 125000000 0 | `-- [email protected] 125000000 0 | `-- [email protected] 25000000 0 `-- [email protected]_sel_i2cbQuoted 4 lines
A translation function is added so the references to <&versaclock X> get routed to the corresponding [email protected].
Signed-off-by Adam Ford <[email protected]>I've been reviewing this patch and it looks mostly OK to me except for a few notes below, mostly minor ones. However my knowledge of the U-Boot driver model is minimal, thus I couldn't go in depth in the most interesting and critical part of Adam's work, i.e. the adaptations for the U-Boot codebase. I'm afraid I cannot do more.
Quoted 11 lines
drivers/clk/Makefile obj-$(CONFIG_SANDBOX_CLK_CCF) += clk_sandbox_ccf.o · line 54
Quoted 9 lines
drivers/clk/Makefile +1
-0@@ -51,3 +51,4 @@ obj-$(CONFIG_SANDBOX_CLK_CCF) += clk_sandbox_ccf.o obj-$(CONFIG_STM32H7) += clk_stm32h7.o obj-$(CONFIG_CLK_VERSAL) += clk_versal.o obj-$(CONFIG_CLK_CDCE9XX) += clk-cdce9xx.o +obj-$(CONFIG_CLK_VERSACLOCK) +=clk_versaclock.oNit: space after '+='.
make sense.
Quoted 21 lines
Quoted 21 lines
drivers/clk/clk_versaclock.c new file +14
-0@@ -0,0 +1,1025 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Driver for IDT Versaclock 5/6 +* +* Derived from code Copyright (C) 2017 Marek Vasut <[email protected]> +*/ + +#include <common.h> +#include <clk.h> +#include <clk-uclass.h> +#include <dm.h> +#include <errno.h> +#include <i2c.h> +#include <dm/device_compat.h>
Quoted 8 lines
drivers/clk/clk_versaclock.c line 20
Quoted 6 lines
drivers/clk/clk_versaclock.c new file +6
-0+#include <log.h> +#include <linux/clk-provider.h> +#include <linux/kernel.h> +#include <linux/math64.h> + +#include <dt-bindings/clk/versaclock.h> Missing file?
This was included a while ago in order to allow the device trees to build.
Quoted 17 lines
Quoted 17 lines
drivers/clk/clk_versaclock.c new file +16
-0+ +/* VersaClock5 registers */ +#define VC5_OTP_CONTROL 0x00 + +/* Factory-reserved register block */ +#define VC5_RSVD_DEVICE_ID 0x01 +#define VC5_RSVD_ADC_GAIN_7_0 0x02 +#define VC5_RSVD_ADC_GAIN_15_8 0x03 +#define VC5_RSVD_ADC_OFFSET_7_0 0x04 +#define VC5_RSVD_ADC_OFFSET_15_8 0x05 +#define VC5_RSVD_TEMPY 0x06 +#define VC5_RSVD_OFFSET_TBIN 0x07 +#define VC5_RSVD_GAIN 0x08 +#define VC5_RSVD_TEST_NP 0x09 +#define VC5_RSVD_UNUSED 0x0a +#define VC5_RSVD_BANDGAP_TRIM_UP 0x0b
Quoted 8 lines
drivers/clk/clk_versaclock.c line 40
Quoted 4 lines
drivers/clk/clk_versaclock.c new file +4
-0+#define VC5_RSVD_BANDGAP_TRIM_DN 0x0c +#define VC5_RSVD_CLK_R_12_CLK_AMP_4 0x0d +#define VC5_RSVD_CLK_R_34_CLK_AMP_4 0x0e +#define VC5_RSVD_CLK_AMP_123 0x0fI wonder whether it really makes sense to define so many registers that are not used in the driver. But it's done the same way in the Linux driver, and it doesn't hurt much, so I'll be fine with or without them.
I thought about it. Because it was a port from Linux, I thought it might be nice to keep it consistent, but I can remove the unused references for cleaner code.
Quoted 15 lines
[...]
drivers/clk/clk_versaclock.c line 839
Quoted 9 lines
drivers/clk/clk_versaclock.c new file +9
-0+static const struct udevice_id versaclock_ids[] = { + { .compatible ="idt,5p49v5923" , .data = (ulong)&idt_5p49v5923_info }, + { .compatible ="idt,5p49v5925" , .data = (ulong)&idt_5p49v5925_info }, + { .compatible ="idt,5p49v5933" , .data = (ulong)&idt_5p49v5933_info }, + { .compatible ="idt,5p49v5935" , .data = (ulong)&idt_5p49v5935_info }, + { .compatible ="idt,5p49v6901" , .data = (ulong)&idt_5p49v6901_info }, + { .compatible ="idt,5p49v6965" , .data = (ulong)&idt_5p49v6965_info }, + {}, +};Why not putting this array below, right before the
U_BOOT_DRIVER()call where it is used, similarly to the Linux driver?
i can do that.
Quoted 3 lines
--
Luca
Hi Adam,
Quoted 84 lines · Adam Ford
Quoted 7 lines · Luca Ceresoli
Quoted 2 lines · Adam Ford
The driver is based on the Versaclock driver from the Linux code, but do differences in the clock API between them, some pieces had to change.
s/do/due to/ ?
s/had to change/had to be changed/I am usually more careful about grammar. I must have been tired. :-)
Quoted 29 lines
Quoted 18 lines
This driver creates a mux, pfd, pll, and a series of fod ouputs.
Rate Usecnt Name
------------------------------------------25000000 0 `-- x304-clock 25000000 0 `-- [email protected] 25000000 0 |-- [email protected] 2800000000 0 | `-- [email protected] 33333333 0 | |-- [email protected] 33333333 0 | | `-- [email protected] 33333333 0 | |-- [email protected] 33333333 0 | | `-- [email protected] 50000000 0 | |-- [email protected] 50000000 0 | | `-- [email protected] 125000000 0 | `-- [email protected] 125000000 0 | `-- [email protected] 25000000 0 `-- [email protected]_sel_i2cbQuoted 4 lines
A translation function is added so the references to <&versaclock X> get routed to the corresponding [email protected].
Signed-off-by Adam Ford <[email protected]>I've been reviewing this patch and it looks mostly OK to me except for a few notes below, mostly minor ones. However my knowledge of the U-Boot driver model is minimal, thus I couldn't go in depth in the most interesting and critical part of Adam's work, i.e. the adaptations for the U-Boot codebase. I'm afraid I cannot do more.
Quoted 11 lines
drivers/clk/Makefile obj-$(CONFIG_SANDBOX_CLK_CCF) += clk_sandbox_ccf.o · line 54
Quoted 9 lines
drivers/clk/Makefile +1
-0@@ -51,3 +51,4 @@ obj-$(CONFIG_SANDBOX_CLK_CCF) += clk_sandbox_ccf.o obj-$(CONFIG_STM32H7) += clk_stm32h7.o obj-$(CONFIG_CLK_VERSAL) += clk_versal.o obj-$(CONFIG_CLK_CDCE9XX) += clk-cdce9xx.o +obj-$(CONFIG_CLK_VERSACLOCK) +=clk_versaclock.oNit: space after '+='.
make sense.
Quoted 21 lines
Quoted 21 lines
drivers/clk/clk_versaclock.c new file +14
-0@@ -0,0 +1,1025 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Driver for IDT Versaclock 5/6 +* +* Derived from code Copyright (C) 2017 Marek Vasut <[email protected]> +*/ + +#include <common.h> +#include <clk.h> +#include <clk-uclass.h> +#include <dm.h> +#include <errno.h> +#include <i2c.h> +#include <dm/device_compat.h> Quoted 8 lines
drivers/clk/clk_versaclock.c line 20
Quoted 6 lines
drivers/clk/clk_versaclock.c new file +6
-0+#include <log.h> +#include <linux/clk-provider.h> +#include <linux/kernel.h> +#include <linux/math64.h> + +#include <dt-bindings/clk/versaclock.h> Missing file?
Quoted 1 line
This was included a while ago in order to allow the device trees to build.
Apologies, I was on an old commit and didn't realize.
Signature · 1 line
Luca
Quoted 92 lines · Luca Ceresoli
Quoted 2 lines · Adam Ford
The driver is based on the Versaclock driver from the Linux code, but do differences in the clock API between them, some pieces had to change.
s/do/due to/ ?
s/had to change/had to be changed/Quoted 17 lines
This driver creates a mux, pfd, pll, and a series of fod ouputs.
Rate Usecnt Name
------------------------------------------25000000 0 `-- x304-clock 25000000 0 `-- [email protected] 25000000 0 |-- [email protected] 2800000000 0 | `-- [email protected] 33333333 0 | |-- [email protected] 33333333 0 | | `-- [email protected] 33333333 0 | |-- [email protected] 33333333 0 | | `-- [email protected] 50000000 0 | |-- [email protected] 50000000 0 | | `-- [email protected] 125000000 0 | `-- [email protected] 125000000 0 | `-- [email protected] 25000000 0 `-- [email protected]_sel_i2cbQuoted 4 lines
A translation function is added so the references to <&versaclock X> get routed to the corresponding [email protected].
Signed-off-by Adam Ford <[email protected]>I've been reviewing this patch and it looks mostly OK to me except for a few notes below, mostly minor ones. However my knowledge of the U-Boot driver model is minimal, thus I couldn't go in depth in the most interesting and critical part of Adam's work, i.e. the adaptations for the U-Boot codebase. I'm afraid I cannot do more.
drivers/clk/Makefile obj-$(CONFIG_SANDBOX_CLK_CCF) += clk_sandbox_ccf.o · line 54
Quoted 9 lines
drivers/clk/Makefile +1
-0@@ -51,3 +51,4 @@ obj-$(CONFIG_SANDBOX_CLK_CCF) += clk_sandbox_ccf.o obj-$(CONFIG_STM32H7) += clk_stm32h7.o obj-$(CONFIG_CLK_VERSAL) += clk_versal.o obj-$(CONFIG_CLK_CDCE9XX) += clk-cdce9xx.o +obj-$(CONFIG_CLK_VERSACLOCK) +=clk_versaclock.oNit: space after '+='.
Quoted 16 lines
drivers/clk/clk_versaclock.c new file +10
-0@@ -0,0 +1,1025 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Driver for IDT Versaclock 5/6 +* +* Derived from code Copyright (C) 2017 Marek Vasut <[email protected]> +*/ + +#include <common.h> +#include <clk.h> +#include <clk-uclass.h> drivers/clk/clk_versaclock.c line 20
Quoted 10 lines
drivers/clk/clk_versaclock.c new file +10
-0+#include <dm.h> +#include <errno.h> +#include <i2c.h> +#include <dm/device_compat.h> +#include <log.h> +#include <linux/clk-provider.h> +#include <linux/kernel.h> +#include <linux/math64.h> + +#include <dt-bindings/clk/versaclock.h> Missing file?
Quoted 16 lines
drivers/clk/clk_versaclock.c new file +16
-0+ +/* VersaClock5 registers */ +#define VC5_OTP_CONTROL 0x00 + +/* Factory-reserved register block */ +#define VC5_RSVD_DEVICE_ID 0x01 +#define VC5_RSVD_ADC_GAIN_7_0 0x02 +#define VC5_RSVD_ADC_GAIN_15_8 0x03 +#define VC5_RSVD_ADC_OFFSET_7_0 0x04 +#define VC5_RSVD_ADC_OFFSET_15_8 0x05 +#define VC5_RSVD_TEMPY 0x06 +#define VC5_RSVD_OFFSET_TBIN 0x07 +#define VC5_RSVD_GAIN 0x08 +#define VC5_RSVD_TEST_NP 0x09 +#define VC5_RSVD_UNUSED 0x0a +#define VC5_RSVD_BANDGAP_TRIM_UP 0x0b
Quoted 8 lines
drivers/clk/clk_versaclock.c line 40
Quoted 4 lines
drivers/clk/clk_versaclock.c new file +4
-0+#define VC5_RSVD_BANDGAP_TRIM_DN 0x0c +#define VC5_RSVD_CLK_R_12_CLK_AMP_4 0x0d +#define VC5_RSVD_CLK_R_34_CLK_AMP_4 0x0e +#define VC5_RSVD_CLK_AMP_123 0x0fI wonder whether it really makes sense to define so many registers that are not used in the driver. But it's done the same way in the Linux driver, and it doesn't hurt much, so I'll be fine with or without them.
I would leave them in so the next person who works on this driver doesn't have to add them.\
--Sean
Quoted 16 lines
[...]
drivers/clk/clk_versaclock.c line 839
Quoted 9 lines
drivers/clk/clk_versaclock.c new file +9
-0+static const struct udevice_id versaclock_ids[] = { + { .compatible ="idt,5p49v5923" , .data = (ulong)&idt_5p49v5923_info }, + { .compatible ="idt,5p49v5925" , .data = (ulong)&idt_5p49v5925_info }, + { .compatible ="idt,5p49v5933" , .data = (ulong)&idt_5p49v5933_info }, + { .compatible ="idt,5p49v5935" , .data = (ulong)&idt_5p49v5935_info }, + { .compatible ="idt,5p49v6901" , .data = (ulong)&idt_5p49v6901_info }, + { .compatible ="idt,5p49v6965" , .data = (ulong)&idt_5p49v6965_info }, + {}, +};Why not putting this array below, right before the
U_BOOT_DRIVER()call where it is used, similarly to the Linux driver?
Quoted 105 lines · Sean Anderson
Quoted 92 lines · Luca Ceresoli
Quoted 2 lines · Adam Ford
The driver is based on the Versaclock driver from the Linux code, but do differences in the clock API between them, some pieces had to change.
s/do/due to/ ?
s/had to change/had to be changed/Quoted 17 lines
This driver creates a mux, pfd, pll, and a series of fod ouputs.
Rate Usecnt Name
------------------------------------------25000000 0 `-- x304-clock 25000000 0 `-- [email protected] 25000000 0 |-- [email protected] 2800000000 0 | `-- [email protected] 33333333 0 | |-- [email protected] 33333333 0 | | `-- [email protected] 33333333 0 | |-- [email protected] 33333333 0 | | `-- [email protected] 50000000 0 | |-- [email protected] 50000000 0 | | `-- [email protected] 125000000 0 | `-- [email protected] 125000000 0 | `-- [email protected] 25000000 0 `-- [email protected]_sel_i2cbQuoted 4 lines
A translation function is added so the references to <&versaclock X> get routed to the corresponding [email protected].
Signed-off-by Adam Ford <[email protected]>I've been reviewing this patch and it looks mostly OK to me except for a few notes below, mostly minor ones. However my knowledge of the U-Boot driver model is minimal, thus I couldn't go in depth in the most interesting and critical part of Adam's work, i.e. the adaptations for the U-Boot codebase. I'm afraid I cannot do more.
drivers/clk/Makefile obj-$(CONFIG_SANDBOX_CLK_CCF) += clk_sandbox_ccf.o · line 54
Quoted 9 lines
drivers/clk/Makefile +1
-0@@ -51,3 +51,4 @@ obj-$(CONFIG_SANDBOX_CLK_CCF) += clk_sandbox_ccf.o obj-$(CONFIG_STM32H7) += clk_stm32h7.o obj-$(CONFIG_CLK_VERSAL) += clk_versal.o obj-$(CONFIG_CLK_CDCE9XX) += clk-cdce9xx.o +obj-$(CONFIG_CLK_VERSACLOCK) +=clk_versaclock.oNit: space after '+='.
Quoted 16 lines
drivers/clk/clk_versaclock.c new file +10
-0@@ -0,0 +1,1025 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Driver for IDT Versaclock 5/6 +* +* Derived from code Copyright (C) 2017 Marek Vasut <[email protected]> +*/ + +#include <common.h> +#include <clk.h> +#include <clk-uclass.h> drivers/clk/clk_versaclock.c line 20
Quoted 10 lines
drivers/clk/clk_versaclock.c new file +10
-0+#include <dm.h> +#include <errno.h> +#include <i2c.h> +#include <dm/device_compat.h> +#include <log.h> +#include <linux/clk-provider.h> +#include <linux/kernel.h> +#include <linux/math64.h> + +#include <dt-bindings/clk/versaclock.h> Missing file?
Quoted 16 lines
drivers/clk/clk_versaclock.c new file +16
-0+ +/* VersaClock5 registers */ +#define VC5_OTP_CONTROL 0x00 + +/* Factory-reserved register block */ +#define VC5_RSVD_DEVICE_ID 0x01 +#define VC5_RSVD_ADC_GAIN_7_0 0x02 +#define VC5_RSVD_ADC_GAIN_15_8 0x03 +#define VC5_RSVD_ADC_OFFSET_7_0 0x04 +#define VC5_RSVD_ADC_OFFSET_15_8 0x05 +#define VC5_RSVD_TEMPY 0x06 +#define VC5_RSVD_OFFSET_TBIN 0x07 +#define VC5_RSVD_GAIN 0x08 +#define VC5_RSVD_TEST_NP 0x09 +#define VC5_RSVD_UNUSED 0x0a +#define VC5_RSVD_BANDGAP_TRIM_UP 0x0bQuoted 8 lines
drivers/clk/clk_versaclock.c line 40
Quoted 4 lines
drivers/clk/clk_versaclock.c new file +4
-0+#define VC5_RSVD_BANDGAP_TRIM_DN 0x0c +#define VC5_RSVD_CLK_R_12_CLK_AMP_4 0x0d +#define VC5_RSVD_CLK_R_34_CLK_AMP_4 0x0e +#define VC5_RSVD_CLK_AMP_123 0x0fI wonder whether it really makes sense to define so many registers that are not used in the driver. But it's done the same way in the Linux driver, and it doesn't hurt much, so I'll be fine with or without them.
Quoted 1 line
I would leave them in so the next person who works on this driver doesn't have to add them.\
OK. Disregard my V2, and I'll submit a V3 today or tomorrow with the register definitions left intact.
adam
Quoted 19 lines
--Sean
Quoted 16 lines
[...]
drivers/clk/clk_versaclock.c line 839
Quoted 9 lines
drivers/clk/clk_versaclock.c new file +9
-0+static const struct udevice_id versaclock_ids[] = { + { .compatible ="idt,5p49v5923" , .data = (ulong)&idt_5p49v5923_info }, + { .compatible ="idt,5p49v5925" , .data = (ulong)&idt_5p49v5925_info }, + { .compatible ="idt,5p49v5933" , .data = (ulong)&idt_5p49v5933_info }, + { .compatible ="idt,5p49v5935" , .data = (ulong)&idt_5p49v5935_info }, + { .compatible ="idt,5p49v6901" , .data = (ulong)&idt_5p49v6901_info }, + { .compatible ="idt,5p49v6965" , .data = (ulong)&idt_5p49v6965_info }, + {}, +};Why not putting this array below, right before the
U_BOOT_DRIVER()call where it is used, similarly to the Linux driver?