USB: fotg210-hcd: remove dentry storage for debugfs file

PATCH New Greg Kroah-Hartman 1 participant 1 message May 25, 2021 USB

Share & tools

Greg Kroah-Hartman

author maintainer

2021-05-25 17:25 UTC #0 lore raw

PATCH 1/1 USB: fotg210-hcd: remove dentry storage for debugfs file

There is no need to store the dentry pointer for a debugfs file that we only use to remove it when the device goes away. debugfs can do the lookup for us instead, saving us some trouble, and making things smaller overall.

Signed-off-by Greg Kroah-Hartman <[email protected]>

---
 drivers/usb/host/fotg210-hcd.c | 5 +++--
 drivers/usb/host/fotg210.h     | 3 ---
 2 files changed, 3 insertions(+), 5 deletions(-)

drivers/usb/host/fotg210-hcd.c +3 -2

index 9c2eda0918e1..05fb8d97cf02 100644
@@ -850,7 +850,6 @@ static inline void create_debug_files(struct fotg210_hcd *fotg210)
 	struct dentry *root;
 
 	root = debugfs_create_dir(bus->bus_name, fotg210_debug_root);
-	fotg210->debug_dir = root;
 
 	debugfs_create_file("async", S_IRUGO, root, bus, &debug_async_fops);
 	debugfs_create_file("periodic", S_IRUGO, root, bus,

@@ -861,7 +860,9 @@ static inline void create_debug_files(struct fotg210_hcd *fotg210)
 
 static inline void remove_debug_files(struct fotg210_hcd *fotg210)
 {
-	debugfs_remove_recursive(fotg210->debug_dir);
+	struct usb_bus *bus = &fotg210_to_hcd(fotg210)->self;
+
+	debugfs_remove(debugfs_lookup(bus->bus_name, fotg210_debug_root));
 }
 
 /* handshake - spin reading hc until handshake completes or fails

drivers/usb/host/fotg210.h +0 -3

index 6cee40ec65b4..0a91061a0551 100644
@@ -184,9 +184,6 @@ struct fotg210_hcd {			/* one per controller */
 
 	/* silicon clock */
 	struct clk		*pclk;
-
-	/* debug files */
-	struct dentry		*debug_dir;
 };
 
 /* convert between an HCD pointer and the corresponding FOTG210_HCD */

Signature · 1 line

2.31.1